You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zclllyybb (via GitHub)" <gi...@apache.org> on 2025/12/29 10:02:01 UTC
[PR] branch-3.1: [Fix](auto-partition) Fix coredump caused by auto partition and auto increment column [doris]
zclllyybb opened a new pull request, #59457:
URL: https://github.com/apache/doris/pull/59457
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
when we use auto partition and auto increment column at the same time, the `_batching_block` for auto partition will `write` again. so also fill increment column twice. if at the same time there's complex column substitution, the second time we `write` the `_batching_block` we may treat a wrong column as inc column. it may coredump or write wrong data into target table.
a typical core stack is:
```
assert_cast.h:49] Bad cast from type:doris::vectorized::ColumnVector<int>* to doris::vectorized::ColumnStr<unsigned int> const*
*** Check failure stack trace: ***
@ 0x55daad57a906 google::LogMessageFatal::~LogMessageFatal()
@ 0x55daa2b1beb0 _ZZ11assert_castIPKN5doris10vectorized9ColumnStrIjEEL18TypeCheckOnRelease1EPKNS1_7IColumnEET_OT1_ENKUlOSA_E_clIS9_EES5_SD_
@ 0x55daa2b1bcb7 assert_cast<>()
@ 0x55daac65b83f doris::vectorized::OlapTableBlockConvertor::_internal_validate_column()
@ 0x55daac660465 doris::vectorized::OlapTableBlockConvertor::_validate_column()
@ 0x55daac65abc2 doris::vectorized::OlapTableBlockConvertor::_validate_data()
@ 0x55daac65987f doris::vectorized::OlapTableBlockConvertor::validate_and_convert_block()
@ 0x55daaca1f4ed doris::vectorized::VRowDistribution::generate_rows_distribution()
@ 0x55daaca07179 doris::vectorized::VTabletWriter::write()
@ 0x55daaca06dcf doris::vectorized::VTabletWriter::_send_new_partition_batch()
@ 0x55daaca06fb5 doris::vectorized::VTabletWriter::write()
@ 0x55daac9d0d54 doris::vectorized::AsyncResultWriter::process_block()
```
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.1: [Fix](auto-partition) Fix coredump caused by auto partition and auto increment column [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #59457:
URL: https://github.com/apache/doris/pull/59457#issuecomment-3696042956
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.1: [Fix](auto-partition) Fix coredump caused by auto partition and auto increment column [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #59457:
URL: https://github.com/apache/doris/pull/59457#issuecomment-3696067177
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.1: [Fix](auto-partition) Fix coredump caused by auto partition and auto increment column [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow closed pull request #59457: branch-3.1: [Fix](auto-partition) Fix coredump caused by auto partition and auto increment column
URL: https://github.com/apache/doris/pull/59457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.1: [Fix](auto-partition) Fix coredump caused by auto partition and auto increment column [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59457:
URL: https://github.com/apache/doris/pull/59457#issuecomment-3707584774
# BE UT Coverage Report
Increment line coverage `0.00% (0/28)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/949ecd5b43a6992f47dc56cb11e812f6875765e1_949ecd5b43a6992f47dc56cb11e812f6875765e1/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/949ecd5b43a6992f47dc56cb11e812f6875765e1_949ecd5b43a6992f47dc56cb11e812f6875765e1/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 45.82% (12967/28299) |
| Line Coverage | 36.69% (116165/316596) |
| Region Coverage | 34.23% (66200/193398) |
| Branch Coverage | 31.24% (34754/111256) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.1: [Fix](auto-partition) Fix coredump caused by auto partition and auto increment column [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #59457:
URL: https://github.com/apache/doris/pull/59457#issuecomment-3696088111
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.1: [Fix](auto-partition) Fix coredump caused by auto partition and auto increment column [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #59457:
URL: https://github.com/apache/doris/pull/59457#issuecomment-3707533141
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.1: [Fix](auto-partition) Fix coredump caused by auto partition and auto increment column [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #59457:
URL: https://github.com/apache/doris/pull/59457#issuecomment-3708651895
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.1: [Fix](auto-partition) Fix coredump caused by auto partition and auto increment column [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59457:
URL: https://github.com/apache/doris/pull/59457#issuecomment-3708928169
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (27/27)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59457_949ecd5b43a6992f47dc56cb11e812f6875765e1_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59457_949ecd5b43a6992f47dc56cb11e812f6875765e1_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 76.32% (21244/27834) |
| Line Coverage | 69.50% (219662/316055) |
| Region Coverage | 67.51% (131190/194315) |
| Branch Coverage | 61.18% (68416/111826) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org