You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "imrichardwu (via GitHub)" <gi...@apache.org> on 2026/02/19 18:25:27 UTC
[PR] feat: surface failed-run and missed-deadline indicators in the Grid view and add Deadlines tab to DAG run detail [airflow]
imrichardwu opened a new pull request, #62188:
URL: https://github.com/apache/airflow/pull/62188
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
This PR adds two complementary pieces of UI feedback for DAG runs in the Grid view:
1. **Failed-run indicator** – a warning icon (triangle with "!") is rendered above the
duration bar for any run whose state is `failed`. Clicking the icon navigates directly
to the run detail page (task-instances view), letting operators drill in without first
having to select the bar.
2. **Missed-deadline indicator** – a clock/deadline icon is rendered above the duration bar
(stacked above the failed icon when both apply) for any run that has at least one missed
deadline. Clicking it navigates to the new **Deadlines** tab described below.
### Backend changes
- `GridRunsResponse` (datamodel) gains a `has_missed_deadline: bool` field so the grid
endpoint can communicate per-run deadline status without an extra round-trip.
- A new private-UI router `deadlines_router` is mounted at `/ui/deadlines/{dag_id}/{run_id}`.
The endpoint fetches all `Deadline` rows for the given DAG run (joined with the associated
`DeadlineAlert` for name/description), orders them by `deadline_time`, and returns a list
of `DeadlineResponse` objects.
- `DeadlineResponse` exposes: `id`, `deadline_time`, `missed`, `created_at`,
`alert_name` (nullable), `alert_description` (nullable).
- The OpenAPI private-UI spec (`_private_ui.yaml`) is updated accordingly, and the generated
TypeScript client is regenerated.
### Frontend changes
- `FailedIcon` – new Chakra `createIcon` SVG component (warning triangle) for React usage.
- `DeadlineIcon` – new Chakra `createIcon` SVG component (clock) for React usage.
- `failedIconPlugin` – Chart.js plugin that draws warning triangles on the canvas above
failed bars inside `DurationChart`. (The canvas plugin path is kept separate from the
React icon because Chart.js operates on a `<canvas>` element.)
- `Bar` (`Grid/Bar.tsx`) – renders the `FailedIcon` and/or `DeadlineIcon` as absolute-
positioned ghost buttons above each bar, with dynamic vertical offsets so the icons
never overlap the bar or each other.
- `Deadlines` page (`pages/Run/Deadlines.tsx`) – sortable, filterable table of deadlines
for a DAG run. Columns: alert name, deadline time, status (Missed / On Track badge),
created at, description. A checkbox filters to missed deadlines only.
- Router and `Run` detail view are updated to include the new `deadlines` tab route.
<img width="1510" height="726" alt="Screenshot 2026-02-19 at 10 50 16 AM" src="https://github.com/user-attachments/assets/d07ebf28-6515-41e3-8c47-e0f8b2158be0" />
I am in the MLH Fellowship and working with @ferruzzi, so there are no GitHub issues for this.
---
##### Was generative AI tooling used to co-author this PR?
- [ ] Yes (please specify the tool below)
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: surface failed-run and missed-deadline indicators in the Grid view and add Deadlines tab to DAG run detail [airflow]
Posted by "imrichardwu (via GitHub)" <gi...@apache.org>.
imrichardwu commented on PR #62188:
URL: https://github.com/apache/airflow/pull/62188#issuecomment-3930730900
> Suggestion: can you split your PR into 2? One for the back-end, one for the front-end? It would make it easier to review, plus, very often back-end and front-end are not reviewed by the same persons so that way you get "specialized" reviews on back-end and front-end :)
here is the pr for the backend: https://github.com/apache/airflow/pull/62189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: surface failed-run and missed-deadline indicators in the Grid view and add Deadlines tab to DAG run detail [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #62188:
URL: https://github.com/apache/airflow/pull/62188#issuecomment-3929576969
Suggestion: can you split your PR into 2? One for the back-end, one for the front-end? It would make it easier to review, plus, very often back-end and front-end are not reviewed by the same persons so that way you get "specialized" reviews on back-end and front-end :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: surface failed-run and missed-deadline indicators in the Grid view and add Deadlines tab to DAG run detail [airflow]
Posted by "imrichardwu (via GitHub)" <gi...@apache.org>.
imrichardwu closed pull request #62188: feat: surface failed-run and missed-deadline indicators in the Grid view and add Deadlines tab to DAG run detail
URL: https://github.com/apache/airflow/pull/62188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org