You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hannahkamundson (via GitHub)" <gi...@apache.org> on 2023/12/01 19:30:34 UTC

[PR] [WIP][SPARK-46204][KUBERNETES] Switching the Kubernetes dev integration test script to use Java 17 instead of Java 8 [spark]

hannahkamundson opened a new pull request, #44112:
URL: https://github.com/apache/spark/pull/44112

   ### What changes were proposed in this pull request?
   Tie the Kubernetes integration dev test script to Java 17.
   
   
   ### Why are the changes needed?
   The Kubernetes dev integration test shell script was tied to Java 8. When it was run as is (and not forcing Java version >= 14), the build would fail because it couldn't build different features that required Java >= 14.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   I ran `./dev/dev-run-integration-tests.sh` and it worked.
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46204][K8S] Fix `dev-run-integration-tests.sh` to use 17 for `JAVA_VERSION` [spark]

Posted by "hannahkamundson (via GitHub)" <gi...@apache.org>.
hannahkamundson commented on PR #44112:
URL: https://github.com/apache/spark/pull/44112#issuecomment-1836778639

   @dongjoon-hyun No prob! Thanks for the fast review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46204][K8S] Fix `dev-run-integration-tests.sh` to use 17 for `JAVA_VERSION` [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44112:
URL: https://github.com/apache/spark/pull/44112#issuecomment-1836727739

   Merged to master for Apache Spark 4.0.0. Thank you again, @hannahkamundson .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46204][K8S] Fix `dev-run-integration-tests.sh` to use 17 for `JAVA_VERSION` [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44112: [SPARK-46204][K8S] Fix `dev-run-integration-tests.sh` to use 17 for `JAVA_VERSION`
URL: https://github.com/apache/spark/pull/44112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46204][K8S] Switching the Kubernetes dev integration test script to use Java 17 instead of Java 8 [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44112:
URL: https://github.com/apache/spark/pull/44112#issuecomment-1836698673

   It seems to be missed because the CI doesn't use `./dev/dev-run-integration-tests.sh` .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org