You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/24 20:12:29 UTC
[GitHub] [airflow] DreamPearl opened a new pull request #13880: fix #11557: Pass optimisation arguments to celery_command
DreamPearl opened a new pull request #13880:
URL: https://github.com/apache/airflow/pull/13880
Arguments: --without_mingle and --without_gossip
closes: #11557
related: #11557
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13880: fix #11557: Pass optimisation arguments to celery_command
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13880:
URL: https://github.com/apache/airflow/pull/13880#issuecomment-766424541
CC: @auvipy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13880: fix #11557: Pass optimisation arguments to celery_command
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13880:
URL: https://github.com/apache/airflow/pull/13880#discussion_r567653111
##########
File path: airflow/cli/commands/celery_command.py
##########
@@ -139,6 +139,8 @@ def worker(args):
'hostname': args.celery_hostname,
'loglevel': conf.get('logging', 'LOGGING_LEVEL'),
'pidfile': pid_file_path,
+ 'without_mingle': True,
+ 'without_gossip': True,
Review comment:
Should it not be configurable by users?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13880: fix #11557: Pass optimisation arguments to celery_command
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13880:
URL: https://github.com/apache/airflow/pull/13880#issuecomment-766425085
[The Workflow run](https://github.com/apache/airflow/actions/runs/507844893) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13880: fix #11557: Pass optimisation arguments to celery_command
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13880:
URL: https://github.com/apache/airflow/pull/13880#issuecomment-774508137
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #13880: fix #11557: Pass optimisation arguments to celery_command
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #13880:
URL: https://github.com/apache/airflow/pull/13880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] DreamPearl commented on a change in pull request #13880: fix #11557: Pass optimisation arguments to celery_command
Posted by GitBox <gi...@apache.org>.
DreamPearl commented on a change in pull request #13880:
URL: https://github.com/apache/airflow/pull/13880#discussion_r568704801
##########
File path: airflow/cli/commands/celery_command.py
##########
@@ -139,6 +139,8 @@ def worker(args):
'hostname': args.celery_hostname,
'loglevel': conf.get('logging', 'LOGGING_LEVEL'),
'pidfile': pid_file_path,
+ 'without_mingle': True,
+ 'without_gossip': True,
Review comment:
Yes, it should. I will fix it shortly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13880: fix #11557: Pass optimisation arguments to celery_command
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13880:
URL: https://github.com/apache/airflow/pull/13880#issuecomment-766425085
[The Workflow run](https://github.com/apache/airflow/actions/runs/507844893) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13880: fix #11557: Pass optimisation arguments to celery_command
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13880:
URL: https://github.com/apache/airflow/pull/13880#issuecomment-766424541
CC: @auvipy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] DreamPearl commented on a change in pull request #13880: fix #11557: Pass optimisation arguments to celery_command
Posted by GitBox <gi...@apache.org>.
DreamPearl commented on a change in pull request #13880:
URL: https://github.com/apache/airflow/pull/13880#discussion_r568704801
##########
File path: airflow/cli/commands/celery_command.py
##########
@@ -139,6 +139,8 @@ def worker(args):
'hostname': args.celery_hostname,
'loglevel': conf.get('logging', 'LOGGING_LEVEL'),
'pidfile': pid_file_path,
+ 'without_mingle': True,
+ 'without_gossip': True,
Review comment:
Yes, it should. I will fix it shortly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] DreamPearl commented on pull request #13880: fix #11557: Pass optimisation arguments to celery_command
Posted by GitBox <gi...@apache.org>.
DreamPearl commented on pull request #13880:
URL: https://github.com/apache/airflow/pull/13880#issuecomment-798952295
@mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org