You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@parquet.apache.org by "laurentgo (via GitHub)" <gi...@apache.org> on 2024/04/02 22:43:28 UTC
[PR] PARQUET-2458: Use --release 8 with java compiler [parquet-mr]
laurentgo opened a new pull request, #1311:
URL: https://github.com/apache/parquet-mr/pull/1311
Update maven-compiler-plugin to 3.13.0 version and use `maven.compiler.release` property instead of
`maven.compiler.{source|target}` to set which Java version to target.
Also remove argLine configuration entry from the plugin
- argLine is not a valid option (it's compilerArgs)
- XX:MaxPermSize has been ignored since java 8
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET-2458) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: no new test needed (no bugfix/new features ; change covered by existing tests)
### Commits
- [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Style
- [x] My contribution adheres to the code style guidelines and Spotless passes.
- To apply the necessary changes, run `mvn spotless:apply -Pvector-plugins`
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] PARQUET-2458: Use --release 8 with java compiler [parquet-mr]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1311:
URL: https://github.com/apache/parquet-mr/pull/1311#issuecomment-2037574289
@gszadovszky @Fokko Could you help review this as well? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] PARQUET-2458: Use --release 8 with java compiler [parquet-mr]
Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo commented on code in PR #1311:
URL: https://github.com/apache/parquet-mr/pull/1311#discussion_r1550945154
##########
pom.xml:
##########
@@ -650,6 +647,17 @@
</build>
<profiles>
+ <profile>
+ <id>jdk9+</id>
+ <activation>
+ <jdk>[9,)</jdk>
+ </activation>
+ <properties>
+ <!-- release takes precedence over source/target if java version is 9 or higher -->
+ <maven.compiler.release>8</maven.compiler.release>
Review Comment:
Instead of `1.8` you mean? Starting Java 9, version switched from 1.5, 1.6, 1.7 to 9, 10, 11. And the common practice is to use 8 although it may be possible that 1.8 is supported as well (but 1.9 would not work).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] PARQUET-2458: Use --release 8 with java compiler [parquet-mr]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1311:
URL: https://github.com/apache/parquet-mr/pull/1311#issuecomment-2078493846
Thanks @gszadovszky for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] PARQUET-2458: Use --release 8 with java compiler [parquet-mr]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #1311:
URL: https://github.com/apache/parquet-mr/pull/1311#discussion_r1550843082
##########
pom.xml:
##########
@@ -650,6 +647,17 @@
</build>
<profiles>
+ <profile>
+ <id>jdk9+</id>
+ <activation>
+ <jdk>[9,)</jdk>
+ </activation>
+ <properties>
+ <!-- release takes precedence over source/target if java version is 9 or higher -->
+ <maven.compiler.release>8</maven.compiler.release>
Review Comment:
Why putting 8 here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] PARQUET-2458: Use --release 8 with java compiler [parquet-mr]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac merged PR #1311:
URL: https://github.com/apache/parquet-mr/pull/1311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org