You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2016/09/01 19:44:56 UTC
[Impala-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail
Hello Internal Jenkins, Dan Hecht,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4249
to review the following change.
Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail
......................................................................
IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail
HdfsTableSink::Close() makes calls to functions that can fail with a
Status. However, since the function has a void return type, these
error statuses are just logged and we cannot take any action according
to the type of error.
This patch moves the closing of the partition file into the FlushFinal
function from Close(), so that in case of an error on closing the
file, the error is propagated up and some action can be taken.
We try and close all the partition files in the map in Close() as well
because if a query is cancelled, FlushFinal will not be called and we
would end up leaking some file descriptors.
Also fixed some long lines in this patch.
Change-Id: I2546bc68ba136b2713d744c1b920878606a2217b
Reviewed-on: http://gerrit.cloudera.org:8080/4018
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit 02608f89f5ee3385ef63533eb012cb75690d0b5d)
---
M be/src/exec/hdfs-table-sink.cc
M be/src/exec/hdfs-table-sink.h
2 files changed, 15 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/49/4249/1
--
To view, visit http://gerrit.cloudera.org:8080/4249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2546bc68ba136b2713d744c1b920878606a2217b
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
[Impala-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has abandoned this change.
Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/4249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I2546bc68ba136b2713d744c1b920878606a2217b
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>