You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "thisisnic (via GitHub)" <gi...@apache.org> on 2026/03/17 09:43:48 UTC

[PR] GH-49529: [R] CI job shows NOTE due to "non-API call" Rf_findVarInFrame [arrow]

thisisnic opened a new pull request, #49530:
URL: https://github.com/apache/arrow/pull/49530

   ### Rationale for this change
   
   CI job shows NOTE due to "non-API call" Rf_findVarInFrame
   
   ### What changes are included in this PR?
   
   Remove non-API calls to doesn't come up on CRAN notes
   
   ### Are these changes tested?
   
   I'll do some CI testing
   
   ### Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49529: [R] CI job shows NOTE due to "non-API call" Rf_findVarInFrame [arrow]

Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #49530:
URL: https://github.com/apache/arrow/pull/49530#issuecomment-4113434757

   > Do you we need (and maybe already have, I'm on mobile so haven't searched!) an issue for that stringi issue?
   
   FYI, I have a PR up for this (https://github.com/apache/arrow/pull/49581) though it's really an upstream issue
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49529: [R] CI job shows NOTE due to "non-API call" Rf_findVarInFrame [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic merged PR #49530:
URL: https://github.com/apache/arrow/pull/49530


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49529: [R] CI job shows NOTE due to "non-API call" Rf_findVarInFrame [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #49530:
URL: https://github.com/apache/arrow/pull/49530#issuecomment-4073738109

   @github-actions crossbow submit test-r-linux-sanitizers


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49529: [R] CI job shows NOTE due to "non-API call" Rf_findVarInFrame [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49530:
URL: https://github.com/apache/arrow/pull/49530#issuecomment-4073756926

   Revision: 2e1f1df5ec93ee36f71dcb51c16c05310d827764
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-a98e5d04ad](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a98e5d04ad)
   
   |Task|Status|
   |----|------|
   |test-r-linux-sanitizers|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a98e5d04ad-github-test-r-linux-sanitizers)](https://github.com/ursacomputing/crossbow/actions/runs/23188788230/job/67379065563)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49529: [R] CI job shows NOTE due to "non-API call" Rf_findVarInFrame [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #49530:
URL: https://github.com/apache/arrow/pull/49530#issuecomment-4073744376

   Testing with the sanitizer job as it's the only place I've seen this pop up (I think it just has a newer version of R-devel)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49529: [R] CI job shows NOTE due to "non-API call" Rf_findVarInFrame [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on code in PR #49530:
URL: https://github.com/apache/arrow/pull/49530#discussion_r2945629473


##########
r/src/arrow_cpp11.h:
##########
@@ -38,17 +38,6 @@
 #define ARROW_R_DCHECK(EXPR)
 #endif
 
-#if (R_VERSION < R_Version(3, 5, 0))

Review Comment:
   Removed this dead code as we're not supporting such old R versions any more



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49529: [R] CI job shows NOTE due to "non-API call" Rf_findVarInFrame [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49530:
URL: https://github.com/apache/arrow/pull/49530#issuecomment-4120537554

   After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ee7e2105354732f8521f41e48da1b3841c8873a4.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/68414710094) has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org