You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/12/02 02:47:23 UTC

[GitHub] [incubator-dolphinscheduler] GitFireMan commented on issue #4137: [Improvement][master] TaskPriorityQueueConsumer No need to sleep for one second

GitFireMan commented on issue #4137:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4137#issuecomment-736952753


   TaskPriorityQueueConsumer's logic is very easy. just cosume the task waiting to run in  priority queue. I think that there is no need a determine statement `if(queue.size() <= 0) Thread.sleep(1 second)`. because code below is `queue.take()` which is a blocking method if queue is empty.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org