You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/04/05 12:37:22 UTC

Review Request 45738: HIVE-13415: Decouple Sessions from thrift binary transport

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45738/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-13415
    https://issues.apache.org/jira/browse/HIVE-13415


Repository: hive-git


Description
-------

Current behaviour is:

* Open a thrift binary transport
* create a session
* close the transport

Then the session gets closed. Consequently, all the operations running in the session also get killed.

Whereas, if you open an HTTP transport, and close, the enclosing sessions are not closed. 

This seems like a bad design, having transport and sessions tightly coupled. I'd like to fix this. 

The issue that introduced it is [HIVE-9601|https://github.com/apache/hive/commit/48bea00c48853459af64b4ca9bfdc3e821c4ed82] Relevant discussions at [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223546&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223546], [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223827&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223827] and mentioned links on those comments. 

Another thing that seems like a slightly bad design is this line of code in ThriftBinaryCLIService:

{noformat}
server.setServerEventHandler(serverEventHandler);
{noformat}

Whereas serverEventHandler is defined by the base class, with no users except one sub-class(ThriftBinaryCLIService), violating the separation of concerns.


Diffs
-----

  service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java cf575a405f3eed2e1ec470670d5832ec3af9e1c1 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 0a2a761867ab596e942dbc78eaabc0ef920665a3 
  service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3bd82e614a50c0b5419a926ff00a95dafd4b0ebb 

Diff: https://reviews.apache.org/r/45738/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 45738: HIVE-13415: Decouple Sessions from thrift binary transport

Posted by Rajat Khandelwal <ra...@gmail.com>.

> On April 11, 2016, 11:39 a.m., Amareshwari Sriramadasu wrote:
> > service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java, line 194
> > <https://reviews.apache.org/r/45738/diff/3/?file=1327409#file1327409line194>
> >
> >     If client transport is closed, how are you able to do closeSession? Shouldnt you create a new client?
> 
> Rajat Khandelwal wrote:
>     Sessions are not tied to tranport now. And looking at the code, `client.closeSession` isn't using transport, it's delegating the call to `cliService`.

It's connecting again by the retry mechanism. Anyway, creating a new client and closing sessions through that now.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45738/#review128072
-----------------------------------------------------------


On April 13, 2016, 1:10 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45738/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 1:10 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-13415
>     https://issues.apache.org/jira/browse/HIVE-13415
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Current behaviour is:
> 
> * Open a thrift binary transport
> * create a session
> * close the transport
> 
> Then the session gets closed. Consequently, all the operations running in the session also get killed.
> 
> Whereas, if you open an HTTP transport, and close, the enclosing sessions are not closed. 
> 
> This seems like a bad design, having transport and sessions tightly coupled. I'd like to fix this. 
> 
> The issue that introduced it is [HIVE-9601|https://github.com/apache/hive/commit/48bea00c48853459af64b4ca9bfdc3e821c4ed82] Relevant discussions at [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223546&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223546], [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223827&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223827] and mentioned links on those comments. 
> 
> Another thing that seems like a slightly bad design is this line of code in ThriftBinaryCLIService:
> 
> {noformat}
> server.setServerEventHandler(serverEventHandler);
> {noformat}
> 
> Whereas serverEventHandler is defined by the base class, with no users except one sub-class(ThriftBinaryCLIService), violating the separation of concerns.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java c7e5b3305f2443a63b1f3210b3f2fdd563cab965 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java cf575a405f3eed2e1ec470670d5832ec3af9e1c1 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java be9833d1ac28951cb464716ddab4a7ea9d6b0a93 
>   service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3bd82e614a50c0b5419a926ff00a95dafd4b0ebb 
> 
> Diff: https://reviews.apache.org/r/45738/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 45738: HIVE-13415: Decouple Sessions from thrift binary transport

Posted by Rajat Khandelwal <ra...@gmail.com>.

> On April 11, 2016, 11:39 a.m., Amareshwari Sriramadasu wrote:
> > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java, line 156
> > <https://reviews.apache.org/r/45738/diff/3/?file=1327408#file1327408line156>
> >
> >     Why is this code movement to other class?

Because the base class has no need for this. This code piece is only relevant for binary thrift cli service, and not for all thrift cli services.


> On April 11, 2016, 11:39 a.m., Amareshwari Sriramadasu wrote:
> > service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java, line 194
> > <https://reviews.apache.org/r/45738/diff/3/?file=1327409#file1327409line194>
> >
> >     If client transport is closed, how are you able to do closeSession? Shouldnt you create a new client?

Sessions are not tied to tranport now. And looking at the code, `client.closeSession` isn't using transport, it's delegating the call to `cliService`.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45738/#review128072
-----------------------------------------------------------


On April 11, 2016, 11:59 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45738/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 11:59 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-13415
>     https://issues.apache.org/jira/browse/HIVE-13415
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Current behaviour is:
> 
> * Open a thrift binary transport
> * create a session
> * close the transport
> 
> Then the session gets closed. Consequently, all the operations running in the session also get killed.
> 
> Whereas, if you open an HTTP transport, and close, the enclosing sessions are not closed. 
> 
> This seems like a bad design, having transport and sessions tightly coupled. I'd like to fix this. 
> 
> The issue that introduced it is [HIVE-9601|https://github.com/apache/hive/commit/48bea00c48853459af64b4ca9bfdc3e821c4ed82] Relevant discussions at [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223546&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223546], [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223827&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223827] and mentioned links on those comments. 
> 
> Another thing that seems like a slightly bad design is this line of code in ThriftBinaryCLIService:
> 
> {noformat}
> server.setServerEventHandler(serverEventHandler);
> {noformat}
> 
> Whereas serverEventHandler is defined by the base class, with no users except one sub-class(ThriftBinaryCLIService), violating the separation of concerns.
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java a4a955844c3ebbfed255df37e6b9da1894537740 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java 6a872bc3480f7ad867cd82d6ecdbb29176d430e0 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 95c5c0efddf9cb91786d5379ecf7c5af50a315ea 
>   common/src/java/org/apache/hive/http/HttpServer.java b8836de1215a82a3f7fb3d39aa337a53a7662fed 
>   hbase-handler/src/test/results/positive/hbase_pushdown.q.out d5661be7bdae2d286fabc7f60d39716087b05b7a 
>   hbase-handler/src/test/results/positive/ppd_key_ranges.q.out 812ce9540209454e8ccf975128bb36d8bcd504e5 
>   itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java 6b337d2a19e1114821d59227da41db659ab85f5e 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerCheckInvocation.java 9f47f84b8acee78c16fbd1034bbc192285a7ca06 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java 5922a8c603e1597d6091b6fb64527d2c75f15a9c 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHA.java PRE-CREATION 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestHS2AuthzContext.java c43776b503caeef9813b9d66c5c05e9af27dd0d3 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestJdbcMetadataApiAuth.java 692bfa0d89ce4659e6e7de423ca95992d4ac2a33 
>   itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java 418f71eb87cdd519677b2f5a59c67099f704ec80 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/security/DummyAuthenticator.java a296ac5ca73ea49c39d9e58366b610cbb803aa39 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/security/InjectableDummyAuthenticator.java 322834e85ef19927777ca2d2b13a85a1e35410e1 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidatorForTest.java c0387e2514119a8c244ab70e8670eb48fd671397 
>   llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceRegistry.java f94a83743ab43e08ea630abc5b2c9063c7f756f0 
>   llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java 8cace8f541cdeea78c80f5e23c6c3ddcc888cec5 
>   llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java 59171567f5bfa43451b490ae1e78c873dc84af35 
>   llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java ba38fb815c0014f5df0b2daa01d9d82a4adf37fb 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapOptionsProcessor.java cdc919e174831a7bd7df555e9a055006298bba0e 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 86008323e67981416aef2b271fc9141803bd6e9d 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java e4c622e5b7f2989ea1e61cb4809713f82ba96866 
>   llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java bbdca7b832dc696ff8ccf8c8f39ddf4ade5a6844 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 7276e31ac2ec221c803b86f36d9cfcc4b2811e8c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractFileMergeOperator.java 154a78be660e16801587027a9b16f6181deb7541 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/AppMasterEventOperator.java 743098b064eda2658b941fba41442a43e64953d0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/CollectOperator.java 27ddf13a2137df5425e65caf8cd964af9429195e 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java f8520f8e3c04c97d3b709eeffc863353080ae60f 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java b897c16820a5299845b69c72b4afeafbb8b6d056 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DummyStoreOperator.java 06a38846cff69f288f4d92246a10a9fb107544b9 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FilterOperator.java 08f26337d755317edc1a54fed9dfe3d26dc6a355 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ForwardOperator.java 2df7cca8ddee4ac6cf2aa2bf76e2120e73d4bf47 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 0839b42bfcaf08862f0aece295f231ba1a4539f6 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableDummyOperator.java 47492476b755d8d70763d964c4b495f27dc8084a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/LateralViewForwardOperator.java 4c94ad94559acb0c584982bb2310af6142bca79c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/LateralViewJoinOperator.java 7407dc6d59eeb8852ff07d16d5ff260ae43a4148 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/LimitOperator.java 239d56bbcbb42eadb4563f3e6a372c8df31637da 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ListSinkOperator.java 2f2abc1cbb749de618616f1c036f0f9cb6da440a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 4608f70e989530fc22396a7d3ff620ddf176783b 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 4a546d1a8339767f1dbb0bd47c3ca0f239f19dad 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MuxOperator.java d8444fb0d6447b8b411b34370a6f9c6a5ac80ab8 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 571620e010573261faf06bac5750312ab8aca69c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/PTFOperator.java 2e9e539dfd7615ba4ce892626850abe2d2b78b28 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 2bce5d0aa0cb6f9fddb073d81e96e3ebcf657e20 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java e7c23e86f6d5256cbf3e6e4afd8d7204ce3e191a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java 58376145437eb6d274abe95e3c7fc7c73e30c983 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 5f2a0c203b0c0638edca0801b644ffdd9e13f1e8 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/TerminalOperator.java 04d6c9f757ee4f7d27237c4ed5d4163fac79357a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/UDTFOperator.java 1dae96303de4465010ffa6504e75b714a0cb3fa0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 3a673e6c1a95c0959ae9f6123c293504c1b33d6c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorAppMasterEventOperator.java c5912888a5a6671f17d24da7784596fe36da5413 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorFileSinkOperator.java f09534c81bc8e502bf57568476676484a7086e3e 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorFilterOperator.java 74a09472d10e097ead2dbff8d13cb58650a63060 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java 31f5c720566e163a78043d1166fb2602aff1df9a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorLimitOperator.java 154c647040418ccd3d255fe164288d6205217961 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapJoinOperator.java 622f77772dfa87df36bd7d337eecca3f22c7cc89 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapJoinOuterFilteredOperator.java 509a43f51e5d8052adc703991186dbff69bb31eb 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapOperator.java 033be3859b5f11b4bd21a2a6cac1cd744b5803b7 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorReduceSinkOperator.java b79a3d8fe388d80bc4ed506ed63e4b0cc30ce1fb 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorSMBMapJoinOperator.java 9a263e6ed9f68016900296b61903c2d79c972f00 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorSelectOperator.java 8db6eba75fa123f7bc7211d9a9b97afc31589884 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorSparkHashTableSinkOperator.java 1e550e7d50f0453ec50f6fac03e1abef84b2e936 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorSparkPartitionPruningSinkOperator.java 2f0225016baa83b8f9e008f12861306447aa63f1 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 30a0f5aa13af8cf522ed2f4e93df7ca280b7d5f8 
>   ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java bed17e9212e0767b80ed7aae5370c8d77f54daaf 
>   ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java 6702d432e5e56f5efdc003a0a60ab2bfb4cd2cdd 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRawRecordMerger.java f495be2f10350137dd43c38cadaf614985b386ac 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java bc17fece147ad6bf5488823c880d06342cf105f9 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapDecider.java 737d9c3cc779d6e15e9430d72f51b24ff68a378e 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java f6ba521e2c289025a0837485fec32afe06457e82 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/MaskAndFilterInfo.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java e81d46e7e9eb6b5c68aaa757b38c385e57db26f3 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java c47c2bd47f9ac46bb9e75463b325f0d5b11dbb9d 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkPartitionPruningSinkOperator.java 3f31fb522d6df056d37f1bdbedcfbd79c5892c34 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java 223718e27ae18dd685043a05cd7b1934b83d886b 
>   ql/src/java/org/apache/hadoop/hive/ql/processors/CommandUtil.java d98b30c7cac25c45939b22129daea68d94228fa8 
>   ql/src/java/org/apache/hadoop/hive/ql/security/HadoopDefaultAuthenticator.java 18e4e0062bb61ef64631c3ba6bb48e7a18cd5b54 
>   ql/src/java/org/apache/hadoop/hive/ql/security/HiveAuthenticationProvider.java 7befff8e510495a7c07ce4d844843a590f3a31d4 
>   ql/src/java/org/apache/hadoop/hive/ql/security/SessionStateConfigUserAuthenticator.java 8c7809ea7491b0dbf8523a74d0a28bb63c225a8f 
>   ql/src/java/org/apache/hadoop/hive/ql/security/SessionStateUserAuthenticator.java a77e93fddd2ddc120dfd0cef5aaba344c74c25ee 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/AuthorizationMetaStoreFilterHook.java 6bad99b9bd5b60a33fb07ac283c7a471460c8ffd 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 1b366c22c62049033843ae2da8bb4d69f5b2298a 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java 6e2ef8de9b5b55305deb2eafd8caa8b32bbf8134 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java c73d667a33e22b7855f52ace819794de4a89f996 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthzContext.java 195e341ade9bbb08dc6f7a348cc944dd5bec69df 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeObject.java 0364627e6147c6695f216b61c19d350ece85dcfc 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java c8aa9db31ae2c62dae1a58b706f0bdbada686282 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/QueryContext.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java e4ddc9bbd9c465ad553c55d3d0520f1544bc9455 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java c5d60b336c9a4e95b468e06520182c7281ba6d01 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java 159dd0f153ec17dc0eb60d6405dfc28c7c6b0d8f 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToDouble.java 576394762b90108d88e6e5b53122f5a07faf4cd8 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToFloat.java e2183f443914ce587b4b109aa80787666787e149 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java 5f5d1feeb7a23209f536c657f5469802a7f07203 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java 3eeabea6c7427bc045c211d84b3e9b772d6712f5 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java b9065b271a5a2c515ed0945a8242e89a9a0af09c 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestOperatorNames.java PRE-CREATION 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/util/FakeCaptureOutputOperator.java 74e077b2a2c52242bec1f07da299c881fc9903fc 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/util/FakeVectorDataSourceOperator.java d06d2142d66beed5ed5442d695d503a41db6c1e7 
>   ql/src/test/org/apache/hadoop/hive/ql/metadata/TestTableIterable.java PRE-CREATION 
>   ql/src/test/org/apache/hadoop/hive/ql/parse/TestSemanticAnalyzer.java be1f7ffc03f6844b27cf1f931165e02391d32d5b 
>   ql/src/test/queries/clientpositive/cbo_rp_udf_udaf_stats_opt.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/vector_between_in.q d57f98037681ee9089e716c6d526fd49d7695b43 
>   ql/src/test/results/clientpositive/annotate_stats_filter.q.out 7e697f1ac8aec489fc4be88cca18360049d2ac6f 
>   ql/src/test/results/clientpositive/auto_join16.q.out fc8712dc55a771dd3c68808bc17661061229f733 
>   ql/src/test/results/clientpositive/auto_join4.q.out 5ee76e40e2cf6f6380c32d3490d0c3070b86676c 
>   ql/src/test/results/clientpositive/auto_join5.q.out 71da7448407046d2c05e25d02cc851c92c7de8ec 
>   ql/src/test/results/clientpositive/auto_join8.q.out 80dd575c58add873ae34967b1d255ee5b63a9b07 
>   ql/src/test/results/clientpositive/auto_join_reordering_values.q.out ac349a4b64cfc08734acc4688464787a9dacbea7 
>   ql/src/test/results/clientpositive/cbo_const.q.out 770a6aaf2930ecad6b423ed521b10fdb766314b4 
>   ql/src/test/results/clientpositive/cbo_rp_join1.q.out 97ec21a8b6ce6f87eb9c296c65d1161e9cda331a 
>   ql/src/test/results/clientpositive/cbo_rp_udf_udaf_stats_opt.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/constprog_semijoin.q.out 940a148bf33285bd5e3ff806213aa2bbb2bb97ac 
>   ql/src/test/results/clientpositive/correlationoptimizer13.q.out 8aeec448640f8a9a612b74c87aca795601e5b97b 
>   ql/src/test/results/clientpositive/correlationoptimizer9.q.out 59f6abd7d93d62ba0076b323e804e17b34b1dda7 
>   ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out ea9529d7928d87420c653898daca7c6cfa262614 
>   ql/src/test/results/clientpositive/dynpart_sort_optimization.q.out 857d60904cdadca8e57deab210a667ae34f5e869 
>   ql/src/test/results/clientpositive/explain_logical.q.out bf35cd5eef5a3159070d772ee6999a8157a29dd1 
>   ql/src/test/results/clientpositive/filter_cond_pushdown.q.out 738286ebbbada17083dec466bba1ab51fd67ed5b 
>   ql/src/test/results/clientpositive/groupby_position.q.out 86900fca6b2b2b2ea56b9a81407bc7d1d21bb5b9 
>   ql/src/test/results/clientpositive/identity_project_remove_skip.q.out 874215515a52df6a394cadd084a6d6896074d177 
>   ql/src/test/results/clientpositive/index_auto_mult_tables.q.out e1ef94b14f9448e529d313af42d5976f29bc8c8a 
>   ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out 1e5899b85c227ff0ad2ee50dfccba4e3834fa78e 
>   ql/src/test/results/clientpositive/index_auto_self_join.q.out 189a35aa0427ddc18631042feb1f2b19cef3ffc5 
>   ql/src/test/results/clientpositive/index_bitmap3.q.out 5269b9c988618ad32b7ff12d047071a45e93ddc2 
>   ql/src/test/results/clientpositive/index_bitmap_auto.q.out 8c34084f051ce8e8e316b496114e8278257ab797 
>   ql/src/test/results/clientpositive/index_bitmap_compression.q.out d8fba353b47ef5db2a9e6bacb1abf3108b961a12 
>   ql/src/test/results/clientpositive/infer_const_type.q.out bd0fb9a32d8083d00fb68b334ae1c5b885a69609 
>   ql/src/test/results/clientpositive/input_testxpath4.q.out cdd8273e8ebb5413acb8d1bf96b702637a142e17 
>   ql/src/test/results/clientpositive/join16.q.out d0b5e19c84057878abd84b864457b7322754ab3a 
>   ql/src/test/results/clientpositive/join19.q.out 91ddc75f7c573de5d56d9919c62501aeb599e405 
>   ql/src/test/results/clientpositive/join4.q.out 9c3babead03c00c9b95fabc12582964d63cae682 
>   ql/src/test/results/clientpositive/join42.q.out 542408f0a38db6692f47c8a56bf16253904127d5 
>   ql/src/test/results/clientpositive/join5.q.out 0398655eb31abe3a7a89cb07c95e21b5700ad0a2 
>   ql/src/test/results/clientpositive/join8.q.out 493341d6a57c14582586632bcd22db1da132c16a 
>   ql/src/test/results/clientpositive/join_grp_diff_keys.q.out 53e33d1f68d56e296894b42a834a67bf8fc77c23 
>   ql/src/test/results/clientpositive/join_reorder2.q.out 092c5bcb9ac5bccdf4b97dd705bcb4871b7af143 
>   ql/src/test/results/clientpositive/join_reorder3.q.out 2aa501ecbdcd859d0371b45cd1334045f8e98b1e 
>   ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out c5a0aea01a8d16a6940cd68e38d22c8f52b22a48 
>   ql/src/test/results/clientpositive/llap/hybridgrace_hashjoin_2.q.out 185e0a513aa997058b89fad9acb097ceb0a0fa13 
>   ql/src/test/results/clientpositive/llap/tez_union_group_by.q.out 9573718ff2e694faec4bcf6f69ada6239b66b8ed 
>   ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out 4edc5619a33856621dbfd02e3dcbdbcc820910db 
>   ql/src/test/results/clientpositive/louter_join_ppr.q.out a1d7be2b5a20b583bacd943701d6e9a6cc10321a 
>   ql/src/test/results/clientpositive/masking_1.q.out ba2297e5039a67ccd68ed8c04093fe09d70a4d3c 
>   ql/src/test/results/clientpositive/masking_2.q.out 3feaa249b2d193d9c543b36178e9b6542ab45632 
>   ql/src/test/results/clientpositive/masking_3.q.out 55c9e8ff1550accb29888850abc11882ede64145 
>   ql/src/test/results/clientpositive/masking_4.q.out d2ab52ebd8bf1b88551c95b0ba0cd0acd3619cfc 
>   ql/src/test/results/clientpositive/masking_5.q.out 161ce1c90e164be8270fa6476d68138d89445bfb 
>   ql/src/test/results/clientpositive/masking_disablecbo_1.q.out 8a2bc9d39adaa910b14e82d76838f68008df6750 
>   ql/src/test/results/clientpositive/masking_disablecbo_2.q.out 57a8fca53f9c9998c2fee1a15001a77e960d0fc8 
>   ql/src/test/results/clientpositive/masking_disablecbo_3.q.out 8826500732492f18216d6faf2d82e261aa60d4ee 
>   ql/src/test/results/clientpositive/masking_disablecbo_4.q.out 8233936ccaf09fa563b20a6b137c00ce6566712c 
>   ql/src/test/results/clientpositive/multiMapJoin1.q.out cc54cac642c8520be22db99d476794a7c60650e3 
>   ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out abd3479ae686a0ce12736708ef7bda5a94a47d63 
>   ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out 13cf3eadb4c02fe07629903a8624fe8b2c71fdff 
>   ql/src/test/results/clientpositive/perf/query13.q.out ad5057616297e9e73da9b80f299455c8ce9c3dc3 
>   ql/src/test/results/clientpositive/perf/query15.q.out e8c06ad31f35d5c3b3509d3c05531939d776bd0e 
>   ql/src/test/results/clientpositive/perf/query17.q.out f8805e7abcf343d4a2ab83f89aba2562b13aacac 
>   ql/src/test/results/clientpositive/perf/query18.q.out 276ed57b8ce96639eb7aef47882a3692d006959f 
>   ql/src/test/results/clientpositive/perf/query19.q.out b0fda23dc72d015837ff819ef4ac6626505af0e3 
>   ql/src/test/results/clientpositive/perf/query21.q.out e6b12d47fc845c38c01f4f294ece96b533dd4200 
>   ql/src/test/results/clientpositive/perf/query22.q.out 7ee34234cdebb735a48e588a605dc7259161a802 
>   ql/src/test/results/clientpositive/perf/query25.q.out 0157845a6b5bfbc7654ae5a83c76905ed38b0ae3 
>   ql/src/test/results/clientpositive/perf/query26.q.out 3fadc8f01aba9afeb39758f720928aff9d055974 
>   ql/src/test/results/clientpositive/perf/query27.q.out 3a32d7bb104c698ed713e55987d82068d6397b90 
>   ql/src/test/results/clientpositive/perf/query29.q.out 299f16e63994d359e77cdecced2b484b1a8e5459 
>   ql/src/test/results/clientpositive/perf/query31.q.out a3c47a526460bd4ab6dd09efc972e7723e5045c3 
>   ql/src/test/results/clientpositive/perf/query34.q.out a08c3ff6c10da93229ec5e074dc98508896d958e 
>   ql/src/test/results/clientpositive/perf/query39.q.out fb77c7e448659246ebe8b569e5a4fe19d8a2a521 
>   ql/src/test/results/clientpositive/perf/query40.q.out 5e2ad72426156d163cd126c8e15348b389a73606 
>   ql/src/test/results/clientpositive/perf/query42.q.out 28d11df6366157ad10bc2f0554f7c704c8d86cb9 
>   ql/src/test/results/clientpositive/perf/query45.q.out 2985ba9ae249b5c7f55afa588b2359d222f47799 
>   ql/src/test/results/clientpositive/perf/query46.q.out 62d7e212791b12d9f974759b7fcb816cb7e92d63 
>   ql/src/test/results/clientpositive/perf/query48.q.out d536bb5fff8047bbf3ebbc89ac7ebe2ccb704d4c 
>   ql/src/test/results/clientpositive/perf/query50.q.out 4445e983c9176d3195fca9a32048dfc10ff9b9d1 
>   ql/src/test/results/clientpositive/perf/query52.q.out f5bc52b840ceb143c28bab6ee08411b068c45aba 
>   ql/src/test/results/clientpositive/perf/query54.q.out 9a0e9b4bde5192839bc2c659fe3dfc44f85250fe 
>   ql/src/test/results/clientpositive/perf/query55.q.out 91d0c725f8bc0810a14dc2e263d75d45b2335653 
>   ql/src/test/results/clientpositive/perf/query64.q.out dddcc8001fd0406c55e84beb892a32325b5baac8 
>   ql/src/test/results/clientpositive/perf/query65.q.out 37bb1b38b3c2db59ae9777794f6239b61dd35b26 
>   ql/src/test/results/clientpositive/perf/query66.q.out 41276317c330a0e2d5967018f74fab6cb7b9f507 
>   ql/src/test/results/clientpositive/perf/query67.q.out 83dab3890673bc96051541ae7cebab36a889f33c 
>   ql/src/test/results/clientpositive/perf/query68.q.out 38e464475548d1fa2fa4b91be5c847f194e0719e 
>   ql/src/test/results/clientpositive/perf/query7.q.out b5a82548c97b47ea6997835bc23cd7827625f1bd 
>   ql/src/test/results/clientpositive/perf/query71.q.out 504705bef7daa52b46bc628a9cd082c1f19723fa 
>   ql/src/test/results/clientpositive/perf/query72.q.out 6d8bd361435e1f1b77616cf637696f6a5421e1c9 
>   ql/src/test/results/clientpositive/perf/query73.q.out cf3a75e7b0237e984e5f2ad08b0f9e5f831d7936 
>   ql/src/test/results/clientpositive/perf/query75.q.out 25a877667bed9b8e9e2da881569a583e07722e3a 
>   ql/src/test/results/clientpositive/perf/query76.q.out c90578ba01560f9fcacb7113cbf0ea8d923b0a5a 
>   ql/src/test/results/clientpositive/perf/query79.q.out bf537b94fe71f93bdacf992f69be53860a297a1b 
>   ql/src/test/results/clientpositive/perf/query80.q.out e1bbb33ead810e8b4878538aae1bce86f05dac2d 
>   ql/src/test/results/clientpositive/perf/query82.q.out 57a50c719dd3f52c09535dc01fd71a5cd23b2cf7 
>   ql/src/test/results/clientpositive/perf/query84.q.out dfd5460e475eb93c74208565cb31a4e398be6a9d 
>   ql/src/test/results/clientpositive/perf/query85.q.out 93b5f4eba985db5f7892cfb0978b558f2d36fbc0 
>   ql/src/test/results/clientpositive/perf/query88.q.out 11f907ffe5813a0c7bb6c2ac9d69a54774923f5a 
>   ql/src/test/results/clientpositive/perf/query89.q.out 0cda4492b81d4a2e61cf65324a057299947019ba 
>   ql/src/test/results/clientpositive/perf/query90.q.out ccb61a44379262d02301f0b979d57ef93c29e4c0 
>   ql/src/test/results/clientpositive/perf/query91.q.out 66d8056f6873622e66b5e527cf60fc2539771e29 
>   ql/src/test/results/clientpositive/perf/query92.q.out 9327f5ae934243b0aeb4113de49ed65c8dbf87d7 
>   ql/src/test/results/clientpositive/perf/query93.q.out b2734687e39989431cbd31fd7780d900477acc90 
>   ql/src/test/results/clientpositive/perf/query94.q.out 76c12cdef784617c2ff9080312ad94bb2d41d5ac 
>   ql/src/test/results/clientpositive/perf/query95.q.out 6447b378c13d26de99da4a7e9724d11dee31ac1a 
>   ql/src/test/results/clientpositive/perf/query96.q.out 34e4bf9f9733d67b88991c5fc6efdf7d339c76eb 
>   ql/src/test/results/clientpositive/ppd_gby_join.q.out 721ca13aacf959cd341496dbe766fc947902622a 
>   ql/src/test/results/clientpositive/ppd_join.q.out 6b82401692672e7fe99c077ec0aadfcd4e3a0b73 
>   ql/src/test/results/clientpositive/ppd_join2.q.out 9487678ba84a3a0c39c5c7dd27a2c887cf5e5a31 
>   ql/src/test/results/clientpositive/ppd_join3.q.out c1586bc7e2c8ba3268c210bcee6e3157ff0393ee 
>   ql/src/test/results/clientpositive/ppd_join4.q.out cebb681ce74795c4b9ad6251497adedd53e171f6 
>   ql/src/test/results/clientpositive/ppd_outer_join2.q.out 17945787378896131d0d413b846fcf7db1261c6b 
>   ql/src/test/results/clientpositive/ppd_outer_join3.q.out b6b5a1c9a8bab48bed42a99fb00cc9d4c018896e 
>   ql/src/test/results/clientpositive/ppd_outer_join4.q.out 4abec730765a4d62893741890b1f3bfcd170bea3 
>   ql/src/test/results/clientpositive/ppd_udf_case.q.out bfe61c2a56c8ceb6e98353b7b6eca1143892a047 
>   ql/src/test/results/clientpositive/ppd_union.q.out 87b57c42f5ef3de408b0d2481d8c594ad4ada6fe 
>   ql/src/test/results/clientpositive/ppd_vc.q.out 457517219eec3536c91ee74a94dfcdb367b2bea3 
>   ql/src/test/results/clientpositive/rcfile_null_value.q.out c90287c619fd87e7e99f2ec1ee3746f67a516446 
>   ql/src/test/results/clientpositive/router_join_ppr.q.out 8a1012922c6425b8e1f8fa6f901a8d536daa6935 
>   ql/src/test/results/clientpositive/sample8.q.out a5ae1ef60bab699a2c25ad2f6b9566a5cdf430ea 
>   ql/src/test/results/clientpositive/semijoin.q.out 6005f728c76f04010a90e96d08bb0fbe0d171a1b 
>   ql/src/test/results/clientpositive/semijoin2.q.out 62e19613c5637156648076a1a617b11b665eec50 
>   ql/src/test/results/clientpositive/semijoin4.q.out 2aaf7ea52b0902502ceccc59fc3ec4e4442a5b0f 
>   ql/src/test/results/clientpositive/skewjoin_mapjoin9.q.out fd7763598d38a87ab4abe0bd077afe0d5cc66bc5 
>   ql/src/test/results/clientpositive/skewjoinopt12.q.out 3244e98fd57ffd3c4d8250d02255846d8b3474e6 
>   ql/src/test/results/clientpositive/skewjoinopt14.q.out 07d210b2dbfc662961877e1da5ea33f4dddec18a 
>   ql/src/test/results/clientpositive/skewjoinopt16.q.out e213cb7c22c4adaf54fa1d0d9bfe57bc8dc6d8c2 
>   ql/src/test/results/clientpositive/skewjoinopt17.q.out 759b9c2b993509d061833b41cec3901af42d5ed0 
>   ql/src/test/results/clientpositive/skewjoinopt2.q.out 0a16787b2158458e336cae25206de861e3ad624e 
>   ql/src/test/results/clientpositive/smb_mapjoin_10.q.out d2cbdd6180d1ced3750818eed94866351be020ee 
>   ql/src/test/results/clientpositive/smb_mapjoin_14.q.out b83c73677cca8776460d2b3d2c9b7f2e27134e91 
>   ql/src/test/results/clientpositive/sort_merge_join_desc_2.q.out 4ef2d81989420c7fee1f1c60cfdd386385a2111d 
>   ql/src/test/results/clientpositive/sort_merge_join_desc_3.q.out 34dbe86c306421a00ece827ec18df79b6481659b 
>   ql/src/test/results/clientpositive/sort_merge_join_desc_4.q.out a9b5b73d594d30ee443d2e175b8afa7f85782ce2 
>   ql/src/test/results/clientpositive/sort_merge_join_desc_8.q.out c5f0e696a0728321c8c82a9aceeb958294dca367 
>   ql/src/test/results/clientpositive/spark/auto_join16.q.out e9033cf792425c377c75a33ea99d03192cfe2ad9 
>   ql/src/test/results/clientpositive/spark/auto_join4.q.out 7cf582cef13bfebf76e5f4bcb9f5755b7b08acb6 
>   ql/src/test/results/clientpositive/spark/auto_join5.q.out 285450f239e1e8cee0421c7c12f3e5b45dedfea8 
>   ql/src/test/results/clientpositive/spark/auto_join8.q.out 7c4ed3a80428f97ac475ff68fc85cd7f32665f4b 
>   ql/src/test/results/clientpositive/spark/auto_join_reordering_values.q.out d6c5ae3b15338a0ee2bf822f13667b9c59e6dfb3 
>   ql/src/test/results/clientpositive/spark/constprog_semijoin.q.out 0ab1365e0e0b55d0fc72f397dcd7649b6af406c0 
>   ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out a7c1e7841afd6593d8b80a04695bc767d4b7c60b 
>   ql/src/test/results/clientpositive/spark/groupby_position.q.out 69d8e2ab524aa0b6c70c898140d87252649bb334 
>   ql/src/test/results/clientpositive/spark/identity_project_remove_skip.q.out d334b572a287df61124ef109d2fff3009c61705c 
>   ql/src/test/results/clientpositive/spark/index_auto_self_join.q.out 3cd23400a1679de6e165f51d83090f9ea74f4a99 
>   ql/src/test/results/clientpositive/spark/index_bitmap3.q.out b660ffeb6b8246b25d464966b5c6cc2f5d5dc7c7 
>   ql/src/test/results/clientpositive/spark/index_bitmap_auto.q.out ec96fc7536e309b5030a1bf458a418b79c8d5eef 
>   ql/src/test/results/clientpositive/spark/join16.q.out f64fb9871688ea855f81c8310d79f39c0ab90130 
>   ql/src/test/results/clientpositive/spark/join19.q.out 8995c97f186dfc7f8d812730f181ebe858be08c7 
>   ql/src/test/results/clientpositive/spark/join4.q.out 55b3a18cfeca24ff28e84e25a118fd6afda7299e 
>   ql/src/test/results/clientpositive/spark/join5.q.out 66451abaf05a29acd6903752ffd4331b6276402e 
>   ql/src/test/results/clientpositive/spark/join8.q.out bcf98c67bfda730970d9dcd6859e97754e2eab8c 
>   ql/src/test/results/clientpositive/spark/join_reorder2.q.out a0ec508a91c2a84ef381080b0fb068095c1a70b1 
>   ql/src/test/results/clientpositive/spark/join_reorder3.q.out 745fae57891a6f52241be4761dbb92cf8e0f49d5 
>   ql/src/test/results/clientpositive/spark/louter_join_ppr.q.out 1817ff1cbdda02e07355e189b07a8dc081c08f21 
>   ql/src/test/results/clientpositive/spark/ppd_gby_join.q.out fb37e00ca2d98f28398397352b1ee9c235795b83 
>   ql/src/test/results/clientpositive/spark/ppd_join.q.out 98affb5e6f2e2b40a9533f88a597e2273ec3909f 
>   ql/src/test/results/clientpositive/spark/ppd_join2.q.out 386a876797294287e3f39f77ff6a76dcd11ab4c6 
>   ql/src/test/results/clientpositive/spark/ppd_join3.q.out 2dff7ac9f79c58cb70df5eb0178f7ffd9d23c410 
>   ql/src/test/results/clientpositive/spark/ppd_outer_join2.q.out c6a5303e4ab76bae7e4a3e2c3653c45adfe54b1b 
>   ql/src/test/results/clientpositive/spark/ppd_outer_join3.q.out 2ecf671cc439db9427fd46a935c01400123ae48e 
>   ql/src/test/results/clientpositive/spark/ppd_outer_join4.q.out d4ba2a0ce941c15e384565feae890d82896eea6c 
>   ql/src/test/results/clientpositive/spark/router_join_ppr.q.out 853c454bdaa6e9801c1833d2c06ac5a6f4bfcacd 
>   ql/src/test/results/clientpositive/spark/sample8.q.out 1734361d60e67284fcefe5b2ebb0db6ecd6249cf 
>   ql/src/test/results/clientpositive/spark/semijoin.q.out b1dd351429b4e5e3674355dd1bcec5971713ddb7 
>   ql/src/test/results/clientpositive/spark/skewjoinopt12.q.out c329883c446a46ecdb9e4a2aca66d45824486a2c 
>   ql/src/test/results/clientpositive/spark/skewjoinopt14.q.out 70007d98ecca6e9ae3868704c132dcb56a36904b 
>   ql/src/test/results/clientpositive/spark/skewjoinopt16.q.out a1b0b0045bc0c5c84a75212c306f506780398124 
>   ql/src/test/results/clientpositive/spark/skewjoinopt17.q.out 928d39425eb6e5c6b5f48a2ca05d2622c407fe47 
>   ql/src/test/results/clientpositive/spark/skewjoinopt2.q.out f8f633d7bcde8567436f16faaa6a4bd9e085a373 
>   ql/src/test/results/clientpositive/spark/smb_mapjoin_10.q.out 876d996bf81eeea89c5bb1dac867b2d0fba3b813 
>   ql/src/test/results/clientpositive/spark/smb_mapjoin_14.q.out 20babcca632d4b9ba467e843ea266ff1f1a7c1b8 
>   ql/src/test/results/clientpositive/spark/sort_merge_join_desc_2.q.out 6f83401a9b329ef3007738c94efc057558c82221 
>   ql/src/test/results/clientpositive/spark/sort_merge_join_desc_3.q.out d705d9a97778f0367ff84555fc8b937472f3c708 
>   ql/src/test/results/clientpositive/spark/sort_merge_join_desc_4.q.out 0a70e59a61905dee9c995a5ec07cc80f470fe115 
>   ql/src/test/results/clientpositive/spark/sort_merge_join_desc_8.q.out 4614d9c54abe6cb89b7b95854f4a37233dc7dd3b 
>   ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning.q.out a628aae45897402afd240c084622d82ff4ef96ad 
>   ql/src/test/results/clientpositive/spark/spark_vectorized_dynamic_partition_pruning.q.out 9cab06c6d35e3ed60954909119ad796951f26459 
>   ql/src/test/results/clientpositive/spark/subquery_in.q.out eb6ff15aae37e6ce902cfec27eef3933c8c9e5e1 
>   ql/src/test/results/clientpositive/spark/vector_between_in.q.out 06490a818c2dc7d0160fd1594a45aa1c5c6a1460 
>   ql/src/test/results/clientpositive/spark/vector_mapjoin_reduce.q.out 2b7eb4707377d6f3b1e16cffa7db37bac49e1ddd 
>   ql/src/test/results/clientpositive/spark/vectorization_14.q.out c590173b6e4e1c7ef5e01e01226f1fe1b114e600 
>   ql/src/test/results/clientpositive/spark/vectorization_17.q.out 21053171a6d848f3321489159ac23a48ff2e2c50 
>   ql/src/test/results/clientpositive/spark/vectorized_string_funcs.q.out 0463d3160cf75b66efefedc94c759675ae150b4d 
>   ql/src/test/results/clientpositive/subquery_in.q.out 58f5618a097eeea4d6bb3dbd80d584d54424487e 
>   ql/src/test/results/clientpositive/tez/bucketpruning1.q.out 3557a3b4eda5c9695a3ffeaa35e192de756f434d 
>   ql/src/test/results/clientpositive/tez/constprog_semijoin.q.out 8fecbd7104b80d21f264a746ba0f002250c85027 
>   ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out 159415d0300ae6b3f63900d0ead083746e06f67e 
>   ql/src/test/results/clientpositive/tez/dynpart_sort_optimization.q.out 5292106074ed1eb222375f68df3e77d94d2e81fb 
>   ql/src/test/results/clientpositive/tez/explainuser_1.q.out 0eb913256cb8d23e7585177c0c9316a238d88469 
>   ql/src/test/results/clientpositive/tez/explainuser_2.q.out db1c5b5e4c25d1725edb5d6f7c0c0cbbfa3d5e7e 
>   ql/src/test/results/clientpositive/tez/explainuser_3.q.out 1222b94a7fccf976a50a71a2906609fc6dccf90e 
>   ql/src/test/results/clientpositive/tez/hybridgrace_hashjoin_2.q.out d44d7630879f4d42ae1bd1aaafdd9294fc28144e 
>   ql/src/test/results/clientpositive/tez/subquery_in.q.out cc60c538f12aec3e8587582636c6f47c973c3156 
>   ql/src/test/results/clientpositive/tez/tez_union_group_by.q.out 0efee376dec5d0695a6ac31790e31ebd8d8f3d64 
>   ql/src/test/results/clientpositive/tez/vector_aggregate_without_gby.q.out 55a3842c3b3b230c171ac2689cf0c8fa08f46d06 
>   ql/src/test/results/clientpositive/tez/vector_auto_smb_mapjoin_14.q.out 7175be0ba915dcba7685e720bc05f242d1d68d62 
>   ql/src/test/results/clientpositive/tez/vector_between_in.q.out 4ae687e6dc18ea3ba0191c25f3cb6af1581d4385 
>   ql/src/test/results/clientpositive/tez/vector_date_1.q.out 057d9744b11754eede38895b600d4647b1542a68 
>   ql/src/test/results/clientpositive/tez/vector_decimal_cast.q.out 35b7e87c6f8c20b23303ac63ebf2322aabfde5cd 
>   ql/src/test/results/clientpositive/tez/vector_decimal_expressions.q.out 2976cb5a5f8f413a04afa23ca6ce85fd193b098a 
>   ql/src/test/results/clientpositive/tez/vector_groupby_mapjoin.q.out 5c3e198ddcebad2c72f90121f75bcef9bae2b359 
>   ql/src/test/results/clientpositive/tez/vector_interval_2.q.out 18a25279e50df083cb7b4dc45ea5aa62039f69e3 
>   ql/src/test/results/clientpositive/tez/vector_join_part_col_char.q.out 7604538948a759b693fa1899e8aaadd32ab9427c 
>   ql/src/test/results/clientpositive/tez/vector_leftsemi_mapjoin.q.out d7bf9af1a3c9cf0df3aa29716308162dd9b5793c 
>   ql/src/test/results/clientpositive/tez/vector_mapjoin_reduce.q.out 8f5090a26e9200fa9efaa3fc501b4df4fb3e7328 
>   ql/src/test/results/clientpositive/tez/vectorization_14.q.out 43eec22f355438b3ded72ebdb7e7b63e65e9d092 
>   ql/src/test/results/clientpositive/tez/vectorization_17.q.out 25f6b2a813f935befb5b8ed1d95a3f925d4f4c20 
>   ql/src/test/results/clientpositive/tez/vectorization_7.q.out 165bfbfe0c8bad25693caf89747f223d8edb54ea 
>   ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out f3e31d4f4009bfec9abe972ee1e9720af59036c2 
>   ql/src/test/results/clientpositive/tez/vectorized_parquet_types.q.out 8355381070282852c124e16d45881577c74648da 
>   ql/src/test/results/clientpositive/tez/vectorized_string_funcs.q.out 0463d3160cf75b66efefedc94c759675ae150b4d 
>   ql/src/test/results/clientpositive/tez/vectorized_timestamp.q.out 5382865e2e530c0bd68a2e6282fbbfb230df1e8c 
>   ql/src/test/results/clientpositive/vector_between_in.q.out 4c3ed71520d44a03c3cb6b5b8fe970cddac3d34d 
>   ql/src/test/results/clientpositive/vector_date_1.q.out 9fa061f3897ff1d4f442be7bb292fac5885a850c 
>   ql/src/test/results/clientpositive/vector_decimal_cast.q.out 6f3f92f09e78ab4c8c6a2835ede51c236c2677c0 
>   ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 3ca326d1f16efd1c11c859a41c1074ea569047c7 
>   ql/src/test/results/clientpositive/vector_interval_2.q.out 8b8cf54d556bc0db32b7660a9f44181217db7c97 
>   ql/src/test/results/clientpositive/vector_leftsemi_mapjoin.q.out 983653861b93e0191de4a629dd0a8366583ae8d6 
>   ql/src/test/results/clientpositive/vector_mapjoin_reduce.q.out b99ba4c0259f2d205e6698cf5ce48e07453c4fba 
>   ql/src/test/results/clientpositive/vectorization_14.q.out c085a883d4f81756281f231a41b8e960da61804b 
>   ql/src/test/results/clientpositive/vectorization_17.q.out f19b778bfa083c1b1495e1f9709b9301a6256a06 
>   ql/src/test/results/clientpositive/vectorization_7.q.out 93326648efd799ce4de9899cb91063075a2d87a8 
>   ql/src/test/results/clientpositive/vectorized_string_funcs.q.out 67a1e62a9b373741265ff6073ec5e08593eea855 
>   service/src/jamon/org/apache/hive/tmpl/QueryProfileTmpl.jamon 8d51a73f7ac6c5eb5fe44c5525ed840b641c5c6b 
>   service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java 285b4f94ec828a357da4c2e7dc96c64bd459ff80 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java d9a273b1b95adf7a6a68fa013042da2408904d64 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 04d816a72afcadbff26f5eb5d68003a7344e31c9 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperationDisplay.java d2ca1e7b79e9722ad0ce990e96bf3fc9297ca7fd 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java cf575a405f3eed2e1ec470670d5832ec3af9e1c1 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 0a2a761867ab596e942dbc78eaabc0ef920665a3 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java d95f78f829eeb516973f4d6f67d0c10eb283e6a3 
>   service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp 8b46550b603a51ba6143c36746029475d7e11a40 
>   service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3bd82e614a50c0b5419a926ff00a95dafd4b0ebb 
>   shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java e02821248e11f6b24fba2f885ffcc780c12bd61d 
>   shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java a44d0c0a64238574fb9ea349e45974c3d6010219 
> 
> Diff: https://reviews.apache.org/r/45738/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 45738: HIVE-13415: Decouple Sessions from thrift binary transport

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45738/#review128072
-----------------------------------------------------------




service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
<https://reviews.apache.org/r/45738/#comment191464>

    Why is this code movement to other class?



service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java (line 174)
<https://reviews.apache.org/r/45738/#comment191463>

    If client transport is closed, how are you able to do closeSession? Shouldnt you create a new client?


- Amareshwari Sriramadasu


On April 6, 2016, 7:36 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45738/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 7:36 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-13415
>     https://issues.apache.org/jira/browse/HIVE-13415
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Current behaviour is:
> 
> * Open a thrift binary transport
> * create a session
> * close the transport
> 
> Then the session gets closed. Consequently, all the operations running in the session also get killed.
> 
> Whereas, if you open an HTTP transport, and close, the enclosing sessions are not closed. 
> 
> This seems like a bad design, having transport and sessions tightly coupled. I'd like to fix this. 
> 
> The issue that introduced it is [HIVE-9601|https://github.com/apache/hive/commit/48bea00c48853459af64b4ca9bfdc3e821c4ed82] Relevant discussions at [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223546&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223546], [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223827&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223827] and mentioned links on those comments. 
> 
> Another thing that seems like a slightly bad design is this line of code in ThriftBinaryCLIService:
> 
> {noformat}
> server.setServerEventHandler(serverEventHandler);
> {noformat}
> 
> Whereas serverEventHandler is defined by the base class, with no users except one sub-class(ThriftBinaryCLIService), violating the separation of concerns.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 95c5c0efddf9cb91786d5379ecf7c5af50a315ea 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java cf575a405f3eed2e1ec470670d5832ec3af9e1c1 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 0a2a761867ab596e942dbc78eaabc0ef920665a3 
>   service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3bd82e614a50c0b5419a926ff00a95dafd4b0ebb 
> 
> Diff: https://reviews.apache.org/r/45738/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 45738: HIVE-13415: Decouple Sessions from thrift binary transport

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45738/
-----------------------------------------------------------

(Updated April 13, 2016, 1:10 p.m.)


Review request for hive.


Bugs: HIVE-13415
    https://issues.apache.org/jira/browse/HIVE-13415


Repository: hive-git


Description
-------

Current behaviour is:

* Open a thrift binary transport
* create a session
* close the transport

Then the session gets closed. Consequently, all the operations running in the session also get killed.

Whereas, if you open an HTTP transport, and close, the enclosing sessions are not closed. 

This seems like a bad design, having transport and sessions tightly coupled. I'd like to fix this. 

The issue that introduced it is [HIVE-9601|https://github.com/apache/hive/commit/48bea00c48853459af64b4ca9bfdc3e821c4ed82] Relevant discussions at [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223546&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223546], [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223827&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223827] and mentioned links on those comments. 

Another thing that seems like a slightly bad design is this line of code in ThriftBinaryCLIService:

{noformat}
server.setServerEventHandler(serverEventHandler);
{noformat}

Whereas serverEventHandler is defined by the base class, with no users except one sub-class(ThriftBinaryCLIService), violating the separation of concerns.


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java c7e5b3305f2443a63b1f3210b3f2fdd563cab965 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java cf575a405f3eed2e1ec470670d5832ec3af9e1c1 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java be9833d1ac28951cb464716ddab4a7ea9d6b0a93 
  service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3bd82e614a50c0b5419a926ff00a95dafd4b0ebb 

Diff: https://reviews.apache.org/r/45738/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 45738: HIVE-13415: Decouple Sessions from thrift binary transport

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45738/
-----------------------------------------------------------

(Updated April 11, 2016, 11:59 a.m.)


Review request for hive.


Bugs: HIVE-13415
    https://issues.apache.org/jira/browse/HIVE-13415


Repository: hive-git


Description
-------

Current behaviour is:

* Open a thrift binary transport
* create a session
* close the transport

Then the session gets closed. Consequently, all the operations running in the session also get killed.

Whereas, if you open an HTTP transport, and close, the enclosing sessions are not closed. 

This seems like a bad design, having transport and sessions tightly coupled. I'd like to fix this. 

The issue that introduced it is [HIVE-9601|https://github.com/apache/hive/commit/48bea00c48853459af64b4ca9bfdc3e821c4ed82] Relevant discussions at [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223546&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223546], [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223827&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223827] and mentioned links on those comments. 

Another thing that seems like a slightly bad design is this line of code in ThriftBinaryCLIService:

{noformat}
server.setServerEventHandler(serverEventHandler);
{noformat}

Whereas serverEventHandler is defined by the base class, with no users except one sub-class(ThriftBinaryCLIService), violating the separation of concerns.


Diffs (updated)
-----

  beeline/src/java/org/apache/hive/beeline/BeeLine.java a4a955844c3ebbfed255df37e6b9da1894537740 
  beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java 6a872bc3480f7ad867cd82d6ecdbb29176d430e0 
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 95c5c0efddf9cb91786d5379ecf7c5af50a315ea 
  common/src/java/org/apache/hive/http/HttpServer.java b8836de1215a82a3f7fb3d39aa337a53a7662fed 
  hbase-handler/src/test/results/positive/hbase_pushdown.q.out d5661be7bdae2d286fabc7f60d39716087b05b7a 
  hbase-handler/src/test/results/positive/ppd_key_ranges.q.out 812ce9540209454e8ccf975128bb36d8bcd504e5 
  itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java 6b337d2a19e1114821d59227da41db659ab85f5e 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerCheckInvocation.java 9f47f84b8acee78c16fbd1034bbc192285a7ca06 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java 5922a8c603e1597d6091b6fb64527d2c75f15a9c 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHA.java PRE-CREATION 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestHS2AuthzContext.java c43776b503caeef9813b9d66c5c05e9af27dd0d3 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestJdbcMetadataApiAuth.java 692bfa0d89ce4659e6e7de423ca95992d4ac2a33 
  itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java 418f71eb87cdd519677b2f5a59c67099f704ec80 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/security/DummyAuthenticator.java a296ac5ca73ea49c39d9e58366b610cbb803aa39 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/security/InjectableDummyAuthenticator.java 322834e85ef19927777ca2d2b13a85a1e35410e1 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidatorForTest.java c0387e2514119a8c244ab70e8670eb48fd671397 
  llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceRegistry.java f94a83743ab43e08ea630abc5b2c9063c7f756f0 
  llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java 8cace8f541cdeea78c80f5e23c6c3ddcc888cec5 
  llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java 59171567f5bfa43451b490ae1e78c873dc84af35 
  llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java ba38fb815c0014f5df0b2daa01d9d82a4adf37fb 
  llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapOptionsProcessor.java cdc919e174831a7bd7df555e9a055006298bba0e 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 86008323e67981416aef2b271fc9141803bd6e9d 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java e4c622e5b7f2989ea1e61cb4809713f82ba96866 
  llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java bbdca7b832dc696ff8ccf8c8f39ddf4ade5a6844 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 7276e31ac2ec221c803b86f36d9cfcc4b2811e8c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractFileMergeOperator.java 154a78be660e16801587027a9b16f6181deb7541 
  ql/src/java/org/apache/hadoop/hive/ql/exec/AppMasterEventOperator.java 743098b064eda2658b941fba41442a43e64953d0 
  ql/src/java/org/apache/hadoop/hive/ql/exec/CollectOperator.java 27ddf13a2137df5425e65caf8cd964af9429195e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java f8520f8e3c04c97d3b709eeffc863353080ae60f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java b897c16820a5299845b69c72b4afeafbb8b6d056 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DummyStoreOperator.java 06a38846cff69f288f4d92246a10a9fb107544b9 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FilterOperator.java 08f26337d755317edc1a54fed9dfe3d26dc6a355 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ForwardOperator.java 2df7cca8ddee4ac6cf2aa2bf76e2120e73d4bf47 
  ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 0839b42bfcaf08862f0aece295f231ba1a4539f6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableDummyOperator.java 47492476b755d8d70763d964c4b495f27dc8084a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/LateralViewForwardOperator.java 4c94ad94559acb0c584982bb2310af6142bca79c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/LateralViewJoinOperator.java 7407dc6d59eeb8852ff07d16d5ff260ae43a4148 
  ql/src/java/org/apache/hadoop/hive/ql/exec/LimitOperator.java 239d56bbcbb42eadb4563f3e6a372c8df31637da 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ListSinkOperator.java 2f2abc1cbb749de618616f1c036f0f9cb6da440a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 4608f70e989530fc22396a7d3ff620ddf176783b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 4a546d1a8339767f1dbb0bd47c3ca0f239f19dad 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MuxOperator.java d8444fb0d6447b8b411b34370a6f9c6a5ac80ab8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 571620e010573261faf06bac5750312ab8aca69c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/PTFOperator.java 2e9e539dfd7615ba4ce892626850abe2d2b78b28 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 2bce5d0aa0cb6f9fddb073d81e96e3ebcf657e20 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java e7c23e86f6d5256cbf3e6e4afd8d7204ce3e191a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java 58376145437eb6d274abe95e3c7fc7c73e30c983 
  ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 5f2a0c203b0c0638edca0801b644ffdd9e13f1e8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/TerminalOperator.java 04d6c9f757ee4f7d27237c4ed5d4163fac79357a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/UDTFOperator.java 1dae96303de4465010ffa6504e75b714a0cb3fa0 
  ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 3a673e6c1a95c0959ae9f6123c293504c1b33d6c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorAppMasterEventOperator.java c5912888a5a6671f17d24da7784596fe36da5413 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorFileSinkOperator.java f09534c81bc8e502bf57568476676484a7086e3e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorFilterOperator.java 74a09472d10e097ead2dbff8d13cb58650a63060 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java 31f5c720566e163a78043d1166fb2602aff1df9a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorLimitOperator.java 154c647040418ccd3d255fe164288d6205217961 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapJoinOperator.java 622f77772dfa87df36bd7d337eecca3f22c7cc89 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapJoinOuterFilteredOperator.java 509a43f51e5d8052adc703991186dbff69bb31eb 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapOperator.java 033be3859b5f11b4bd21a2a6cac1cd744b5803b7 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorReduceSinkOperator.java b79a3d8fe388d80bc4ed506ed63e4b0cc30ce1fb 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorSMBMapJoinOperator.java 9a263e6ed9f68016900296b61903c2d79c972f00 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorSelectOperator.java 8db6eba75fa123f7bc7211d9a9b97afc31589884 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorSparkHashTableSinkOperator.java 1e550e7d50f0453ec50f6fac03e1abef84b2e936 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorSparkPartitionPruningSinkOperator.java 2f0225016baa83b8f9e008f12861306447aa63f1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 30a0f5aa13af8cf522ed2f4e93df7ca280b7d5f8 
  ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java bed17e9212e0767b80ed7aae5370c8d77f54daaf 
  ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java 6702d432e5e56f5efdc003a0a60ab2bfb4cd2cdd 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRawRecordMerger.java f495be2f10350137dd43c38cadaf614985b386ac 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java bc17fece147ad6bf5488823c880d06342cf105f9 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapDecider.java 737d9c3cc779d6e15e9430d72f51b24ff68a378e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java f6ba521e2c289025a0837485fec32afe06457e82 
  ql/src/java/org/apache/hadoop/hive/ql/parse/MaskAndFilterInfo.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java e81d46e7e9eb6b5c68aaa757b38c385e57db26f3 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java c47c2bd47f9ac46bb9e75463b325f0d5b11dbb9d 
  ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkPartitionPruningSinkOperator.java 3f31fb522d6df056d37f1bdbedcfbd79c5892c34 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java 223718e27ae18dd685043a05cd7b1934b83d886b 
  ql/src/java/org/apache/hadoop/hive/ql/processors/CommandUtil.java d98b30c7cac25c45939b22129daea68d94228fa8 
  ql/src/java/org/apache/hadoop/hive/ql/security/HadoopDefaultAuthenticator.java 18e4e0062bb61ef64631c3ba6bb48e7a18cd5b54 
  ql/src/java/org/apache/hadoop/hive/ql/security/HiveAuthenticationProvider.java 7befff8e510495a7c07ce4d844843a590f3a31d4 
  ql/src/java/org/apache/hadoop/hive/ql/security/SessionStateConfigUserAuthenticator.java 8c7809ea7491b0dbf8523a74d0a28bb63c225a8f 
  ql/src/java/org/apache/hadoop/hive/ql/security/SessionStateUserAuthenticator.java a77e93fddd2ddc120dfd0cef5aaba344c74c25ee 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/AuthorizationMetaStoreFilterHook.java 6bad99b9bd5b60a33fb07ac283c7a471460c8ffd 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 1b366c22c62049033843ae2da8bb4d69f5b2298a 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java 6e2ef8de9b5b55305deb2eafd8caa8b32bbf8134 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java c73d667a33e22b7855f52ace819794de4a89f996 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthzContext.java 195e341ade9bbb08dc6f7a348cc944dd5bec69df 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeObject.java 0364627e6147c6695f216b61c19d350ece85dcfc 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java c8aa9db31ae2c62dae1a58b706f0bdbada686282 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/QueryContext.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java e4ddc9bbd9c465ad553c55d3d0520f1544bc9455 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java c5d60b336c9a4e95b468e06520182c7281ba6d01 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java 159dd0f153ec17dc0eb60d6405dfc28c7c6b0d8f 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToDouble.java 576394762b90108d88e6e5b53122f5a07faf4cd8 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToFloat.java e2183f443914ce587b4b109aa80787666787e149 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java 5f5d1feeb7a23209f536c657f5469802a7f07203 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java 3eeabea6c7427bc045c211d84b3e9b772d6712f5 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java b9065b271a5a2c515ed0945a8242e89a9a0af09c 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestOperatorNames.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/util/FakeCaptureOutputOperator.java 74e077b2a2c52242bec1f07da299c881fc9903fc 
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/util/FakeVectorDataSourceOperator.java d06d2142d66beed5ed5442d695d503a41db6c1e7 
  ql/src/test/org/apache/hadoop/hive/ql/metadata/TestTableIterable.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/parse/TestSemanticAnalyzer.java be1f7ffc03f6844b27cf1f931165e02391d32d5b 
  ql/src/test/queries/clientpositive/cbo_rp_udf_udaf_stats_opt.q PRE-CREATION 
  ql/src/test/queries/clientpositive/vector_between_in.q d57f98037681ee9089e716c6d526fd49d7695b43 
  ql/src/test/results/clientpositive/annotate_stats_filter.q.out 7e697f1ac8aec489fc4be88cca18360049d2ac6f 
  ql/src/test/results/clientpositive/auto_join16.q.out fc8712dc55a771dd3c68808bc17661061229f733 
  ql/src/test/results/clientpositive/auto_join4.q.out 5ee76e40e2cf6f6380c32d3490d0c3070b86676c 
  ql/src/test/results/clientpositive/auto_join5.q.out 71da7448407046d2c05e25d02cc851c92c7de8ec 
  ql/src/test/results/clientpositive/auto_join8.q.out 80dd575c58add873ae34967b1d255ee5b63a9b07 
  ql/src/test/results/clientpositive/auto_join_reordering_values.q.out ac349a4b64cfc08734acc4688464787a9dacbea7 
  ql/src/test/results/clientpositive/cbo_const.q.out 770a6aaf2930ecad6b423ed521b10fdb766314b4 
  ql/src/test/results/clientpositive/cbo_rp_join1.q.out 97ec21a8b6ce6f87eb9c296c65d1161e9cda331a 
  ql/src/test/results/clientpositive/cbo_rp_udf_udaf_stats_opt.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/constprog_semijoin.q.out 940a148bf33285bd5e3ff806213aa2bbb2bb97ac 
  ql/src/test/results/clientpositive/correlationoptimizer13.q.out 8aeec448640f8a9a612b74c87aca795601e5b97b 
  ql/src/test/results/clientpositive/correlationoptimizer9.q.out 59f6abd7d93d62ba0076b323e804e17b34b1dda7 
  ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out ea9529d7928d87420c653898daca7c6cfa262614 
  ql/src/test/results/clientpositive/dynpart_sort_optimization.q.out 857d60904cdadca8e57deab210a667ae34f5e869 
  ql/src/test/results/clientpositive/explain_logical.q.out bf35cd5eef5a3159070d772ee6999a8157a29dd1 
  ql/src/test/results/clientpositive/filter_cond_pushdown.q.out 738286ebbbada17083dec466bba1ab51fd67ed5b 
  ql/src/test/results/clientpositive/groupby_position.q.out 86900fca6b2b2b2ea56b9a81407bc7d1d21bb5b9 
  ql/src/test/results/clientpositive/identity_project_remove_skip.q.out 874215515a52df6a394cadd084a6d6896074d177 
  ql/src/test/results/clientpositive/index_auto_mult_tables.q.out e1ef94b14f9448e529d313af42d5976f29bc8c8a 
  ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out 1e5899b85c227ff0ad2ee50dfccba4e3834fa78e 
  ql/src/test/results/clientpositive/index_auto_self_join.q.out 189a35aa0427ddc18631042feb1f2b19cef3ffc5 
  ql/src/test/results/clientpositive/index_bitmap3.q.out 5269b9c988618ad32b7ff12d047071a45e93ddc2 
  ql/src/test/results/clientpositive/index_bitmap_auto.q.out 8c34084f051ce8e8e316b496114e8278257ab797 
  ql/src/test/results/clientpositive/index_bitmap_compression.q.out d8fba353b47ef5db2a9e6bacb1abf3108b961a12 
  ql/src/test/results/clientpositive/infer_const_type.q.out bd0fb9a32d8083d00fb68b334ae1c5b885a69609 
  ql/src/test/results/clientpositive/input_testxpath4.q.out cdd8273e8ebb5413acb8d1bf96b702637a142e17 
  ql/src/test/results/clientpositive/join16.q.out d0b5e19c84057878abd84b864457b7322754ab3a 
  ql/src/test/results/clientpositive/join19.q.out 91ddc75f7c573de5d56d9919c62501aeb599e405 
  ql/src/test/results/clientpositive/join4.q.out 9c3babead03c00c9b95fabc12582964d63cae682 
  ql/src/test/results/clientpositive/join42.q.out 542408f0a38db6692f47c8a56bf16253904127d5 
  ql/src/test/results/clientpositive/join5.q.out 0398655eb31abe3a7a89cb07c95e21b5700ad0a2 
  ql/src/test/results/clientpositive/join8.q.out 493341d6a57c14582586632bcd22db1da132c16a 
  ql/src/test/results/clientpositive/join_grp_diff_keys.q.out 53e33d1f68d56e296894b42a834a67bf8fc77c23 
  ql/src/test/results/clientpositive/join_reorder2.q.out 092c5bcb9ac5bccdf4b97dd705bcb4871b7af143 
  ql/src/test/results/clientpositive/join_reorder3.q.out 2aa501ecbdcd859d0371b45cd1334045f8e98b1e 
  ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out c5a0aea01a8d16a6940cd68e38d22c8f52b22a48 
  ql/src/test/results/clientpositive/llap/hybridgrace_hashjoin_2.q.out 185e0a513aa997058b89fad9acb097ceb0a0fa13 
  ql/src/test/results/clientpositive/llap/tez_union_group_by.q.out 9573718ff2e694faec4bcf6f69ada6239b66b8ed 
  ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out 4edc5619a33856621dbfd02e3dcbdbcc820910db 
  ql/src/test/results/clientpositive/louter_join_ppr.q.out a1d7be2b5a20b583bacd943701d6e9a6cc10321a 
  ql/src/test/results/clientpositive/masking_1.q.out ba2297e5039a67ccd68ed8c04093fe09d70a4d3c 
  ql/src/test/results/clientpositive/masking_2.q.out 3feaa249b2d193d9c543b36178e9b6542ab45632 
  ql/src/test/results/clientpositive/masking_3.q.out 55c9e8ff1550accb29888850abc11882ede64145 
  ql/src/test/results/clientpositive/masking_4.q.out d2ab52ebd8bf1b88551c95b0ba0cd0acd3619cfc 
  ql/src/test/results/clientpositive/masking_5.q.out 161ce1c90e164be8270fa6476d68138d89445bfb 
  ql/src/test/results/clientpositive/masking_disablecbo_1.q.out 8a2bc9d39adaa910b14e82d76838f68008df6750 
  ql/src/test/results/clientpositive/masking_disablecbo_2.q.out 57a8fca53f9c9998c2fee1a15001a77e960d0fc8 
  ql/src/test/results/clientpositive/masking_disablecbo_3.q.out 8826500732492f18216d6faf2d82e261aa60d4ee 
  ql/src/test/results/clientpositive/masking_disablecbo_4.q.out 8233936ccaf09fa563b20a6b137c00ce6566712c 
  ql/src/test/results/clientpositive/multiMapJoin1.q.out cc54cac642c8520be22db99d476794a7c60650e3 
  ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out abd3479ae686a0ce12736708ef7bda5a94a47d63 
  ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out 13cf3eadb4c02fe07629903a8624fe8b2c71fdff 
  ql/src/test/results/clientpositive/perf/query13.q.out ad5057616297e9e73da9b80f299455c8ce9c3dc3 
  ql/src/test/results/clientpositive/perf/query15.q.out e8c06ad31f35d5c3b3509d3c05531939d776bd0e 
  ql/src/test/results/clientpositive/perf/query17.q.out f8805e7abcf343d4a2ab83f89aba2562b13aacac 
  ql/src/test/results/clientpositive/perf/query18.q.out 276ed57b8ce96639eb7aef47882a3692d006959f 
  ql/src/test/results/clientpositive/perf/query19.q.out b0fda23dc72d015837ff819ef4ac6626505af0e3 
  ql/src/test/results/clientpositive/perf/query21.q.out e6b12d47fc845c38c01f4f294ece96b533dd4200 
  ql/src/test/results/clientpositive/perf/query22.q.out 7ee34234cdebb735a48e588a605dc7259161a802 
  ql/src/test/results/clientpositive/perf/query25.q.out 0157845a6b5bfbc7654ae5a83c76905ed38b0ae3 
  ql/src/test/results/clientpositive/perf/query26.q.out 3fadc8f01aba9afeb39758f720928aff9d055974 
  ql/src/test/results/clientpositive/perf/query27.q.out 3a32d7bb104c698ed713e55987d82068d6397b90 
  ql/src/test/results/clientpositive/perf/query29.q.out 299f16e63994d359e77cdecced2b484b1a8e5459 
  ql/src/test/results/clientpositive/perf/query31.q.out a3c47a526460bd4ab6dd09efc972e7723e5045c3 
  ql/src/test/results/clientpositive/perf/query34.q.out a08c3ff6c10da93229ec5e074dc98508896d958e 
  ql/src/test/results/clientpositive/perf/query39.q.out fb77c7e448659246ebe8b569e5a4fe19d8a2a521 
  ql/src/test/results/clientpositive/perf/query40.q.out 5e2ad72426156d163cd126c8e15348b389a73606 
  ql/src/test/results/clientpositive/perf/query42.q.out 28d11df6366157ad10bc2f0554f7c704c8d86cb9 
  ql/src/test/results/clientpositive/perf/query45.q.out 2985ba9ae249b5c7f55afa588b2359d222f47799 
  ql/src/test/results/clientpositive/perf/query46.q.out 62d7e212791b12d9f974759b7fcb816cb7e92d63 
  ql/src/test/results/clientpositive/perf/query48.q.out d536bb5fff8047bbf3ebbc89ac7ebe2ccb704d4c 
  ql/src/test/results/clientpositive/perf/query50.q.out 4445e983c9176d3195fca9a32048dfc10ff9b9d1 
  ql/src/test/results/clientpositive/perf/query52.q.out f5bc52b840ceb143c28bab6ee08411b068c45aba 
  ql/src/test/results/clientpositive/perf/query54.q.out 9a0e9b4bde5192839bc2c659fe3dfc44f85250fe 
  ql/src/test/results/clientpositive/perf/query55.q.out 91d0c725f8bc0810a14dc2e263d75d45b2335653 
  ql/src/test/results/clientpositive/perf/query64.q.out dddcc8001fd0406c55e84beb892a32325b5baac8 
  ql/src/test/results/clientpositive/perf/query65.q.out 37bb1b38b3c2db59ae9777794f6239b61dd35b26 
  ql/src/test/results/clientpositive/perf/query66.q.out 41276317c330a0e2d5967018f74fab6cb7b9f507 
  ql/src/test/results/clientpositive/perf/query67.q.out 83dab3890673bc96051541ae7cebab36a889f33c 
  ql/src/test/results/clientpositive/perf/query68.q.out 38e464475548d1fa2fa4b91be5c847f194e0719e 
  ql/src/test/results/clientpositive/perf/query7.q.out b5a82548c97b47ea6997835bc23cd7827625f1bd 
  ql/src/test/results/clientpositive/perf/query71.q.out 504705bef7daa52b46bc628a9cd082c1f19723fa 
  ql/src/test/results/clientpositive/perf/query72.q.out 6d8bd361435e1f1b77616cf637696f6a5421e1c9 
  ql/src/test/results/clientpositive/perf/query73.q.out cf3a75e7b0237e984e5f2ad08b0f9e5f831d7936 
  ql/src/test/results/clientpositive/perf/query75.q.out 25a877667bed9b8e9e2da881569a583e07722e3a 
  ql/src/test/results/clientpositive/perf/query76.q.out c90578ba01560f9fcacb7113cbf0ea8d923b0a5a 
  ql/src/test/results/clientpositive/perf/query79.q.out bf537b94fe71f93bdacf992f69be53860a297a1b 
  ql/src/test/results/clientpositive/perf/query80.q.out e1bbb33ead810e8b4878538aae1bce86f05dac2d 
  ql/src/test/results/clientpositive/perf/query82.q.out 57a50c719dd3f52c09535dc01fd71a5cd23b2cf7 
  ql/src/test/results/clientpositive/perf/query84.q.out dfd5460e475eb93c74208565cb31a4e398be6a9d 
  ql/src/test/results/clientpositive/perf/query85.q.out 93b5f4eba985db5f7892cfb0978b558f2d36fbc0 
  ql/src/test/results/clientpositive/perf/query88.q.out 11f907ffe5813a0c7bb6c2ac9d69a54774923f5a 
  ql/src/test/results/clientpositive/perf/query89.q.out 0cda4492b81d4a2e61cf65324a057299947019ba 
  ql/src/test/results/clientpositive/perf/query90.q.out ccb61a44379262d02301f0b979d57ef93c29e4c0 
  ql/src/test/results/clientpositive/perf/query91.q.out 66d8056f6873622e66b5e527cf60fc2539771e29 
  ql/src/test/results/clientpositive/perf/query92.q.out 9327f5ae934243b0aeb4113de49ed65c8dbf87d7 
  ql/src/test/results/clientpositive/perf/query93.q.out b2734687e39989431cbd31fd7780d900477acc90 
  ql/src/test/results/clientpositive/perf/query94.q.out 76c12cdef784617c2ff9080312ad94bb2d41d5ac 
  ql/src/test/results/clientpositive/perf/query95.q.out 6447b378c13d26de99da4a7e9724d11dee31ac1a 
  ql/src/test/results/clientpositive/perf/query96.q.out 34e4bf9f9733d67b88991c5fc6efdf7d339c76eb 
  ql/src/test/results/clientpositive/ppd_gby_join.q.out 721ca13aacf959cd341496dbe766fc947902622a 
  ql/src/test/results/clientpositive/ppd_join.q.out 6b82401692672e7fe99c077ec0aadfcd4e3a0b73 
  ql/src/test/results/clientpositive/ppd_join2.q.out 9487678ba84a3a0c39c5c7dd27a2c887cf5e5a31 
  ql/src/test/results/clientpositive/ppd_join3.q.out c1586bc7e2c8ba3268c210bcee6e3157ff0393ee 
  ql/src/test/results/clientpositive/ppd_join4.q.out cebb681ce74795c4b9ad6251497adedd53e171f6 
  ql/src/test/results/clientpositive/ppd_outer_join2.q.out 17945787378896131d0d413b846fcf7db1261c6b 
  ql/src/test/results/clientpositive/ppd_outer_join3.q.out b6b5a1c9a8bab48bed42a99fb00cc9d4c018896e 
  ql/src/test/results/clientpositive/ppd_outer_join4.q.out 4abec730765a4d62893741890b1f3bfcd170bea3 
  ql/src/test/results/clientpositive/ppd_udf_case.q.out bfe61c2a56c8ceb6e98353b7b6eca1143892a047 
  ql/src/test/results/clientpositive/ppd_union.q.out 87b57c42f5ef3de408b0d2481d8c594ad4ada6fe 
  ql/src/test/results/clientpositive/ppd_vc.q.out 457517219eec3536c91ee74a94dfcdb367b2bea3 
  ql/src/test/results/clientpositive/rcfile_null_value.q.out c90287c619fd87e7e99f2ec1ee3746f67a516446 
  ql/src/test/results/clientpositive/router_join_ppr.q.out 8a1012922c6425b8e1f8fa6f901a8d536daa6935 
  ql/src/test/results/clientpositive/sample8.q.out a5ae1ef60bab699a2c25ad2f6b9566a5cdf430ea 
  ql/src/test/results/clientpositive/semijoin.q.out 6005f728c76f04010a90e96d08bb0fbe0d171a1b 
  ql/src/test/results/clientpositive/semijoin2.q.out 62e19613c5637156648076a1a617b11b665eec50 
  ql/src/test/results/clientpositive/semijoin4.q.out 2aaf7ea52b0902502ceccc59fc3ec4e4442a5b0f 
  ql/src/test/results/clientpositive/skewjoin_mapjoin9.q.out fd7763598d38a87ab4abe0bd077afe0d5cc66bc5 
  ql/src/test/results/clientpositive/skewjoinopt12.q.out 3244e98fd57ffd3c4d8250d02255846d8b3474e6 
  ql/src/test/results/clientpositive/skewjoinopt14.q.out 07d210b2dbfc662961877e1da5ea33f4dddec18a 
  ql/src/test/results/clientpositive/skewjoinopt16.q.out e213cb7c22c4adaf54fa1d0d9bfe57bc8dc6d8c2 
  ql/src/test/results/clientpositive/skewjoinopt17.q.out 759b9c2b993509d061833b41cec3901af42d5ed0 
  ql/src/test/results/clientpositive/skewjoinopt2.q.out 0a16787b2158458e336cae25206de861e3ad624e 
  ql/src/test/results/clientpositive/smb_mapjoin_10.q.out d2cbdd6180d1ced3750818eed94866351be020ee 
  ql/src/test/results/clientpositive/smb_mapjoin_14.q.out b83c73677cca8776460d2b3d2c9b7f2e27134e91 
  ql/src/test/results/clientpositive/sort_merge_join_desc_2.q.out 4ef2d81989420c7fee1f1c60cfdd386385a2111d 
  ql/src/test/results/clientpositive/sort_merge_join_desc_3.q.out 34dbe86c306421a00ece827ec18df79b6481659b 
  ql/src/test/results/clientpositive/sort_merge_join_desc_4.q.out a9b5b73d594d30ee443d2e175b8afa7f85782ce2 
  ql/src/test/results/clientpositive/sort_merge_join_desc_8.q.out c5f0e696a0728321c8c82a9aceeb958294dca367 
  ql/src/test/results/clientpositive/spark/auto_join16.q.out e9033cf792425c377c75a33ea99d03192cfe2ad9 
  ql/src/test/results/clientpositive/spark/auto_join4.q.out 7cf582cef13bfebf76e5f4bcb9f5755b7b08acb6 
  ql/src/test/results/clientpositive/spark/auto_join5.q.out 285450f239e1e8cee0421c7c12f3e5b45dedfea8 
  ql/src/test/results/clientpositive/spark/auto_join8.q.out 7c4ed3a80428f97ac475ff68fc85cd7f32665f4b 
  ql/src/test/results/clientpositive/spark/auto_join_reordering_values.q.out d6c5ae3b15338a0ee2bf822f13667b9c59e6dfb3 
  ql/src/test/results/clientpositive/spark/constprog_semijoin.q.out 0ab1365e0e0b55d0fc72f397dcd7649b6af406c0 
  ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out a7c1e7841afd6593d8b80a04695bc767d4b7c60b 
  ql/src/test/results/clientpositive/spark/groupby_position.q.out 69d8e2ab524aa0b6c70c898140d87252649bb334 
  ql/src/test/results/clientpositive/spark/identity_project_remove_skip.q.out d334b572a287df61124ef109d2fff3009c61705c 
  ql/src/test/results/clientpositive/spark/index_auto_self_join.q.out 3cd23400a1679de6e165f51d83090f9ea74f4a99 
  ql/src/test/results/clientpositive/spark/index_bitmap3.q.out b660ffeb6b8246b25d464966b5c6cc2f5d5dc7c7 
  ql/src/test/results/clientpositive/spark/index_bitmap_auto.q.out ec96fc7536e309b5030a1bf458a418b79c8d5eef 
  ql/src/test/results/clientpositive/spark/join16.q.out f64fb9871688ea855f81c8310d79f39c0ab90130 
  ql/src/test/results/clientpositive/spark/join19.q.out 8995c97f186dfc7f8d812730f181ebe858be08c7 
  ql/src/test/results/clientpositive/spark/join4.q.out 55b3a18cfeca24ff28e84e25a118fd6afda7299e 
  ql/src/test/results/clientpositive/spark/join5.q.out 66451abaf05a29acd6903752ffd4331b6276402e 
  ql/src/test/results/clientpositive/spark/join8.q.out bcf98c67bfda730970d9dcd6859e97754e2eab8c 
  ql/src/test/results/clientpositive/spark/join_reorder2.q.out a0ec508a91c2a84ef381080b0fb068095c1a70b1 
  ql/src/test/results/clientpositive/spark/join_reorder3.q.out 745fae57891a6f52241be4761dbb92cf8e0f49d5 
  ql/src/test/results/clientpositive/spark/louter_join_ppr.q.out 1817ff1cbdda02e07355e189b07a8dc081c08f21 
  ql/src/test/results/clientpositive/spark/ppd_gby_join.q.out fb37e00ca2d98f28398397352b1ee9c235795b83 
  ql/src/test/results/clientpositive/spark/ppd_join.q.out 98affb5e6f2e2b40a9533f88a597e2273ec3909f 
  ql/src/test/results/clientpositive/spark/ppd_join2.q.out 386a876797294287e3f39f77ff6a76dcd11ab4c6 
  ql/src/test/results/clientpositive/spark/ppd_join3.q.out 2dff7ac9f79c58cb70df5eb0178f7ffd9d23c410 
  ql/src/test/results/clientpositive/spark/ppd_outer_join2.q.out c6a5303e4ab76bae7e4a3e2c3653c45adfe54b1b 
  ql/src/test/results/clientpositive/spark/ppd_outer_join3.q.out 2ecf671cc439db9427fd46a935c01400123ae48e 
  ql/src/test/results/clientpositive/spark/ppd_outer_join4.q.out d4ba2a0ce941c15e384565feae890d82896eea6c 
  ql/src/test/results/clientpositive/spark/router_join_ppr.q.out 853c454bdaa6e9801c1833d2c06ac5a6f4bfcacd 
  ql/src/test/results/clientpositive/spark/sample8.q.out 1734361d60e67284fcefe5b2ebb0db6ecd6249cf 
  ql/src/test/results/clientpositive/spark/semijoin.q.out b1dd351429b4e5e3674355dd1bcec5971713ddb7 
  ql/src/test/results/clientpositive/spark/skewjoinopt12.q.out c329883c446a46ecdb9e4a2aca66d45824486a2c 
  ql/src/test/results/clientpositive/spark/skewjoinopt14.q.out 70007d98ecca6e9ae3868704c132dcb56a36904b 
  ql/src/test/results/clientpositive/spark/skewjoinopt16.q.out a1b0b0045bc0c5c84a75212c306f506780398124 
  ql/src/test/results/clientpositive/spark/skewjoinopt17.q.out 928d39425eb6e5c6b5f48a2ca05d2622c407fe47 
  ql/src/test/results/clientpositive/spark/skewjoinopt2.q.out f8f633d7bcde8567436f16faaa6a4bd9e085a373 
  ql/src/test/results/clientpositive/spark/smb_mapjoin_10.q.out 876d996bf81eeea89c5bb1dac867b2d0fba3b813 
  ql/src/test/results/clientpositive/spark/smb_mapjoin_14.q.out 20babcca632d4b9ba467e843ea266ff1f1a7c1b8 
  ql/src/test/results/clientpositive/spark/sort_merge_join_desc_2.q.out 6f83401a9b329ef3007738c94efc057558c82221 
  ql/src/test/results/clientpositive/spark/sort_merge_join_desc_3.q.out d705d9a97778f0367ff84555fc8b937472f3c708 
  ql/src/test/results/clientpositive/spark/sort_merge_join_desc_4.q.out 0a70e59a61905dee9c995a5ec07cc80f470fe115 
  ql/src/test/results/clientpositive/spark/sort_merge_join_desc_8.q.out 4614d9c54abe6cb89b7b95854f4a37233dc7dd3b 
  ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning.q.out a628aae45897402afd240c084622d82ff4ef96ad 
  ql/src/test/results/clientpositive/spark/spark_vectorized_dynamic_partition_pruning.q.out 9cab06c6d35e3ed60954909119ad796951f26459 
  ql/src/test/results/clientpositive/spark/subquery_in.q.out eb6ff15aae37e6ce902cfec27eef3933c8c9e5e1 
  ql/src/test/results/clientpositive/spark/vector_between_in.q.out 06490a818c2dc7d0160fd1594a45aa1c5c6a1460 
  ql/src/test/results/clientpositive/spark/vector_mapjoin_reduce.q.out 2b7eb4707377d6f3b1e16cffa7db37bac49e1ddd 
  ql/src/test/results/clientpositive/spark/vectorization_14.q.out c590173b6e4e1c7ef5e01e01226f1fe1b114e600 
  ql/src/test/results/clientpositive/spark/vectorization_17.q.out 21053171a6d848f3321489159ac23a48ff2e2c50 
  ql/src/test/results/clientpositive/spark/vectorized_string_funcs.q.out 0463d3160cf75b66efefedc94c759675ae150b4d 
  ql/src/test/results/clientpositive/subquery_in.q.out 58f5618a097eeea4d6bb3dbd80d584d54424487e 
  ql/src/test/results/clientpositive/tez/bucketpruning1.q.out 3557a3b4eda5c9695a3ffeaa35e192de756f434d 
  ql/src/test/results/clientpositive/tez/constprog_semijoin.q.out 8fecbd7104b80d21f264a746ba0f002250c85027 
  ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out 159415d0300ae6b3f63900d0ead083746e06f67e 
  ql/src/test/results/clientpositive/tez/dynpart_sort_optimization.q.out 5292106074ed1eb222375f68df3e77d94d2e81fb 
  ql/src/test/results/clientpositive/tez/explainuser_1.q.out 0eb913256cb8d23e7585177c0c9316a238d88469 
  ql/src/test/results/clientpositive/tez/explainuser_2.q.out db1c5b5e4c25d1725edb5d6f7c0c0cbbfa3d5e7e 
  ql/src/test/results/clientpositive/tez/explainuser_3.q.out 1222b94a7fccf976a50a71a2906609fc6dccf90e 
  ql/src/test/results/clientpositive/tez/hybridgrace_hashjoin_2.q.out d44d7630879f4d42ae1bd1aaafdd9294fc28144e 
  ql/src/test/results/clientpositive/tez/subquery_in.q.out cc60c538f12aec3e8587582636c6f47c973c3156 
  ql/src/test/results/clientpositive/tez/tez_union_group_by.q.out 0efee376dec5d0695a6ac31790e31ebd8d8f3d64 
  ql/src/test/results/clientpositive/tez/vector_aggregate_without_gby.q.out 55a3842c3b3b230c171ac2689cf0c8fa08f46d06 
  ql/src/test/results/clientpositive/tez/vector_auto_smb_mapjoin_14.q.out 7175be0ba915dcba7685e720bc05f242d1d68d62 
  ql/src/test/results/clientpositive/tez/vector_between_in.q.out 4ae687e6dc18ea3ba0191c25f3cb6af1581d4385 
  ql/src/test/results/clientpositive/tez/vector_date_1.q.out 057d9744b11754eede38895b600d4647b1542a68 
  ql/src/test/results/clientpositive/tez/vector_decimal_cast.q.out 35b7e87c6f8c20b23303ac63ebf2322aabfde5cd 
  ql/src/test/results/clientpositive/tez/vector_decimal_expressions.q.out 2976cb5a5f8f413a04afa23ca6ce85fd193b098a 
  ql/src/test/results/clientpositive/tez/vector_groupby_mapjoin.q.out 5c3e198ddcebad2c72f90121f75bcef9bae2b359 
  ql/src/test/results/clientpositive/tez/vector_interval_2.q.out 18a25279e50df083cb7b4dc45ea5aa62039f69e3 
  ql/src/test/results/clientpositive/tez/vector_join_part_col_char.q.out 7604538948a759b693fa1899e8aaadd32ab9427c 
  ql/src/test/results/clientpositive/tez/vector_leftsemi_mapjoin.q.out d7bf9af1a3c9cf0df3aa29716308162dd9b5793c 
  ql/src/test/results/clientpositive/tez/vector_mapjoin_reduce.q.out 8f5090a26e9200fa9efaa3fc501b4df4fb3e7328 
  ql/src/test/results/clientpositive/tez/vectorization_14.q.out 43eec22f355438b3ded72ebdb7e7b63e65e9d092 
  ql/src/test/results/clientpositive/tez/vectorization_17.q.out 25f6b2a813f935befb5b8ed1d95a3f925d4f4c20 
  ql/src/test/results/clientpositive/tez/vectorization_7.q.out 165bfbfe0c8bad25693caf89747f223d8edb54ea 
  ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out f3e31d4f4009bfec9abe972ee1e9720af59036c2 
  ql/src/test/results/clientpositive/tez/vectorized_parquet_types.q.out 8355381070282852c124e16d45881577c74648da 
  ql/src/test/results/clientpositive/tez/vectorized_string_funcs.q.out 0463d3160cf75b66efefedc94c759675ae150b4d 
  ql/src/test/results/clientpositive/tez/vectorized_timestamp.q.out 5382865e2e530c0bd68a2e6282fbbfb230df1e8c 
  ql/src/test/results/clientpositive/vector_between_in.q.out 4c3ed71520d44a03c3cb6b5b8fe970cddac3d34d 
  ql/src/test/results/clientpositive/vector_date_1.q.out 9fa061f3897ff1d4f442be7bb292fac5885a850c 
  ql/src/test/results/clientpositive/vector_decimal_cast.q.out 6f3f92f09e78ab4c8c6a2835ede51c236c2677c0 
  ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 3ca326d1f16efd1c11c859a41c1074ea569047c7 
  ql/src/test/results/clientpositive/vector_interval_2.q.out 8b8cf54d556bc0db32b7660a9f44181217db7c97 
  ql/src/test/results/clientpositive/vector_leftsemi_mapjoin.q.out 983653861b93e0191de4a629dd0a8366583ae8d6 
  ql/src/test/results/clientpositive/vector_mapjoin_reduce.q.out b99ba4c0259f2d205e6698cf5ce48e07453c4fba 
  ql/src/test/results/clientpositive/vectorization_14.q.out c085a883d4f81756281f231a41b8e960da61804b 
  ql/src/test/results/clientpositive/vectorization_17.q.out f19b778bfa083c1b1495e1f9709b9301a6256a06 
  ql/src/test/results/clientpositive/vectorization_7.q.out 93326648efd799ce4de9899cb91063075a2d87a8 
  ql/src/test/results/clientpositive/vectorized_string_funcs.q.out 67a1e62a9b373741265ff6073ec5e08593eea855 
  service/src/jamon/org/apache/hive/tmpl/QueryProfileTmpl.jamon 8d51a73f7ac6c5eb5fe44c5525ed840b641c5c6b 
  service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java 285b4f94ec828a357da4c2e7dc96c64bd459ff80 
  service/src/java/org/apache/hive/service/cli/operation/Operation.java d9a273b1b95adf7a6a68fa013042da2408904d64 
  service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 04d816a72afcadbff26f5eb5d68003a7344e31c9 
  service/src/java/org/apache/hive/service/cli/operation/SQLOperationDisplay.java d2ca1e7b79e9722ad0ce990e96bf3fc9297ca7fd 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java cf575a405f3eed2e1ec470670d5832ec3af9e1c1 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 0a2a761867ab596e942dbc78eaabc0ef920665a3 
  service/src/java/org/apache/hive/service/server/HiveServer2.java d95f78f829eeb516973f4d6f67d0c10eb283e6a3 
  service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp 8b46550b603a51ba6143c36746029475d7e11a40 
  service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3bd82e614a50c0b5419a926ff00a95dafd4b0ebb 
  shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java e02821248e11f6b24fba2f885ffcc780c12bd61d 
  shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java a44d0c0a64238574fb9ea349e45974c3d6010219 

Diff: https://reviews.apache.org/r/45738/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 45738: HIVE-13415: Decouple Sessions from thrift binary transport

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45738/
-----------------------------------------------------------

(Updated April 6, 2016, 1:06 p.m.)


Review request for hive.


Bugs: HIVE-13415
    https://issues.apache.org/jira/browse/HIVE-13415


Repository: hive-git


Description
-------

Current behaviour is:

* Open a thrift binary transport
* create a session
* close the transport

Then the session gets closed. Consequently, all the operations running in the session also get killed.

Whereas, if you open an HTTP transport, and close, the enclosing sessions are not closed. 

This seems like a bad design, having transport and sessions tightly coupled. I'd like to fix this. 

The issue that introduced it is [HIVE-9601|https://github.com/apache/hive/commit/48bea00c48853459af64b4ca9bfdc3e821c4ed82] Relevant discussions at [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223546&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223546], [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223827&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223827] and mentioned links on those comments. 

Another thing that seems like a slightly bad design is this line of code in ThriftBinaryCLIService:

{noformat}
server.setServerEventHandler(serverEventHandler);
{noformat}

Whereas serverEventHandler is defined by the base class, with no users except one sub-class(ThriftBinaryCLIService), violating the separation of concerns.


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 95c5c0efddf9cb91786d5379ecf7c5af50a315ea 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java cf575a405f3eed2e1ec470670d5832ec3af9e1c1 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 0a2a761867ab596e942dbc78eaabc0ef920665a3 
  service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3bd82e614a50c0b5419a926ff00a95dafd4b0ebb 

Diff: https://reviews.apache.org/r/45738/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 45738: HIVE-13415: Decouple Sessions from thrift binary transport

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45738/
-----------------------------------------------------------

(Updated April 6, 2016, 1:05 p.m.)


Review request for hive.


Bugs: HIVE-13415
    https://issues.apache.org/jira/browse/HIVE-13415


Repository: hive-git


Description
-------

Current behaviour is:

* Open a thrift binary transport
* create a session
* close the transport

Then the session gets closed. Consequently, all the operations running in the session also get killed.

Whereas, if you open an HTTP transport, and close, the enclosing sessions are not closed. 

This seems like a bad design, having transport and sessions tightly coupled. I'd like to fix this. 

The issue that introduced it is [HIVE-9601|https://github.com/apache/hive/commit/48bea00c48853459af64b4ca9bfdc3e821c4ed82] Relevant discussions at [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223546&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223546], [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223827&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223827] and mentioned links on those comments. 

Another thing that seems like a slightly bad design is this line of code in ThriftBinaryCLIService:

{noformat}
server.setServerEventHandler(serverEventHandler);
{noformat}

Whereas serverEventHandler is defined by the base class, with no users except one sub-class(ThriftBinaryCLIService), violating the separation of concerns.


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 95c5c0efddf9cb91786d5379ecf7c5af50a315ea 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java cf575a405f3eed2e1ec470670d5832ec3af9e1c1 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 0a2a761867ab596e942dbc78eaabc0ef920665a3 
  service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3bd82e614a50c0b5419a926ff00a95dafd4b0ebb 

Diff: https://reviews.apache.org/r/45738/diff/


Testing
-------


Thanks,

Rajat Khandelwal