You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "peter-toth (via GitHub)" <gi...@apache.org> on 2023/08/22 12:08:45 UTC

[GitHub] [spark] peter-toth commented on pull request #40932: [SPARK-43266][SQL] Move MergeScalarSubqueries to spark-sql

peter-toth commented on PR #40932:
URL: https://github.com/apache/spark/pull/40932#issuecomment-1688061241

   > Thank you. This change makes review easier.
   
   No, this PR is not required any more.
   Since I've updated https://github.com/apache/spark/pull/37630 and removed the physical plan comparison there is not need to move the `MergeScalarSubqueries` rule to spark-sql any more.
   I'm gone close this PR and please check the latest version of https://github.com/apache/spark/pull/37630. As there is no rule move github is able shows the actual diff better there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org