[GitHub] [calcite] rubenada commented on a change in pull request #2266: [CALCITE-4402] SqlCall#equalsDeep does not take into account the function quantifier

[GitBox <gi...@apache.org>]

rubenada commented on a change in pull request #2266:
URL: https://github.com/apache/calcite/pull/2266#discussion_r525907595



##########
File path: core/src/main/java/org/apache/calcite/sql/SqlCall.java
##########
@@ -146,6 +146,9 @@ public int operandCount() {
       return litmus.fail("{} != {}", this, node);
     }
     SqlCall that = (SqlCall) node;
+    if (!equalDeep(this.getFunctionQuantifier(), that.getFunctionQuantifier(), litmus)) {
+      return litmus.fail("{} != {} (functionQualifier differs)", this, node);

Review comment:
       minor: message says "functionQualifier", and I guess it should be "function quantifier".
   Also, personally I would prefer to add this new check after the operator's name check (i.e. reach the verification of function quantifier only in those cases where operator names' match).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org