Re: [PR] [SPARK-47081][CONNECT] Support Query Execution Progress [spark]

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #45150:
URL: https://github.com/apache/spark/pull/45150#discussion_r1494100683


##########
python/pyspark/shell.py:
##########
@@ -45,11 +45,29 @@
         if parent_dir in sys.path:
             sys.path.remove(parent_dir)
 
-
 if is_remote():
     try:
         # Creates pyspark.sql.connect.SparkSession.
         spark = SparkSession.builder.getOrCreate()

Review Comment:
   Could we get this from `spark.conf`? I think we should avoid relying on environment variable in general. Should probably also disable `spark.ui.showConsoleProgress` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org