You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/05/08 12:27:02 UTC
Review Request 59047: Added internal wrapper messages for local
resource provider Event/Call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59047/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Jan Schlicht.
Bugs: MESOS-7469
https://issues.apache.org/jira/browse/MESOS-7469
Repository: mesos
Description
-------
For local resource providers, the agent will serve as a proxy between
local resource provider and the master. It'll forward resource
provider Events and Calls.
Diffs
-----
src/messages/messages.proto eae9ce5a055a2cafef968c714abe4cea7dde627a
Diff: https://reviews.apache.org/r/59047/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 59047: Added internal wrapper messages for local
resource provider Event/Call.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59047/#review174162
-----------------------------------------------------------
Fix it, then Ship it!
src/messages/messages.proto
Lines 605-607 (patched)
<https://reviews.apache.org/r/59047/#comment247280>
How about:
> A wrapper message that is sent for a local resource provider Call by the agent to the master. The agent serves as a proxy between the local resource provider and the master.
src/messages/messages.proto
Lines 621-623 (patched)
<https://reviews.apache.org/r/59047/#comment247281>
See above.
- Benjamin Bannier
On May 8, 2017, 2:27 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59047/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 2:27 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Bugs: MESOS-7469
> https://issues.apache.org/jira/browse/MESOS-7469
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For local resource providers, the agent will serve as a proxy between
> local resource provider and the master. It'll forward resource
> provider Events and Calls.
>
>
> Diffs
> -----
>
> src/messages/messages.proto eae9ce5a055a2cafef968c714abe4cea7dde627a
>
>
> Diff: https://reviews.apache.org/r/59047/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>