[GitHub] [james-project] jeantil commented on pull request #985: JAMES-3761 Adds configurable bucketname to MimeMessageStore

[GitBox <gi...@apache.org>]

jeantil commented on PR #985:
URL: https://github.com/apache/james-project/pull/985#issuecomment-1118238008

   > No objections. As it stands it seems to benefit custom code only?
   
   It is used in the BlobStore backed MailRepository of #987 but we felt that the change made sense on its own as there can be multiple MimeMessageStores in a single assembly even before the BlobStore backed Mailrepository. 
   For example pulsar-cassandra-smtp-relay uses both CassandraMailRepository and the pulsar mailqueue both of which use a MimeMessageStore. As it stands neither adds custom qualifiers while wiring the message store. Unless I am mistaken this means that they will both store their respective blobs in the same bucket. While there are not direct consequences this is doesn't seem to be a very desirable situation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org