[GitHub] [kafka] cadonna commented on a change in pull request #10939: Avoid increasing app ID when test is executed multiple times

[GitBox <gi...@apache.org>]

cadonna commented on a change in pull request #10939:
URL: https://github.com/apache/kafka/pull/10939#discussion_r660542891



##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/TaskMetadataIntegrationTest.java
##########
@@ -77,15 +77,16 @@ public static void closeCluster() {
     private String inputTopic;
     private static StreamsBuilder builder;
     private static Properties properties;
-    private static String appId = "TaskMetadataTest_";
+    private static String appIdPrefix = "TaskMetadataTest_";
+    private static String appId;
     private AtomicBoolean process;
     private AtomicBoolean commit;
 
     @SuppressWarnings("deprecation") // Old PAPI. Needs to be migrated.
     @Before
     public void setup() {
         final String testId = safeUniqueTestName(getClass(), testName);
-        appId = appId + testId;

Review comment:
       This increases the app ID recursively at each consecutive execution of a test method of this test class.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org