You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/08/10 20:12:21 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request #2306: [NETBEANS-3409] Missing popup menu for sql editor tabs
matthiasblaesing opened a new pull request #2306:
URL: https://github.com/apache/netbeans/pull/2306
The Filesystems API compatibility module provides implementations for
Filesystem#getActions for several filesystems. Most filesystem
implementations are covered by the implementation in
AbstractFileSystemCompat, but this does not cover implementations
directly inheriting from Filesystem.
One such filesystem is BinaryFS.
In the SQL Editor the command window function (temp files for SQL
execution) is backed by a file in the SystemFileSystem, which delegates
in the end to BinaryFS:
SystemFileSystem->
ModuleLayeredFileSystem ->
BinaryFS
As BinaryFS does not implement getActions and no patch is provided for
this class, an AbstractMethodError is raised.
Instead of bailing out with an Error, the compatibility implementation
now returns an empty array to satisfy the Filesystem#getActions contract.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2306: [NETBEANS-3409] Missing popup menu for sql editor tabs
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2306:
URL: https://github.com/apache/netbeans/pull/2306#issuecomment-673104433
@neilcsmith-net this should be considered for inclusion into 12.1 as it is a regression introduced in the 11 series.
@sdedic thank you for the history analysis, yes the pretty much explains the issue and it also explain why I would have sworn, that the menu worked in past versions.
@JaroslavTulach @sdedic thanks for the quick review both of you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2306: [NETBEANS-3409] Missing popup menu for sql editor tabs
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2306:
URL: https://github.com/apache/netbeans/pull/2306#issuecomment-671566572
@JaroslavTulach I would appretiate a look at this. The title might sound as if this is a problem somewhere in the db support, but it can be traced back into the filesystem API (the compatibility module) and from my POV is the result of an incomplete patch implementation for the the extracted `Filesystem#getActions` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2306: [NETBEANS-3409] Missing popup menu for sql editor tabs
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2306:
URL: https://github.com/apache/netbeans/pull/2306#issuecomment-672878728
Very nice catch! Indeed, the Compat class was (conceptually) broken from the initial refactor. The issue was hidden until 9f47905f7 which removed the (now obsolete) `getActions()` implementation from the `BinaryFS` ... and even after until some old-API client was REALLY loaded at runtime.
So it seems that as a rule of thumb, the compat class should have ***no*** abstract methods in it. The `@PatchFor` processor could enforce that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #2306: [NETBEANS-3409] Missing popup menu for sql editor tabs
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged pull request #2306:
URL: https://github.com/apache/netbeans/pull/2306
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists