You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/15 17:38:41 UTC
[GitHub] [camel] jeremyross opened a new pull request #4611: CAMEL-14480: camel-salesforce: Conflicting relationship names.
jeremyross opened a new pull request #4611:
URL: https://github.com/apache/camel/pull/4611
In salesforce, if a relationship field has the same field name as the
child relationship name, the generated DTOs end up with invalid Java
code. This commit allows the user to specify a child relationship name
suffix in order to disambiguate the field name and child relationship
name.
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jeremyross commented on pull request #4611: CAMEL-14480: camel-salesforce: Conflicting relationship names.
Posted by GitBox <gi...@apache.org>.
jeremyross commented on pull request #4611:
URL: https://github.com/apache/camel/pull/4611#issuecomment-727611809
@oscerd pushed a new commit. For the Mojo `@Parameter` fields, the value for `default` is supposed to be empty string, but in this case if you don't specify a value for `childRelationshipNameSuffix`, it ends up being null instead of empty string, which was causing a problem. I added a null check, but it doesn't seem elegant and I'm guessing there's a better way to deal with this. LMK if you have thoughts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #4611: CAMEL-14480: camel-salesforce: Conflicting relationship names.
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #4611:
URL: https://github.com/apache/camel/pull/4611
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org