You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by "Boris Shkolnik (JIRA)" <ji...@apache.org> on 2018/10/03 22:01:00 UTC

[jira] [Commented] (SAMZA-1906) remove ExponentialSleepStrategy from KafkaSystemAdmin code.

    [ https://issues.apache.org/jira/browse/SAMZA-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637553#comment-16637553 ] 

Boris Shkolnik commented on SAMZA-1906:
---------------------------------------

There is another reason for the retries. We use AdminClient to create a new stream (e.g. intermediate stream). This call is asynchronous. So there is a race condition between creation and validation/querying  of the stream. Currently it is covered by the retries.

Instead, [~spvenkat] suggested adding a wait into the creation call itself, to make creation of the stream synchronous.

> remove ExponentialSleepStrategy from KafkaSystemAdmin code.
> -----------------------------------------------------------
>
>                 Key: SAMZA-1906
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1906
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>            Priority: Major
>
> The retry is not needed anymore because the new kafka client should take care of it.
> refactor the following methods in KafkaSystemAdmin:
> getSystemStreamPartitionCounts
> getSystemStreamMetadata
> getNewestOffset
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)