You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Philippe Mouawad <p....@ubik-ingenierie.com> on 2017/05/06 13:41:19 UTC
Use of https://github.com/HdrHistogram/HdrHistogram
Hello,
A user recently reported a bug on StatCalculator class:
- https://bz.apache.org/bugzilla/show_bug.cgi?id=61071
It appears issue is not restrained to Median but concerns percentile
computing.
Besides, this class has many drawbacks:
- It is not tested as much as it should be
- It relies on an algorithm that consumes memory
We use another class in Web/Dashboard report and BackendListener client
implementations that relies on commons-math
org.apache.commons.math3.stat.descriptive.DescriptiveStatistics.
My proposal is the following:
- First step : Introduce in StatCalculator, HdrHistogram
- Second step : Replace DescriptiveStatistics by HdrHistogram
Benefits:
- Uniform computing accross JMeter
- Better performances
Are you ok with this approach ?
Thanks
--
Regards.
Philippe Mouawad.
Ubik-Ingénierie
Re: Use of https://github.com/HdrHistogram/HdrHistogram
Posted by UBIK LOAD PACK Support <su...@ubikloadpack.com>.
Hello Isuru,
We are currently working on a future PR implementing this.
But feel free to help
Regards
On Thu, Jun 20, 2019 at 11:09 AM Isuru Perera <ch...@gmail.com> wrote:
> Hello,
>
> Any update on using HdrHistogram in JMeter?
>
> On Fri, Mar 30, 2018 at 5:12 PM Felix Schumacher <
> felix.schumacher@internetallee.de> wrote:
>
> > Am Freitag, den 30.03.2018, 12:38 +0200 schrieb Philippe Mouawad:
> > > ok for me.
> > > Make your dream become reality :)
> >
> > I have started on inserting the HdrHistogram into StatCalculator, but
> > that is not really possible, as StatCalculator is written as a generic
> > and HdrHistogram (as I have understood it) best with long values.
> >
> > Currently we have two non-generic implementations of StatCalculator.
> > One with Long and one with Integer. The Integer one seems to be used by
> > a test, only.
> >
> > Is the Integer version used somewhere else, that I have overlooked?
> >
> > At the moment I am trying to insert HdrHistogram into
> > StatCalculatorLong and delegate all calls to it. But I believe it would
> > be better to insert HdrHistogram into StatVisualizer and
> > SamplingStatVisualizer, since StatCalculator is public interface and I
> > don't see a way to keep it backward compatible with my current
> > approach.
> >
> > What do you think?
> >
> > Felix
> >
> > >
> > > On Friday, March 30, 2018, Felix Schumacher <
> > > felix.schumacher@internetallee.de> wrote:
> > >
> > > >
> > > > Sorry for the late answer.
> > > >
> > > > As https://bz.apache.org/bugzilla/show_bug.cgi?id=61725 is yet
> > > > another
> > > > report for the same "bug" and HdrHistogram seems to be a good
> > > > compromise on memory, speed and accuracy, I think we should go that
> > > > way.
> > > >
> > > > HdrHistogram is available under BSD clause 2, so it should be safe
> > > > to
> > > > include.
> > > >
> > > > As a side effect I am dreaming of a mini-histogram in the
> > > > visualizer
> > > > for every request line :)
> > > >
> > > > Felix
> > > >
> > > > Am Dienstag, den 21.11.2017, 14:33 +0530 schrieb Isuru Perera:
> > > > >
> > > > > +1 for using HdrHistogram. We found out that the percentiles
> > > > > values
> > > > > shown
> > > > > in "Aggregate Report" and the web dashboard are different for the
> > > > > same JTL
> > > > > file. It will be good if we can use the same logic to calculate
> > > > > percentile
> > > > > values in JMeter listeners and the web dashboard.
> > > > >
> > > > > On Sat, May 20, 2017 at 7:58 PM, Philippe Mouawad <
> > > > > philippe.mouawad@gmail.com> wrote:
> > > > >
> > > > > >
> > > > > >
> > > > > > Hello,
> > > > > > Any other thoughts ?
> > > > > >
> > > > > > Thanks
> > > > > >
> > > > > > On Saturday, May 6, 2017, Antonio Gomes Rodrigues <ra0077@gmail
> > > > > > .com
> > > > > > >
> > > > > > >
> > > > > > wrote:
> > > > > >
> > > > > > >
> > > > > > >
> > > > > > > +1
> > > > > > >
> > > > > > > 2017-05-06 15:57 GMT+02:00 Maxime Chassagneux <
> > > > > > > maxime.chassagneux@gmail.com <javascript:;>>
> > > > > > > :
> > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > +1 : lgtm
> > > > > > > >
> > > > > > > > 2017-05-06 15:41 GMT+02:00 Philippe Mouawad <
> > > > > > > p.mouawad@ubik-ingenierie.com <javascript:;>
> > > > > > > >
> > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > :
> > > > > > > > >
> > > > > > > > > Hello,
> > > > > > > > > A user recently reported a bug on StatCalculator class:
> > > > > > > > >
> > > > > > > > > - https://bz.apache.org/bugzilla/show_bug.cgi?id=61071
> > > > > > > > >
> > > > > > > > > It appears issue is not restrained to Median but
> > > > > > > > > concerns percentile
> > > > > > > > > computing.
> > > > > > > > >
> > > > > > > > > Besides, this class has many drawbacks:
> > > > > > > > >
> > > > > > > > > - It is not tested as much as it should be
> > > > > > > > > - It relies on an algorithm that consumes memory
> > > > > > > > >
> > > > > > > > > We use another class in Web/Dashboard report and
> > > > > > > > > BackendListener
> > > > > > client
> > > > > > >
> > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > implementations that relies on commons-math
> > > > > > > > > org.apache.commons.math3.stat.descriptive.DescriptiveStat
> > > > > > > > > isti
> > > > > > > > > cs.
> > > > > > > > >
> > > > > > > > > My proposal is the following:
> > > > > > > > >
> > > > > > > > > - First step : Introduce in StatCalculator,
> > > > > > > > > HdrHistogram
> > > > > > > > > - Second step : Replace DescriptiveStatistics by
> > > > > > > > > HdrHistogram
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > Benefits:
> > > > > > > > >
> > > > > > > > > - Uniform computing accross JMeter
> > > > > > > > > - Better performances
> > > > > > > > >
> > > > > > > > > Are you ok with this approach ?
> > > > > > > > >
> > > > > > > > > Thanks
> > > > > > > > > --
> > > > > > > > > Regards.
> > > > > > > > > Philippe Mouawad.
> > > > > > > > > Ubik-Ingénierie
> > > > > > > > >
> > > > > > --
> > > > > > Cordialement.
> > > > > > Philippe Mouawad.
> > > > > >
> > > > >
> > >
> >
>
>
> --
> Isuru Perera
> about.me/chrishantha
>
--
Regards
Ubik Load Pack <http://ubikloadpack.com> Team
Follow us on Twitter <http://twitter.com/ubikloadpack>
Cordialement
L'équipe Ubik Load Pack <http://ubikloadpack.com>
Suivez-nous sur Twitter <http://twitter.com/ubikloadpack>
Re: Use of https://github.com/HdrHistogram/HdrHistogram
Posted by Isuru Perera <ch...@gmail.com>.
Hello,
Any update on using HdrHistogram in JMeter?
On Fri, Mar 30, 2018 at 5:12 PM Felix Schumacher <
felix.schumacher@internetallee.de> wrote:
> Am Freitag, den 30.03.2018, 12:38 +0200 schrieb Philippe Mouawad:
> > ok for me.
> > Make your dream become reality :)
>
> I have started on inserting the HdrHistogram into StatCalculator, but
> that is not really possible, as StatCalculator is written as a generic
> and HdrHistogram (as I have understood it) best with long values.
>
> Currently we have two non-generic implementations of StatCalculator.
> One with Long and one with Integer. The Integer one seems to be used by
> a test, only.
>
> Is the Integer version used somewhere else, that I have overlooked?
>
> At the moment I am trying to insert HdrHistogram into
> StatCalculatorLong and delegate all calls to it. But I believe it would
> be better to insert HdrHistogram into StatVisualizer and
> SamplingStatVisualizer, since StatCalculator is public interface and I
> don't see a way to keep it backward compatible with my current
> approach.
>
> What do you think?
>
> Felix
>
> >
> > On Friday, March 30, 2018, Felix Schumacher <
> > felix.schumacher@internetallee.de> wrote:
> >
> > >
> > > Sorry for the late answer.
> > >
> > > As https://bz.apache.org/bugzilla/show_bug.cgi?id=61725 is yet
> > > another
> > > report for the same "bug" and HdrHistogram seems to be a good
> > > compromise on memory, speed and accuracy, I think we should go that
> > > way.
> > >
> > > HdrHistogram is available under BSD clause 2, so it should be safe
> > > to
> > > include.
> > >
> > > As a side effect I am dreaming of a mini-histogram in the
> > > visualizer
> > > for every request line :)
> > >
> > > Felix
> > >
> > > Am Dienstag, den 21.11.2017, 14:33 +0530 schrieb Isuru Perera:
> > > >
> > > > +1 for using HdrHistogram. We found out that the percentiles
> > > > values
> > > > shown
> > > > in "Aggregate Report" and the web dashboard are different for the
> > > > same JTL
> > > > file. It will be good if we can use the same logic to calculate
> > > > percentile
> > > > values in JMeter listeners and the web dashboard.
> > > >
> > > > On Sat, May 20, 2017 at 7:58 PM, Philippe Mouawad <
> > > > philippe.mouawad@gmail.com> wrote:
> > > >
> > > > >
> > > > >
> > > > > Hello,
> > > > > Any other thoughts ?
> > > > >
> > > > > Thanks
> > > > >
> > > > > On Saturday, May 6, 2017, Antonio Gomes Rodrigues <ra0077@gmail
> > > > > .com
> > > > > >
> > > > > >
> > > > > wrote:
> > > > >
> > > > > >
> > > > > >
> > > > > > +1
> > > > > >
> > > > > > 2017-05-06 15:57 GMT+02:00 Maxime Chassagneux <
> > > > > > maxime.chassagneux@gmail.com <javascript:;>>
> > > > > > :
> > > > > >
> > > > > > >
> > > > > > >
> > > > > > > +1 : lgtm
> > > > > > >
> > > > > > > 2017-05-06 15:41 GMT+02:00 Philippe Mouawad <
> > > > > > p.mouawad@ubik-ingenierie.com <javascript:;>
> > > > > > >
> > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > :
> > > > > > > >
> > > > > > > > Hello,
> > > > > > > > A user recently reported a bug on StatCalculator class:
> > > > > > > >
> > > > > > > > - https://bz.apache.org/bugzilla/show_bug.cgi?id=61071
> > > > > > > >
> > > > > > > > It appears issue is not restrained to Median but
> > > > > > > > concerns percentile
> > > > > > > > computing.
> > > > > > > >
> > > > > > > > Besides, this class has many drawbacks:
> > > > > > > >
> > > > > > > > - It is not tested as much as it should be
> > > > > > > > - It relies on an algorithm that consumes memory
> > > > > > > >
> > > > > > > > We use another class in Web/Dashboard report and
> > > > > > > > BackendListener
> > > > > client
> > > > > >
> > > > > >
> > > > > > >
> > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > implementations that relies on commons-math
> > > > > > > > org.apache.commons.math3.stat.descriptive.DescriptiveStat
> > > > > > > > isti
> > > > > > > > cs.
> > > > > > > >
> > > > > > > > My proposal is the following:
> > > > > > > >
> > > > > > > > - First step : Introduce in StatCalculator,
> > > > > > > > HdrHistogram
> > > > > > > > - Second step : Replace DescriptiveStatistics by
> > > > > > > > HdrHistogram
> > > > > > > >
> > > > > > > >
> > > > > > > > Benefits:
> > > > > > > >
> > > > > > > > - Uniform computing accross JMeter
> > > > > > > > - Better performances
> > > > > > > >
> > > > > > > > Are you ok with this approach ?
> > > > > > > >
> > > > > > > > Thanks
> > > > > > > > --
> > > > > > > > Regards.
> > > > > > > > Philippe Mouawad.
> > > > > > > > Ubik-Ingénierie
> > > > > > > >
> > > > > --
> > > > > Cordialement.
> > > > > Philippe Mouawad.
> > > > >
> > > >
> >
>
--
Isuru Perera
about.me/chrishantha
Re: Use of https://github.com/HdrHistogram/HdrHistogram
Posted by Felix Schumacher <fe...@internetallee.de>.
Am Freitag, den 30.03.2018, 12:38 +0200 schrieb Philippe Mouawad:
> ok for me.
> Make your dream become reality :)
I have started on inserting the HdrHistogram into StatCalculator, but
that is not really possible, as StatCalculator is written as a generic
and HdrHistogram (as I have understood it) best with long values.
Currently we have two non-generic implementations of StatCalculator.
One with Long and one with Integer. The Integer one seems to be used by
a test, only.
Is the Integer version used somewhere else, that I have overlooked?
At the moment I am trying to insert HdrHistogram into
StatCalculatorLong and delegate all calls to it. But I believe it would
be better to insert HdrHistogram into StatVisualizer and
SamplingStatVisualizer, since StatCalculator is public interface and I
don't see a way to keep it backward compatible with my current
approach.
What do you think?
Felix
>
> On Friday, March 30, 2018, Felix Schumacher <
> felix.schumacher@internetallee.de> wrote:
>
> >
> > Sorry for the late answer.
> >
> > As https://bz.apache.org/bugzilla/show_bug.cgi?id=61725 is yet
> > another
> > report for the same "bug" and HdrHistogram seems to be a good
> > compromise on memory, speed and accuracy, I think we should go that
> > way.
> >
> > HdrHistogram is available under BSD clause 2, so it should be safe
> > to
> > include.
> >
> > As a side effect I am dreaming of a mini-histogram in the
> > visualizer
> > for every request line :)
> >
> > Felix
> >
> > Am Dienstag, den 21.11.2017, 14:33 +0530 schrieb Isuru Perera:
> > >
> > > +1 for using HdrHistogram. We found out that the percentiles
> > > values
> > > shown
> > > in "Aggregate Report" and the web dashboard are different for the
> > > same JTL
> > > file. It will be good if we can use the same logic to calculate
> > > percentile
> > > values in JMeter listeners and the web dashboard.
> > >
> > > On Sat, May 20, 2017 at 7:58 PM, Philippe Mouawad <
> > > philippe.mouawad@gmail.com> wrote:
> > >
> > > >
> > > >
> > > > Hello,
> > > > Any other thoughts ?
> > > >
> > > > Thanks
> > > >
> > > > On Saturday, May 6, 2017, Antonio Gomes Rodrigues <ra0077@gmail
> > > > .com
> > > > >
> > > > >
> > > > wrote:
> > > >
> > > > >
> > > > >
> > > > > +1
> > > > >
> > > > > 2017-05-06 15:57 GMT+02:00 Maxime Chassagneux <
> > > > > maxime.chassagneux@gmail.com <javascript:;>>
> > > > > :
> > > > >
> > > > > >
> > > > > >
> > > > > > +1 : lgtm
> > > > > >
> > > > > > 2017-05-06 15:41 GMT+02:00 Philippe Mouawad <
> > > > > p.mouawad@ubik-ingenierie.com <javascript:;>
> > > > > >
> > > > > >
> > > > > > >
> > > > > > >
> > > > > > > :
> > > > > > >
> > > > > > > Hello,
> > > > > > > A user recently reported a bug on StatCalculator class:
> > > > > > >
> > > > > > > - https://bz.apache.org/bugzilla/show_bug.cgi?id=61071
> > > > > > >
> > > > > > > It appears issue is not restrained to Median but
> > > > > > > concerns percentile
> > > > > > > computing.
> > > > > > >
> > > > > > > Besides, this class has many drawbacks:
> > > > > > >
> > > > > > > - It is not tested as much as it should be
> > > > > > > - It relies on an algorithm that consumes memory
> > > > > > >
> > > > > > > We use another class in Web/Dashboard report and
> > > > > > > BackendListener
> > > > client
> > > > >
> > > > >
> > > > > >
> > > > > >
> > > > > > >
> > > > > > >
> > > > > > > implementations that relies on commons-math
> > > > > > > org.apache.commons.math3.stat.descriptive.DescriptiveStat
> > > > > > > isti
> > > > > > > cs.
> > > > > > >
> > > > > > > My proposal is the following:
> > > > > > >
> > > > > > > - First step : Introduce in StatCalculator,
> > > > > > > HdrHistogram
> > > > > > > - Second step : Replace DescriptiveStatistics by
> > > > > > > HdrHistogram
> > > > > > >
> > > > > > >
> > > > > > > Benefits:
> > > > > > >
> > > > > > > - Uniform computing accross JMeter
> > > > > > > - Better performances
> > > > > > >
> > > > > > > Are you ok with this approach ?
> > > > > > >
> > > > > > > Thanks
> > > > > > > --
> > > > > > > Regards.
> > > > > > > Philippe Mouawad.
> > > > > > > Ubik-Ingénierie
> > > > > > >
> > > > --
> > > > Cordialement.
> > > > Philippe Mouawad.
> > > >
> > >
>
Re: Use of https://github.com/HdrHistogram/HdrHistogram
Posted by Philippe Mouawad <ph...@gmail.com>.
ok for me.
Make your dream become reality :)
On Friday, March 30, 2018, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:
> Sorry for the late answer.
>
> As https://bz.apache.org/bugzilla/show_bug.cgi?id=61725 is yet another
> report for the same "bug" and HdrHistogram seems to be a good
> compromise on memory, speed and accuracy, I think we should go that
> way.
>
> HdrHistogram is available under BSD clause 2, so it should be safe to
> include.
>
> As a side effect I am dreaming of a mini-histogram in the visualizer
> for every request line :)
>
> Felix
>
> Am Dienstag, den 21.11.2017, 14:33 +0530 schrieb Isuru Perera:
> > +1 for using HdrHistogram. We found out that the percentiles values
> > shown
> > in "Aggregate Report" and the web dashboard are different for the
> > same JTL
> > file. It will be good if we can use the same logic to calculate
> > percentile
> > values in JMeter listeners and the web dashboard.
> >
> > On Sat, May 20, 2017 at 7:58 PM, Philippe Mouawad <
> > philippe.mouawad@gmail.com> wrote:
> >
> > >
> > > Hello,
> > > Any other thoughts ?
> > >
> > > Thanks
> > >
> > > On Saturday, May 6, 2017, Antonio Gomes Rodrigues <ra0077@gmail.com
> > > >
> > > wrote:
> > >
> > > >
> > > > +1
> > > >
> > > > 2017-05-06 15:57 GMT+02:00 Maxime Chassagneux <
> > > > maxime.chassagneux@gmail.com <javascript:;>>
> > > > :
> > > >
> > > > >
> > > > > +1 : lgtm
> > > > >
> > > > > 2017-05-06 15:41 GMT+02:00 Philippe Mouawad <
> > > > p.mouawad@ubik-ingenierie.com <javascript:;>
> > > > >
> > > > > >
> > > > > > :
> > > > > >
> > > > > > Hello,
> > > > > > A user recently reported a bug on StatCalculator class:
> > > > > >
> > > > > > - https://bz.apache.org/bugzilla/show_bug.cgi?id=61071
> > > > > >
> > > > > > It appears issue is not restrained to Median but
> > > > > > concerns percentile
> > > > > > computing.
> > > > > >
> > > > > > Besides, this class has many drawbacks:
> > > > > >
> > > > > > - It is not tested as much as it should be
> > > > > > - It relies on an algorithm that consumes memory
> > > > > >
> > > > > > We use another class in Web/Dashboard report and
> > > > > > BackendListener
> > > client
> > > >
> > > > >
> > > > > >
> > > > > > implementations that relies on commons-math
> > > > > > org.apache.commons.math3.stat.descriptive.DescriptiveStatisti
> > > > > > cs.
> > > > > >
> > > > > > My proposal is the following:
> > > > > >
> > > > > > - First step : Introduce in StatCalculator, HdrHistogram
> > > > > > - Second step : Replace DescriptiveStatistics by
> > > > > > HdrHistogram
> > > > > >
> > > > > >
> > > > > > Benefits:
> > > > > >
> > > > > > - Uniform computing accross JMeter
> > > > > > - Better performances
> > > > > >
> > > > > > Are you ok with this approach ?
> > > > > >
> > > > > > Thanks
> > > > > > --
> > > > > > Regards.
> > > > > > Philippe Mouawad.
> > > > > > Ubik-Ingénierie
> > > > > >
> > >
> > > --
> > > Cordialement.
> > > Philippe Mouawad.
> > >
> >
> >
>
--
Cordialement.
Philippe Mouawad.
Re: Use of https://github.com/HdrHistogram/HdrHistogram
Posted by Felix Schumacher <fe...@internetallee.de>.
Sorry for the late answer.
As https://bz.apache.org/bugzilla/show_bug.cgi?id=61725 is yet another
report for the same "bug" and HdrHistogram seems to be a good
compromise on memory, speed and accuracy, I think we should go that
way.
HdrHistogram is available under BSD clause 2, so it should be safe to
include.
As a side effect I am dreaming of a mini-histogram in the visualizer
for every request line :)
Felix
Am Dienstag, den 21.11.2017, 14:33 +0530 schrieb Isuru Perera:
> +1 for using HdrHistogram. We found out that the percentiles values
> shown
> in "Aggregate Report" and the web dashboard are different for the
> same JTL
> file. It will be good if we can use the same logic to calculate
> percentile
> values in JMeter listeners and the web dashboard.
>
> On Sat, May 20, 2017 at 7:58 PM, Philippe Mouawad <
> philippe.mouawad@gmail.com> wrote:
>
> >
> > Hello,
> > Any other thoughts ?
> >
> > Thanks
> >
> > On Saturday, May 6, 2017, Antonio Gomes Rodrigues <ra0077@gmail.com
> > >
> > wrote:
> >
> > >
> > > +1
> > >
> > > 2017-05-06 15:57 GMT+02:00 Maxime Chassagneux <
> > > maxime.chassagneux@gmail.com <javascript:;>>
> > > :
> > >
> > > >
> > > > +1 : lgtm
> > > >
> > > > 2017-05-06 15:41 GMT+02:00 Philippe Mouawad <
> > > p.mouawad@ubik-ingenierie.com <javascript:;>
> > > >
> > > > >
> > > > > :
> > > > >
> > > > > Hello,
> > > > > A user recently reported a bug on StatCalculator class:
> > > > >
> > > > > - https://bz.apache.org/bugzilla/show_bug.cgi?id=61071
> > > > >
> > > > > It appears issue is not restrained to Median but
> > > > > concerns percentile
> > > > > computing.
> > > > >
> > > > > Besides, this class has many drawbacks:
> > > > >
> > > > > - It is not tested as much as it should be
> > > > > - It relies on an algorithm that consumes memory
> > > > >
> > > > > We use another class in Web/Dashboard report and
> > > > > BackendListener
> > client
> > >
> > > >
> > > > >
> > > > > implementations that relies on commons-math
> > > > > org.apache.commons.math3.stat.descriptive.DescriptiveStatisti
> > > > > cs.
> > > > >
> > > > > My proposal is the following:
> > > > >
> > > > > - First step : Introduce in StatCalculator, HdrHistogram
> > > > > - Second step : Replace DescriptiveStatistics by
> > > > > HdrHistogram
> > > > >
> > > > >
> > > > > Benefits:
> > > > >
> > > > > - Uniform computing accross JMeter
> > > > > - Better performances
> > > > >
> > > > > Are you ok with this approach ?
> > > > >
> > > > > Thanks
> > > > > --
> > > > > Regards.
> > > > > Philippe Mouawad.
> > > > > Ubik-Ingénierie
> > > > >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
> >
>
>
Re: Use of https://github.com/HdrHistogram/HdrHistogram
Posted by Isuru Perera <is...@apache.org>.
+1 for using HdrHistogram. We found out that the percentiles values shown
in "Aggregate Report" and the web dashboard are different for the same JTL
file. It will be good if we can use the same logic to calculate percentile
values in JMeter listeners and the web dashboard.
On Sat, May 20, 2017 at 7:58 PM, Philippe Mouawad <
philippe.mouawad@gmail.com> wrote:
> Hello,
> Any other thoughts ?
>
> Thanks
>
> On Saturday, May 6, 2017, Antonio Gomes Rodrigues <ra...@gmail.com>
> wrote:
>
> > +1
> >
> > 2017-05-06 15:57 GMT+02:00 Maxime Chassagneux <
> > maxime.chassagneux@gmail.com <javascript:;>>
> > :
> >
> > > +1 : lgtm
> > >
> > > 2017-05-06 15:41 GMT+02:00 Philippe Mouawad <
> > p.mouawad@ubik-ingenierie.com <javascript:;>
> > > >:
> > >
> > > > Hello,
> > > > A user recently reported a bug on StatCalculator class:
> > > >
> > > > - https://bz.apache.org/bugzilla/show_bug.cgi?id=61071
> > > >
> > > > It appears issue is not restrained to Median but concerns percentile
> > > > computing.
> > > >
> > > > Besides, this class has many drawbacks:
> > > >
> > > > - It is not tested as much as it should be
> > > > - It relies on an algorithm that consumes memory
> > > >
> > > > We use another class in Web/Dashboard report and BackendListener
> client
> > > > implementations that relies on commons-math
> > > > org.apache.commons.math3.stat.descriptive.DescriptiveStatistics.
> > > >
> > > > My proposal is the following:
> > > >
> > > > - First step : Introduce in StatCalculator, HdrHistogram
> > > > - Second step : Replace DescriptiveStatistics by HdrHistogram
> > > >
> > > >
> > > > Benefits:
> > > >
> > > > - Uniform computing accross JMeter
> > > > - Better performances
> > > >
> > > > Are you ok with this approach ?
> > > >
> > > > Thanks
> > > > --
> > > > Regards.
> > > > Philippe Mouawad.
> > > > Ubik-Ingénierie
> > > >
> > >
> >
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
--
Isuru Perera
about.me/chrishantha
Re: Use of https://github.com/HdrHistogram/HdrHistogram
Posted by Philippe Mouawad <ph...@gmail.com>.
Hello,
Any other thoughts ?
Thanks
On Saturday, May 6, 2017, Antonio Gomes Rodrigues <ra...@gmail.com> wrote:
> +1
>
> 2017-05-06 15:57 GMT+02:00 Maxime Chassagneux <
> maxime.chassagneux@gmail.com <javascript:;>>
> :
>
> > +1 : lgtm
> >
> > 2017-05-06 15:41 GMT+02:00 Philippe Mouawad <
> p.mouawad@ubik-ingenierie.com <javascript:;>
> > >:
> >
> > > Hello,
> > > A user recently reported a bug on StatCalculator class:
> > >
> > > - https://bz.apache.org/bugzilla/show_bug.cgi?id=61071
> > >
> > > It appears issue is not restrained to Median but concerns percentile
> > > computing.
> > >
> > > Besides, this class has many drawbacks:
> > >
> > > - It is not tested as much as it should be
> > > - It relies on an algorithm that consumes memory
> > >
> > > We use another class in Web/Dashboard report and BackendListener client
> > > implementations that relies on commons-math
> > > org.apache.commons.math3.stat.descriptive.DescriptiveStatistics.
> > >
> > > My proposal is the following:
> > >
> > > - First step : Introduce in StatCalculator, HdrHistogram
> > > - Second step : Replace DescriptiveStatistics by HdrHistogram
> > >
> > >
> > > Benefits:
> > >
> > > - Uniform computing accross JMeter
> > > - Better performances
> > >
> > > Are you ok with this approach ?
> > >
> > > Thanks
> > > --
> > > Regards.
> > > Philippe Mouawad.
> > > Ubik-Ingénierie
> > >
> >
>
--
Cordialement.
Philippe Mouawad.
Re: Use of https://github.com/HdrHistogram/HdrHistogram
Posted by Antonio Gomes Rodrigues <ra...@gmail.com>.
+1
2017-05-06 15:57 GMT+02:00 Maxime Chassagneux <ma...@gmail.com>
:
> +1 : lgtm
>
> 2017-05-06 15:41 GMT+02:00 Philippe Mouawad <p.mouawad@ubik-ingenierie.com
> >:
>
> > Hello,
> > A user recently reported a bug on StatCalculator class:
> >
> > - https://bz.apache.org/bugzilla/show_bug.cgi?id=61071
> >
> > It appears issue is not restrained to Median but concerns percentile
> > computing.
> >
> > Besides, this class has many drawbacks:
> >
> > - It is not tested as much as it should be
> > - It relies on an algorithm that consumes memory
> >
> > We use another class in Web/Dashboard report and BackendListener client
> > implementations that relies on commons-math
> > org.apache.commons.math3.stat.descriptive.DescriptiveStatistics.
> >
> > My proposal is the following:
> >
> > - First step : Introduce in StatCalculator, HdrHistogram
> > - Second step : Replace DescriptiveStatistics by HdrHistogram
> >
> >
> > Benefits:
> >
> > - Uniform computing accross JMeter
> > - Better performances
> >
> > Are you ok with this approach ?
> >
> > Thanks
> > --
> > Regards.
> > Philippe Mouawad.
> > Ubik-Ingénierie
> >
>
Re: Use of https://github.com/HdrHistogram/HdrHistogram
Posted by Maxime Chassagneux <ma...@gmail.com>.
+1 : lgtm
2017-05-06 15:41 GMT+02:00 Philippe Mouawad <p....@ubik-ingenierie.com>:
> Hello,
> A user recently reported a bug on StatCalculator class:
>
> - https://bz.apache.org/bugzilla/show_bug.cgi?id=61071
>
> It appears issue is not restrained to Median but concerns percentile
> computing.
>
> Besides, this class has many drawbacks:
>
> - It is not tested as much as it should be
> - It relies on an algorithm that consumes memory
>
> We use another class in Web/Dashboard report and BackendListener client
> implementations that relies on commons-math
> org.apache.commons.math3.stat.descriptive.DescriptiveStatistics.
>
> My proposal is the following:
>
> - First step : Introduce in StatCalculator, HdrHistogram
> - Second step : Replace DescriptiveStatistics by HdrHistogram
>
>
> Benefits:
>
> - Uniform computing accross JMeter
> - Better performances
>
> Are you ok with this approach ?
>
> Thanks
> --
> Regards.
> Philippe Mouawad.
> Ubik-Ingénierie
>