You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/19 03:06:59 UTC

[GitHub] [kafka] dengziming opened a new pull request #10159: KAFKA-12338: Consolidate MetadataRecordSerde and MetadataParser serial/deserial code

dengziming opened a new pull request #10159:
URL: https://github.com/apache/kafka/pull/10159


   *More detailed description of your change*
   The logics are duplicated except that `MetadataRecordSerde` has an extra `DEFAULT_FRAME_VERSION`, if we want to change the serial/deserial format of metadata, we should modify 2 classes, this is unreasonable.
   
   *Summary of testing strategy (including rationale)*
   unit test
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming closed pull request #10159: KAFKA-12338: Consolidate MetadataRecordSerde and MetadataParser serial/deserial code

Posted by GitBox <gi...@apache.org>.
dengziming closed pull request #10159:
URL: https://github.com/apache/kafka/pull/10159


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming commented on pull request #10159: KAFKA-12338: Consolidate MetadataRecordSerde and MetadataParser serial/deserial code

Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #10159:
URL: https://github.com/apache/kafka/pull/10159#issuecomment-856376303


   Resolved by #10793


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming commented on pull request #10159: KAFKA-12338: Consolidate MetadataRecordSerde and MetadataParser serial/deserial code

Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #10159:
URL: https://github.com/apache/kafka/pull/10159#issuecomment-782802016


   @cmccabe , Hi, PTAL.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org