You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wangyum <gi...@git.apache.org> on 2017/05/07 03:57:31 UTC
[GitHub] spark pull request #17886: [SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can...
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/17886
[SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can not get "--hiveconf" and ''--hivevar" variables since 2.x
## What changes were proposed in this pull request?
Fix HiveThriftServer2 can not get "--hiveconf" and ''--hivevar" variables since 2.x
## How was this patch tested?
manual tests and unit tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wangyum/spark SPARK-13983-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17886.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17886
----
commit 4bf1443a65d23b4e470dc4f7c4e57ce34460f551
Author: Yuming Wang <wg...@gmail.com>
Date: 2017-05-07T03:35:33Z
Spark 2.x's HiveThriftServer2 support get "--hiveconf" and ''--hivevar" variables
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can not ge...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17886
**[Test build #76572 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76572/testReport)** for PR 17886 at commit [`6696502`](https://github.com/apache/spark/commit/6696502cbd7d9fe547eb650ef7de0bc83382ee05).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17886
LGTM
This bug fix is nice to have in 2.3. I will merge it now. Please submit a follow-up PR.
Thanks! Merged to master/2.3
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/420/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17886
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17886
cc @liufengdb
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not ...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17886#discussion_r165422360
--- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java ---
@@ -221,6 +227,70 @@ private void configureSession(Map<String, String> sessionConfMap) throws HiveSQL
}
}
+ // Copy from org.apache.hadoop.hive.ql.processors.SetProcessor, only change:
+ // setConf(varname, propName, varvalue, true) when varname.startsWith(HIVECONF_PREFIX)
+ public static int setVariable(String varname, String varvalue) throws Exception {
+ SessionState ss = SessionState.get();
+ if (varvalue.contains("\n")){
+ ss.err.println("Warning: Value had a \\n character in it.");
+ }
+ varname = varname.trim();
+ if (varname.startsWith(ENV_PREFIX)){
+ ss.err.println("env:* variables can not be set.");
+ return 1;
+ } else if (varname.startsWith(SYSTEM_PREFIX)){
+ String propName = varname.substring(SYSTEM_PREFIX.length());
+ System.getProperties().setProperty(propName,
+ new VariableSubstitution().substitute(ss.getConf(),varvalue));
+ } else if (varname.startsWith(HIVECONF_PREFIX)){
+ String propName = varname.substring(HIVECONF_PREFIX.length());
+ setConf(varname, propName, varvalue, true);
+ } else if (varname.startsWith(HIVEVAR_PREFIX)) {
+ String propName = varname.substring(HIVEVAR_PREFIX.length());
+ ss.getHiveVariables().put(propName,
+ new VariableSubstitution().substitute(ss.getConf(),varvalue));
--- End diff --
Nit: the indent.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not ...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17886#discussion_r165422740
--- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java ---
@@ -221,6 +227,70 @@ private void configureSession(Map<String, String> sessionConfMap) throws HiveSQL
}
}
+ // Copy from org.apache.hadoop.hive.ql.processors.SetProcessor, only change:
+ // setConf(varname, propName, varvalue, true) when varname.startsWith(HIVECONF_PREFIX)
+ public static int setVariable(String varname, String varvalue) throws Exception {
+ SessionState ss = SessionState.get();
+ if (varvalue.contains("\n")){
+ ss.err.println("Warning: Value had a \\n character in it.");
+ }
+ varname = varname.trim();
+ if (varname.startsWith(ENV_PREFIX)){
+ ss.err.println("env:* variables can not be set.");
+ return 1;
+ } else if (varname.startsWith(SYSTEM_PREFIX)){
+ String propName = varname.substring(SYSTEM_PREFIX.length());
+ System.getProperties().setProperty(propName,
+ new VariableSubstitution().substitute(ss.getConf(),varvalue));
+ } else if (varname.startsWith(HIVECONF_PREFIX)){
+ String propName = varname.substring(HIVECONF_PREFIX.length());
+ setConf(varname, propName, varvalue, true);
+ } else if (varname.startsWith(HIVEVAR_PREFIX)) {
+ String propName = varname.substring(HIVEVAR_PREFIX.length());
+ ss.getHiveVariables().put(propName,
+ new VariableSubstitution().substitute(ss.getConf(),varvalue));
+ } else if (varname.startsWith(METACONF_PREFIX)) {
+ String propName = varname.substring(METACONF_PREFIX.length());
+ Hive hive = Hive.get(ss.getConf());
+ hive.setMetaConf(propName, new VariableSubstitution().substitute(ss.getConf(), varvalue));
+ } else {
+ setConf(varname, varname, varvalue, true);
+ }
+ return 0;
+ }
+
+ // returns non-null string for validation fail
+ private static void setConf(String varname, String key, String varvalue, boolean register)
--- End diff --
This function is exactly the same as what Hive 1.2.1 has
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not ...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17886#discussion_r165447010
--- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java ---
@@ -221,6 +227,70 @@ private void configureSession(Map<String, String> sessionConfMap) throws HiveSQL
}
}
+ // Copy from org.apache.hadoop.hive.ql.processors.SetProcessor, only change:
+ // setConf(varname, propName, varvalue, true) when varname.startsWith(HIVECONF_PREFIX)
+ public static int setVariable(String varname, String varvalue) throws Exception {
+ SessionState ss = SessionState.get();
+ if (varvalue.contains("\n")){
+ ss.err.println("Warning: Value had a \\n character in it.");
+ }
+ varname = varname.trim();
+ if (varname.startsWith(ENV_PREFIX)){
+ ss.err.println("env:* variables can not be set.");
+ return 1;
+ } else if (varname.startsWith(SYSTEM_PREFIX)){
+ String propName = varname.substring(SYSTEM_PREFIX.length());
+ System.getProperties().setProperty(propName,
+ new VariableSubstitution().substitute(ss.getConf(),varvalue));
+ } else if (varname.startsWith(HIVECONF_PREFIX)){
+ String propName = varname.substring(HIVECONF_PREFIX.length());
+ setConf(varname, propName, varvalue, true);
--- End diff --
I see. Thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17886
You only hit the issue from JDBC client, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not ...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17886#discussion_r165421914
--- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java ---
@@ -221,6 +227,70 @@ private void configureSession(Map<String, String> sessionConfMap) throws HiveSQL
}
}
+ // Copy from org.apache.hadoop.hive.ql.processors.SetProcessor, only change:
--- End diff --
This is from Hive 1.2 branch.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81115/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can not ge...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can not ge...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76537/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17886
**[Test build #86931 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86931/testReport)** for PR 17886 at commit [`dfb1ee5`](https://github.com/apache/spark/commit/dfb1ee5fbf7469895f5f91fe9f9d63dc202ca1b5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not ...
Posted by liufengdb <gi...@git.apache.org>.
Github user liufengdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/17886#discussion_r165441473
--- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java ---
@@ -221,6 +227,70 @@ private void configureSession(Map<String, String> sessionConfMap) throws HiveSQL
}
}
+ // Copy from org.apache.hadoop.hive.ql.processors.SetProcessor, only change:
+ // setConf(varname, propName, varvalue, true) when varname.startsWith(HIVECONF_PREFIX)
+ public static int setVariable(String varname, String varvalue) throws Exception {
+ SessionState ss = SessionState.get();
+ if (varvalue.contains("\n")){
+ ss.err.println("Warning: Value had a \\n character in it.");
+ }
+ varname = varname.trim();
+ if (varname.startsWith(ENV_PREFIX)){
+ ss.err.println("env:* variables can not be set.");
+ return 1;
+ } else if (varname.startsWith(SYSTEM_PREFIX)){
+ String propName = varname.substring(SYSTEM_PREFIX.length());
+ System.getProperties().setProperty(propName,
+ new VariableSubstitution().substitute(ss.getConf(),varvalue));
+ } else if (varname.startsWith(HIVECONF_PREFIX)){
+ String propName = varname.substring(HIVECONF_PREFIX.length());
+ setConf(varname, propName, varvalue, true);
--- End diff --
The fix of hivevar is by this line: https://github.com/apache/spark/pull/17886/files#diff-9d2cd65aaeae992250b5f40d8c289287R56.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/17886
CC @srowen, @liancheng Can you please review this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17886
**[Test build #78200 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78200/testReport)** for PR 17886 at commit [`6696502`](https://github.com/apache/spark/commit/6696502cbd7d9fe547eb650ef7de0bc83382ee05).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can not ge...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17886
**[Test build #76539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76539/testReport)** for PR 17886 at commit [`995d9a8`](https://github.com/apache/spark/commit/995d9a864e68febbca7b9541815c5e42735ebd03).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17886
**[Test build #81115 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81115/testReport)** for PR 17886 at commit [`e752d42`](https://github.com/apache/spark/commit/e752d423254e75b460e50c92afad4b63a7f60aea).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17886
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not ...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17886#discussion_r165421988
--- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java ---
@@ -221,6 +227,70 @@ private void configureSession(Map<String, String> sessionConfMap) throws HiveSQL
}
}
+ // Copy from org.apache.hadoop.hive.ql.processors.SetProcessor, only change:
+ // setConf(varname, propName, varvalue, true) when varname.startsWith(HIVECONF_PREFIX)
+ public static int setVariable(String varname, String varvalue) throws Exception {
+ SessionState ss = SessionState.get();
+ if (varvalue.contains("\n")){
+ ss.err.println("Warning: Value had a \\n character in it.");
+ }
+ varname = varname.trim();
+ if (varname.startsWith(ENV_PREFIX)){
+ ss.err.println("env:* variables can not be set.");
+ return 1;
+ } else if (varname.startsWith(SYSTEM_PREFIX)){
+ String propName = varname.substring(SYSTEM_PREFIX.length());
+ System.getProperties().setProperty(propName,
+ new VariableSubstitution().substitute(ss.getConf(),varvalue));
--- End diff --
Nit: the indent.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17886
**[Test build #86931 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86931/testReport)** for PR 17886 at commit [`dfb1ee5`](https://github.com/apache/spark/commit/dfb1ee5fbf7469895f5f91fe9f9d63dc202ca1b5).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/480/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/17886
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can not ge...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/17886
@gatorsmile `JDBC client` and `beeline` all works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not ...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17886#discussion_r165425929
--- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java ---
@@ -221,6 +227,70 @@ private void configureSession(Map<String, String> sessionConfMap) throws HiveSQL
}
}
+ // Copy from org.apache.hadoop.hive.ql.processors.SetProcessor, only change:
+ // setConf(varname, propName, varvalue, true) when varname.startsWith(HIVECONF_PREFIX)
+ public static int setVariable(String varname, String varvalue) throws Exception {
+ SessionState ss = SessionState.get();
+ if (varvalue.contains("\n")){
+ ss.err.println("Warning: Value had a \\n character in it.");
+ }
+ varname = varname.trim();
+ if (varname.startsWith(ENV_PREFIX)){
+ ss.err.println("env:* variables can not be set.");
+ return 1;
+ } else if (varname.startsWith(SYSTEM_PREFIX)){
+ String propName = varname.substring(SYSTEM_PREFIX.length());
+ System.getProperties().setProperty(propName,
+ new VariableSubstitution().substitute(ss.getConf(),varvalue));
+ } else if (varname.startsWith(HIVECONF_PREFIX)){
+ String propName = varname.substring(HIVECONF_PREFIX.length());
+ setConf(varname, propName, varvalue, true);
--- End diff --
If we just made a change for `HIVECONF_PREFIX`, how does this PR also claim it fixes the issue of `HIVEVAR_PREFIX`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by liufengdb <gi...@git.apache.org>.
Github user liufengdb commented on the issue:
https://github.com/apache/spark/pull/17886
@gatorsmile this is a great patch. The test can be improved, but I think it is safe to merge as it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can not ge...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17886
**[Test build #76537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76537/testReport)** for PR 17886 at commit [`4bf1443`](https://github.com/apache/spark/commit/4bf1443a65d23b4e470dc4f7c4e57ce34460f551).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can not ge...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76572/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78200/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17886
**[Test build #81115 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81115/testReport)** for PR 17886 at commit [`e752d42`](https://github.com/apache/spark/commit/e752d423254e75b460e50c92afad4b63a7f60aea).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17886
**[Test build #78200 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78200/testReport)** for PR 17886 at commit [`6696502`](https://github.com/apache/spark/commit/6696502cbd7d9fe547eb650ef7de0bc83382ee05).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17886
Could you explain the fix in the PR description? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17886
**[Test build #83318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83318/testReport)** for PR 17886 at commit [`dfb1ee5`](https://github.com/apache/spark/commit/dfb1ee5fbf7469895f5f91fe9f9d63dc202ca1b5).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can not ge...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17886
**[Test build #76572 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76572/testReport)** for PR 17886 at commit [`6696502`](https://github.com/apache/spark/commit/6696502cbd7d9fe547eb650ef7de0bc83382ee05).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83318/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86931/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17886: [SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can...
Posted by chutium <gi...@git.apache.org>.
Github user chutium commented on a diff in the pull request:
https://github.com/apache/spark/pull/17886#discussion_r115196548
--- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java ---
@@ -71,6 +71,10 @@
import org.apache.hive.service.cli.thrift.TProtocolVersion;
import org.apache.hive.service.server.ThreadWithGarbageCleanup;
+import static org.apache.hadoop.hive.conf.SystemVariables.*;
+import static org.apache.hadoop.hive.conf.SystemVariables.HIVEVAR_PREFIX;
+import static org.apache.hadoop.hive.conf.SystemVariables.METACONF_PREFIX;
+
--- End diff --
above two lines are not needed, since there is a import .*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not ...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17886#discussion_r165422252
--- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java ---
@@ -221,6 +227,70 @@ private void configureSession(Map<String, String> sessionConfMap) throws HiveSQL
}
}
+ // Copy from org.apache.hadoop.hive.ql.processors.SetProcessor, only change:
+ // setConf(varname, propName, varvalue, true) when varname.startsWith(HIVECONF_PREFIX)
+ public static int setVariable(String varname, String varvalue) throws Exception {
+ SessionState ss = SessionState.get();
+ if (varvalue.contains("\n")){
+ ss.err.println("Warning: Value had a \\n character in it.");
+ }
+ varname = varname.trim();
+ if (varname.startsWith(ENV_PREFIX)){
+ ss.err.println("env:* variables can not be set.");
+ return 1;
+ } else if (varname.startsWith(SYSTEM_PREFIX)){
+ String propName = varname.substring(SYSTEM_PREFIX.length());
+ System.getProperties().setProperty(propName,
+ new VariableSubstitution().substitute(ss.getConf(),varvalue));
+ } else if (varname.startsWith(HIVECONF_PREFIX)){
+ String propName = varname.substring(HIVECONF_PREFIX.length());
+ setConf(varname, propName, varvalue, true);
--- End diff --
This line is the change this PR made. from `false` to `true`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/17886
@gatorsmile master branch still has this issue.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can not ge...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17886
**[Test build #76537 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76537/testReport)** for PR 17886 at commit [`4bf1443`](https://github.com/apache/spark/commit/4bf1443a65d23b4e470dc4f7c4e57ce34460f551).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can not ge...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17886
**[Test build #76539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76539/testReport)** for PR 17886 at commit [`995d9a8`](https://github.com/apache/spark/commit/995d9a864e68febbca7b9541815c5e42735ebd03).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can not ge...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can not ge...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76539/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17886: [SPARK-13983][SQL] Fix HiveThriftServer2 can not get "--...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17886
**[Test build #83318 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83318/testReport)** for PR 17886 at commit [`dfb1ee5`](https://github.com/apache/spark/commit/dfb1ee5fbf7469895f5f91fe9f9d63dc202ca1b5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org