You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "numinnex (via GitHub)" <gi...@apache.org> on 2025/09/05 09:17:51 UTC
[PR] feat(io_uring): replace shards_table with dashmap [iggy]
numinnex opened a new pull request, #2156:
URL: https://github.com/apache/iggy/pull/2156
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(io_uring): replace shards_table with dashmap [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on code in PR #2156:
URL: https://github.com/apache/iggy/pull/2156#discussion_r2324576270
##########
core/server/src/shard/builder.rs:
##########
@@ -42,6 +46,7 @@ use super::{IggyShard, transmission::connector::ShardConnector, transmission::fr
pub struct IggyShardBuilder {
Review Comment:
consider using crate `bon` instead of manual implementation of builder. see `IggyMessage`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(io_uring): replace shards_table with dashmap [iggy]
Posted by "numinnex (via GitHub)" <gi...@apache.org>.
numinnex merged PR #2156:
URL: https://github.com/apache/iggy/pull/2156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org