You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/11/03 20:32:35 UTC

[jira] [Commented] (COUCHDB-2432) Move local storage getter + setter in utils.js

    [ https://issues.apache.org/jira/browse/COUCHDB-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14194959#comment-14194959 ] 

ASF GitHub Bot commented on COUCHDB-2432:
-----------------------------------------

GitHub user benkeen opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/127

    Added getter/setter utils.js methods for local storage

    This is primarily proactive; there are only a couple of places in the code
    that use local storage, but I wanted to nip it in the bud now and use
    helpers instead.
    
    Closes COUCHDB-2432

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benkeen/couchdb-fauxton 2432-local-storage-methods-moved-to-utils

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #127
    
----
commit 2875d534eb88d8fcced839e4e2d02624980efc8c
Author: Benjamin Keen <be...@gmail.com>
Date:   2014-11-03T19:28:32Z

    Added getter/setter utils.js methods for local storage
    
    This is primarily proactive; there are only a couple of places in the code
    that use local storage, but I wanted to nip it in the bud now and use
    helpers instead.
    
    Closes COUCHDB-2432

----


> Move local storage getter + setter in utils.js
> ----------------------------------------------
>
>                 Key: COUCHDB-2432
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2432
>             Project: CouchDB
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Fauxton
>            Reporter: Ben Keen
>            Assignee: Ben Keen
>
> We're using local storage in a couple of places by explicitly calling localStorage.setItem, getItem. There's a benefit to moving wrapping these into utility methods, e.g. 
> - can ward against problems like local storage being full or not available in browser
> - allows us to get/set complex objects



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)