You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Øystein Grøvlen (JIRA)" <ji...@apache.org> on 2007/05/19 17:01:16 UTC
[jira] Created: (DERBY-2674) Stop running jdbc40 tests in the old
test framework
Stop running jdbc40 tests in the old test framework
---------------------------------------------------
Key: DERBY-2674
URL: https://issues.apache.org/jira/browse/DERBY-2674
Project: Derby
Issue Type: Test
Components: Test
Reporter: Øystein Grøvlen
Priority: Minor
Fix For: 10.3.0.0
Tests in the old jdbc40 test suite are run in the derbyall test suite even if all the tests have been converted to Junit and is run as part of the Junit All test suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (DERBY-2674) Stop running jdbc40 tests in the old test framework
Posted by Myrna van Lunteren <m....@gmail.com>.
On 6/21/07, Ramin Moazeni (JIRA) <ji...@apache.org> wrote:
> Hi Myrna
>
> DERBY-2854 and DERBY-2855 is created to convert jdbc4/TestResultSetMethods.java and jdbc4/TestConnectionMethods.java to JUnit.
>
> Ramin
I saw, thx! I linked them to this one...
Myrna
[jira] Commented: (DERBY-2674) Stop running jdbc40 tests in the old
test framework
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497160 ]
Øystein Grøvlen commented on DERBY-2674:
----------------------------------------
A closer look shows that while TestPreparedStatementMethods seem to contain the same tests as PreparedStatementTest, this is not so for TestResultSetMethods and TestConnectionMethods and the corresponding ResultSetTest and ConnectionTest. Hence, there are probably a few test cases that needs to be converted to Junit before the old jdbc40 suite can be removed.
> Stop running jdbc40 tests in the old test framework
> ---------------------------------------------------
>
> Key: DERBY-2674
> URL: https://issues.apache.org/jira/browse/DERBY-2674
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Øystein Grøvlen
> Priority: Minor
> Fix For: 10.3.0.0
>
>
> Tests in the old jdbc40 test suite are run in the derbyall test suite even if all the tests have been converted to Junit and is run as part of the Junit All test suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-2674) Stop running jdbc40 tests in the old
test framework
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren resolved DERBY-2674.
---------------------------------------
Resolution: Fixed
I removed the last forgotten file - jdbc40.properties - with revision 612531, most references had been removed with the checkin for DERBY-2855.
Not sure whom to assign this to as a number of people helped on different tests.
> Stop running jdbc40 tests in the old test framework
> ---------------------------------------------------
>
> Key: DERBY-2674
> URL: https://issues.apache.org/jira/browse/DERBY-2674
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Øystein Grøvlen
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: rmTestPreparedStatementMethods.diff, rmTestPreparedStatementMethods.stat, rmTestPreparedStatementMethods_v2.diff
>
>
> Tests in the old jdbc40 test suite are run in the derbyall test suite even if all the tests have been converted to Junit and is run as part of the Junit All test suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2674) Stop running jdbc40 tests in the old
test framework
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren updated DERBY-2674:
--------------------------------------
Fix Version/s: (was: 10.3.0.0)
10.4.0.0
> Stop running jdbc40 tests in the old test framework
> ---------------------------------------------------
>
> Key: DERBY-2674
> URL: https://issues.apache.org/jira/browse/DERBY-2674
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Øystein Grøvlen
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: rmTestPreparedStatementMethods.diff, rmTestPreparedStatementMethods.stat, rmTestPreparedStatementMethods_v2.diff
>
>
> Tests in the old jdbc40 test suite are run in the derbyall test suite even if all the tests have been converted to Junit and is run as part of the Junit All test suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2674) Stop running jdbc40 tests in the old
test framework
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502674 ]
Myrna van Lunteren commented on DERBY-2674:
-------------------------------------------
Dan made a step to remove the last 'junit' test - jdbc4/AutoloadBooing.junit.
Anyone feel up to converting jdbc4/TestResultSetMethods.java and jdbc4/TestConnectionMethods.java to junit in the next 7 days?
Then this issue can be closed for 10.3.
Otherwise, I'll move it off the 10.3 list, even though changes have gone in for 10.3 - this is not something that would affect end-users...
> Stop running jdbc40 tests in the old test framework
> ---------------------------------------------------
>
> Key: DERBY-2674
> URL: https://issues.apache.org/jira/browse/DERBY-2674
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Øystein Grøvlen
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: rmTestPreparedStatementMethods.diff, rmTestPreparedStatementMethods.stat, rmTestPreparedStatementMethods_v2.diff
>
>
> Tests in the old jdbc40 test suite are run in the derbyall test suite even if all the tests have been converted to Junit and is run as part of the Junit All test suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2674) Stop running jdbc40 tests in the old
test framework
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-2674:
--------------------------------------
Derby Info: (was: [Patch Available])
Thanks Øystein. Committed revision 540150.
> Stop running jdbc40 tests in the old test framework
> ---------------------------------------------------
>
> Key: DERBY-2674
> URL: https://issues.apache.org/jira/browse/DERBY-2674
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Øystein Grøvlen
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: rmTestPreparedStatementMethods.diff, rmTestPreparedStatementMethods.stat, rmTestPreparedStatementMethods_v2.diff
>
>
> Tests in the old jdbc40 test suite are run in the derbyall test suite even if all the tests have been converted to Junit and is run as part of the Junit All test suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2674) Stop running jdbc40 tests in the old
test framework
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Øystein Grøvlen updated DERBY-2674:
-----------------------------------
Derby Info: [Patch Available]
> Stop running jdbc40 tests in the old test framework
> ---------------------------------------------------
>
> Key: DERBY-2674
> URL: https://issues.apache.org/jira/browse/DERBY-2674
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Øystein Grøvlen
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: rmTestPreparedStatementMethods.diff, rmTestPreparedStatementMethods.stat
>
>
> Tests in the old jdbc40 test suite are run in the derbyall test suite even if all the tests have been converted to Junit and is run as part of the Junit All test suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-2674) Stop running jdbc40 tests in the old
test framework
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Øystein Grøvlen closed DERBY-2674.
----------------------------------
All JDBC 4 tests are now part of the Junit All suite.
> Stop running jdbc40 tests in the old test framework
> ---------------------------------------------------
>
> Key: DERBY-2674
> URL: https://issues.apache.org/jira/browse/DERBY-2674
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Øystein Grøvlen
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: rmTestPreparedStatementMethods.diff, rmTestPreparedStatementMethods.stat, rmTestPreparedStatementMethods_v2.diff
>
>
> Tests in the old jdbc40 test suite are run in the derbyall test suite even if all the tests have been converted to Junit and is run as part of the Junit All test suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2674) Stop running jdbc40 tests in the old
test framework
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Øystein Grøvlen updated DERBY-2674:
-----------------------------------
Attachment: rmTestPreparedStatementMethods_v2.diff
Knut Anders, thanks for the review and the good advice.
The attached patch, rmTestPreparedStatementMethods_v2.diff, should address your comments.
> Stop running jdbc40 tests in the old test framework
> ---------------------------------------------------
>
> Key: DERBY-2674
> URL: https://issues.apache.org/jira/browse/DERBY-2674
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Øystein Grøvlen
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: rmTestPreparedStatementMethods.diff, rmTestPreparedStatementMethods.stat, rmTestPreparedStatementMethods_v2.diff
>
>
> Tests in the old jdbc40 test suite are run in the derbyall test suite even if all the tests have been converted to Junit and is run as part of the Junit All test suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2674) Stop running jdbc40 tests in the old
test framework
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Øystein Grøvlen updated DERBY-2674:
-----------------------------------
Attachment: rmTestPreparedStatementMethods.stat
rmTestPreparedStatementMethods.diff
The attached patch removes the TestPreparedStatementMethods test and associates files that are not used by other tests.
An inspection of PreparedStatementTest showed that testing of isPoolable/setPoolable on a closed PreparedStatement was omitted when the test was ported to Junit. The patch adds test cases for this to PreparedStatementTest.
I have run derbyall and the PreparedStatementTest without errors.
> Stop running jdbc40 tests in the old test framework
> ---------------------------------------------------
>
> Key: DERBY-2674
> URL: https://issues.apache.org/jira/browse/DERBY-2674
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Øystein Grøvlen
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: rmTestPreparedStatementMethods.diff, rmTestPreparedStatementMethods.stat
>
>
> Tests in the old jdbc40 test suite are run in the derbyall test suite even if all the tests have been converted to Junit and is run as part of the Junit All test suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2674) Stop running jdbc40 tests in the old
test framework
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497268 ]
Knut Anders Hatlen commented on DERBY-2674:
-------------------------------------------
I think the patch looks good, Øystein. Some minor comments:
* testIsPoolableOnClosed has this piece of code:
+ psClosed.close();
+ if (psClosed.isPoolable())
+ fail("Should throw exception on closed statement");
Shouldn't this fail if psClosed.isPoolable() returns false as well?
* Couldn't the test*OnClosed methods have used ps instead of creating their own PreparedStatement? ps seems to be initialized in the setUp() method for each fixture.
* testSetPoolable and testIsPoolable have code like this (not originally written by you, only reindented)
+ if (ps.isPoolable())
+ fail("Expected a non-poolable statement");
Perhaps it would be better with assertTrue/assertFalse in these cases?
* Not introduced by you, but I noticed that tearDown() doesn't close ps and s, and it doesn't set any of the statements to null. Perhaps you could fix that as well while you're at it? :)
> Stop running jdbc40 tests in the old test framework
> ---------------------------------------------------
>
> Key: DERBY-2674
> URL: https://issues.apache.org/jira/browse/DERBY-2674
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Øystein Grøvlen
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: rmTestPreparedStatementMethods.diff, rmTestPreparedStatementMethods.stat
>
>
> Tests in the old jdbc40 test suite are run in the derbyall test suite even if all the tests have been converted to Junit and is run as part of the Junit All test suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2674) Stop running jdbc40 tests in the old
test framework
Posted by "Ramin Moazeni (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506976 ]
Ramin Moazeni commented on DERBY-2674:
--------------------------------------
Hi Myrna
DERBY-2854 and DERBY-2855 is created to convert jdbc4/TestResultSetMethods.java and jdbc4/TestConnectionMethods.java to JUnit.
Ramin
> Stop running jdbc40 tests in the old test framework
> ---------------------------------------------------
>
> Key: DERBY-2674
> URL: https://issues.apache.org/jira/browse/DERBY-2674
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Øystein Grøvlen
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: rmTestPreparedStatementMethods.diff, rmTestPreparedStatementMethods.stat, rmTestPreparedStatementMethods_v2.diff
>
>
> Tests in the old jdbc40 test suite are run in the derbyall test suite even if all the tests have been converted to Junit and is run as part of the Junit All test suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.