[GitHub] maziyarpanahi commented on a change in pull request #3189: [ZEPPELIN-3758]. Convert old note file note.json to new style

[GitBox <gi...@apache.org>]

maziyarpanahi commented on a change in pull request #3189: [ZEPPELIN-3758]. Convert old note file note.json to new style
URL: https://github.com/apache/zeppelin/pull/3189#discussion_r253314125
 
 

 ##########
 File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
 ##########
 @@ -732,6 +732,8 @@ public String getZeppelinSearchTempPath() {
     ZEPPELIN_NOTEBOOK_STORAGE("zeppelin.notebook.storage",
         "org.apache.zeppelin.notebook.repo.GitNotebookRepo"),
     ZEPPELIN_NOTEBOOK_ONE_WAY_SYNC("zeppelin.notebook.one.way.sync", false),
+    ZEPPELIN_NOTEBOOK_NEW_FORMAT_CONVERT("zeppelin.notebook.new_format.convert", false),
+    ZEPPELIN_NOTEBOOK_NEW_FORMAT_DELETE_OLD("zeppelin.notebook.new_format.delete_old", false),
 
 Review comment:
   If the user forgot to change it back, every restart would convert an old version of an old format (json) and overwrites it on a new version of a newer version note. I would go with the script, but it's not easy when you have 100 notes in HDFS :( 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services