You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)" <ma...@hp.com> on 2002/03/14 00:28:35 UTC

[PATCH] SSL Session Caching stuff

Hi,
Good Afternoon !!. Another attempt at the SSL session caching stuff.. As
regards the patch, 

1. enables shmht, shmcb in Apache 2.0 (complete in terms of compiling - but
may not be fully complete in terms of functionality)

2. Can somebody please review and tell me what may be wrong in the
apr_shm_*, apr_rmm_* logic that I've put in the
ssl_scache_shmht.c/ssl_scache_shmcb.c. I have a feeling that I'm missing
something important - I'm not doing the apr_shm_attach() / apr_rmm_attach.

3. I was able to bring up the server and get the session caching on linux
(redhat 7.2), but not on HP-UX :-(. The difference b/w Linux and HP-UX is
that Linux uses MMAP_ANON and HP-UX uses SHMGET. I think there's something
wrong in the apr_shm_create() logic - still looking into it.

4. There might be some non-portable issues - it'll be great if somebody
could pl. point it out to me.

Thanks,
-Madhu


Re: [PATCH] SSL Session Caching stuff

Posted by Doug MacEachern <do...@covalent.net>.
looks good to me madhu.  haven't tested, but it compiles, so i've 
committed the patch and remaining issues can be worked out later.
only have one question at the moment, what is this for?

+        void *data;
+        const char *userdata_key = "ssl_scache_init";
+
+        apr_pool_userdata_get(&data, userdata_key, s->process->pool);
+        if (!data) {
+            apr_pool_userdata_setn((const void *)1, userdata_key,
+                                   apr_pool_cleanup_null, s->process->pool);
+            return;
+        }