You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/11 10:38:37 UTC
[GitHub] [camel-website] CSElonewolf opened a new pull request #191: solved
search box interferes with menu and logo on smaller resolutions
CSElonewolf opened a new pull request #191: solved search box interferes with menu and logo on smaller resolutions
URL: https://github.com/apache/camel-website/pull/191
[CAMEL-14694](https://issues.apache.org/jira/projects/CAMEL/issues/CAMEL-14694?filter=allopenissues)
Before:-
<img width="190" alt="image 3" src="https://user-images.githubusercontent.com/51082429/76408057-5afbc780-63b2-11ea-834b-b0fc76c6b3bd.png">
After:-
<img width="190" alt="image2" src="https://user-images.githubusercontent.com/51082429/76408075-6222d580-63b2-11ea-96b5-aac523a86cdf.png">
Updated the margin-top ,padding and top of .navbar-search input and #search_results respectively
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #191: solved search box
interferes with menu and logo on smaller resolutions
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #191: solved search box interferes with menu and logo on smaller resolutions
URL: https://github.com/apache/camel-website/pull/191#issuecomment-597669730
@CSElonewolf I think you're looking for the header navigation, which is in [this partial](https://github.com/apache/camel-website/blob/master/layouts/partials/header.html) for Hugo generated content, and again replicated in this [template](https://github.com/apache/camel-website/blob/master/antora-ui-camel/src/partials/header-content.hbs) for the Antora content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #191: solved search
box interferes with menu and logo on smaller resolutions
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #191: solved search box interferes with menu and logo on smaller resolutions
URL: https://github.com/apache/camel-website/pull/191#issuecomment-597620686
Ok.Let's proceed.
Btw @zregvart I tried finding the .html file of the complete landing page but couldn't find.As I have an issue to report specifically talking(the div section with "split" class the one with the 20th anniversary logo portion).If you would kind mention me the page in the next following comment it would of massive help :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf closed pull request #191: solved search
box interferes with menu and logo on smaller resolutions
Posted by GitBox <gi...@apache.org>.
CSElonewolf closed pull request #191: solved search box interferes with menu and logo on smaller resolutions
URL: https://github.com/apache/camel-website/pull/191
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #191: solved search
box interferes with menu and logo on smaller resolutions
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #191: solved search box interferes with menu and logo on smaller resolutions
URL: https://github.com/apache/camel-website/pull/191#issuecomment-597679813
> @CSElonewolf I think you're looking for the header navigation, which is in [this partial](https://github.com/apache/camel-website/blob/master/layouts/partials/header.html) for Hugo generated content, and again replicated in this [template](https://github.com/apache/camel-website/blob/master/antora-ui-camel/src/partials/header-content.hbs) for the Antora content.
Thank you Mr. @zregvart but I know that the html for the navbar section is under the header.html
But I was asking you about the html of the "20th anniversary logo section". --well this information will be helpful for my next PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf removed a comment on issue #191: solved
search box interferes with menu and logo on smaller resolutions
Posted by GitBox <gi...@apache.org>.
CSElonewolf removed a comment on issue #191: solved search box interferes with menu and logo on smaller resolutions
URL: https://github.com/apache/camel-website/pull/191#issuecomment-597679813
> @CSElonewolf I think you're looking for the header navigation, which is in [this partial](https://github.com/apache/camel-website/blob/master/layouts/partials/header.html) for Hugo generated content, and again replicated in this [template](https://github.com/apache/camel-website/blob/master/antora-ui-camel/src/partials/header-content.hbs) for the Antora content.
Thank you Mr. @zregvart but I know that the html for the navbar section is under the header.html
But I was asking you about the html of the "20th anniversary logo section". --well this information will be helpful for my next PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #191: solved search
box interferes with menu and logo on smaller resolutions
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #191: solved search box interferes with menu and logo on smaller resolutions
URL: https://github.com/apache/camel-website/pull/191#issuecomment-597792046
<img width="242" alt="yyyy" src="https://user-images.githubusercontent.com/51082429/76449904-ec8b2980-63f2-11ea-99d6-99b2a349d12a.png">
Now we have the logo + searchbar + hamburger menu in mobile version.
@zregvart , @oscerd and @psingh587 how is it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #191: solved search box
interferes with menu and logo on smaller resolutions
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #191: solved search box interferes with menu and logo on smaller resolutions
URL: https://github.com/apache/camel-website/pull/191#issuecomment-597561506
Thanks @CSElonewolf, I still miss the logo and the menu we had that's now pushed away by the search box. Do you think you can find a way to have them shown?
I'm not entirely sold on having the search be so prominent on smaller screens, i.e. I think the logo and the menu are more important than the search box.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #191: solved search
box interferes with menu and logo on smaller resolutions
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #191: solved search box interferes with menu and logo on smaller resolutions
URL: https://github.com/apache/camel-website/pull/191#issuecomment-597564567
Then we need to place the serach box have to placed within the hamburger menu in mobile screen. Github does the same(Like visit this same page in mobile to understand what I am trying to say).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf edited a comment on issue #191: solved
search box interferes with menu and logo on smaller resolutions
Posted by GitBox <gi...@apache.org>.
CSElonewolf edited a comment on issue #191: solved search box interferes with menu and logo on smaller resolutions
URL: https://github.com/apache/camel-website/pull/191#issuecomment-597564567
Then we need to place the search box within the hamburger menu in mobile screen. Github does the same(Like visit this same page in mobile to understand what I am trying to say).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #191: solved search box
interferes with menu and logo on smaller resolutions
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #191: solved search box interferes with menu and logo on smaller resolutions
URL: https://github.com/apache/camel-website/pull/191#issuecomment-597793012
Looks good!
Just to make sure we didn't introduce something when merging in #194 I'm going to rebase this on `master` branch and wait for the preview.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #191: solved search
box interferes with menu and logo on smaller resolutions
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #191: solved search box interferes with menu and logo on smaller resolutions
URL: https://github.com/apache/camel-website/pull/191#issuecomment-597627725
Hello,
@zregvart
In the lines of this PR, I have tried something. Please check and provide the feedback.
#192
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #191: solved search
box interferes with menu and logo on smaller resolutions
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #191: solved search box interferes with menu and logo on smaller resolutions
URL: https://github.com/apache/camel-website/pull/191#issuecomment-597796184
> <img alt="yyyy" width="242" src="https://user-images.githubusercontent.com/51082429/76449904-ec8b2980-63f2-11ea-99d6-99b2a349d12a.png">
>
> Now we have the logo + searchbar + hamburger menu in mobile version.
> @zregvart , @oscerd and @psingh587 how is it?
@CSElonewolf you could make the logo a bit smaller to look proportionate with the other items
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #191: solved search box
interferes with menu and logo on smaller resolutions
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #191: solved search box interferes with menu and logo on smaller resolutions
URL: https://github.com/apache/camel-website/pull/191#issuecomment-597616199
@CSElonewolf adding search to the menu is a good option I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services