You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/02/17 06:53:07 UTC

[GitHub] sijie commented on a change in pull request #1106: Issue 1103: Add channel TLS counters

sijie commented on a change in pull request #1106: Issue 1103: Add channel TLS counters
URL: https://github.com/apache/bookkeeper/pull/1106#discussion_r168914573
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tls/TLSContextFactory.java
 ##########
 @@ -58,7 +58,20 @@
      * Supported Key File Types.
      */
     public enum KeyStoreType {
-        PKCS12, JKS, PEM;
+        PKCS12("PKCS12"),
 
 Review comment:
   I don't think we need this change here. If I understand enum correctly, if you print enum, it will use its text literal as toString. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services