You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/20 08:58:23 UTC

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5357: JsonLogger implementation (#5356)

kezhenxu94 commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r473786125



##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java
##########
@@ -40,7 +42,7 @@
  * The <code>SnifferConfigInitializer</code> initializes all configs in several way.
  */
 public class SnifferConfigInitializer {
-    private static final ILog logger = LogManager.getLogger(SnifferConfigInitializer.class);
+    private static ILog LOGGER = LogManager.getLogger(SnifferConfigInitializer.class);

Review comment:
       @lujiajing1126 , what kind of style check do you mean, we don't check that, did you use a plugin in the IDE that's not relevant to SkyWalking's code style?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org