You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/29 06:29:17 UTC
[GitHub] [skywalking] yaojingguo opened a new issue #6640: apm-toolkit-trace: @Trace, @Tag and @Tags do not work for static methods
yaojingguo opened a new issue #6640:
URL: https://github.com/apache/skywalking/issues/6640
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [x] Question or discussion
- [ ] Bug
- [ ] Requirement
- [ ] Feature or performance improvement
___
I added `Trace` annotation to a static method. The result shows that `Trace` annotation does not work for static methods. A browse of `apm-toolkit-trace-activiation` module shows that `TagAnnotationActivation` and `TraceAnnotationActivation` only do method interception for static methods.
Does this work as designed? If not, I am willing to add support for static methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz commented on issue #6640: apm-toolkit-trace: @Trace, @Tag and @Tags do not work for static methods
Posted by GitBox <gi...@apache.org>.
liqiangz commented on issue #6640:
URL: https://github.com/apache/skywalking/issues/6640#issuecomment-813011916
Let me hava a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6640: apm-toolkit-trace: @Trace, @Tag and @Tags do not work for static methods
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6640:
URL: https://github.com/apache/skywalking/issues/6640#issuecomment-809143769
You could tag a value of the instance field, but can't do in static method.If we want to support static methods, we need things like traceStatic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] yaojingguo commented on issue #6640: apm-toolkit-trace: @Trace, @Tag and @Tags do not work for static methods
Posted by GitBox <gi...@apache.org>.
yaojingguo commented on issue #6640:
URL: https://github.com/apache/skywalking/issues/6640#issuecomment-809121007
I don't quite get your point. Could you give some explanation of `this referenece`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6640: apm-toolkit-trace: @Trace, @Tag and @Tags do not work for static methods
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6640:
URL: https://github.com/apache/skywalking/issues/6640#issuecomment-809111063
They are a little different. As static methods, you can access this reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6640: apm-toolkit-trace: @Trace, @Tag and @Tags do not work for static methods
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6640:
URL: https://github.com/apache/skywalking/issues/6640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org