You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2009/06/11 07:28:26 UTC
[Bug 6133] New: Shortcircuit plugin fails to act properly when
shortcircuit is set to 'ham' or 'spam'
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6133
Summary: Shortcircuit plugin fails to act properly when
shortcircuit is set to 'ham' or 'spam'
Product: Spamassassin
Version: 3.2.5
Platform: Other
OS/Version: Linux
Status: NEW
Severity: major
Priority: P5
Component: Plugins
AssignedTo: dev@spamassassin.apache.org
ReportedBy: amoselberg@hotmail.com
According to the shortcircuit documentation, if a rule is shortcircuit "spam"
or "ham" instead of "on," then it should set the score to be
shortcircuit_spam_score or shortcircuit_ham_score, respectively (and set
autolearn=off).
Instead, shortcircuit "spam" and "ham" are ignoring the
shortcircuit_(spam|ham)_score.
The defaults provide an example of the problem: By default, the spam threshold
is 5, shortcircuit BAYES_99 is set 'spam', and the score for BAYES_99 is 3.4
(or something like that). With that _default_ set of scores, any e-mail that
triggers BAYES_99 becomes ham -- it gets a score of 3.4 (or whatever) from the
BAYES_99 test, and all remaining tests are shortcircuited.
This is thus not the intended behavior of shortcircuit in several respects.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6133] Shortcircuit plugin fails to act properly when
shortcircuit is set to 'ham' or 'spam'
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6133
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
--- Comment #1 from Justin Mason <jm...@jmason.org> 2009-07-23 07:12:46 PST ---
should be easy to fix
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6133] Shortcircuit plugin fails to act properly when
shortcircuit is set to 'ham' or 'spam'
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6133
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 |P3
Target Milestone|Undefined |3.3.0
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6133] Shortcircuit plugin fails to act properly when
shortcircuit is set to 'ham' or 'spam'
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6133
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #2 from Justin Mason <jm...@jmason.org> 2009-07-28 15:21:31 PST ---
hmm. I had to come up with an additional change to how shortcircuiting is
displayed; there's now a symbolic rule, like AWL, called SHORTCIRCUIT. when
"shortcircuit spam" or "ham" is used, it fires with the appropriate score
value.
also, added a batch more tests.
: 410...; svn commit -m "bug 6133: shortcircuit_spam_score and
shortcircuit_ham_score were nonfunctional. fix"
Sending lib/Mail/SpamAssassin/Plugin/Shortcircuit.pm
Sending rules/60_shortcircuit.cf
Sending t/data/01_test_rules.cf
Sending t/shortcircuit.t
Transmitting file data ....
Committed revision 798721 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=798721 ).
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6133] Shortcircuit plugin fails to act properly when
shortcircuit is set to 'ham' or 'spam'
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6133
--- Comment #4 from Justin Mason <jm...@jmason.org> 2009-07-29 01:50:08 PST ---
(In reply to comment #3)
> I probably would have just created an empty test and used that, no real need to
> create a rule for this. Exercise left up to the reader though.
I thought of that, but there's a few spots where our code assumes there's a
rule to go with each test (e.g. setting descriptions requires a rule exists
iirc), so I thought it'd be better to be conservative. (I've been
corresponding with a plugin developer offlist about a similar problem
recently.)
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6133] Shortcircuit plugin fails to act properly when
shortcircuit is set to 'ham' or 'spam'
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6133
--- Comment #5 from Justin Mason <jm...@jmason.org> 2009-07-29 01:50:46 PST ---
(In reply to comment #4)
> I thought of that, but there's a few spots where our code assumes there's a
> rule to go with each test (e.g. setting descriptions requires a rule exists
> iirc), so I thought it'd be better to be conservative. (I've been
> corresponding with a plugin developer offlist about a similar problem
> recently.)
oh wait, I misunderstood. you mean a more simple type of rule instead of an
eval, right? suggestions?
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6133] Shortcircuit plugin fails to act properly when
shortcircuit is set to 'ham' or 'spam'
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6133
--- Comment #3 from Michael Parker <pa...@pobox.com> 2009-07-28 15:46:52 PST ---
I probably would have just created an empty test and used that, no real need to
create a rule for this. Exercise left up to the reader though.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.