[GitHub] [beam] tvalentyn commented on a diff in pull request #22191: Override log levels after log handler is created

[GitBox <gi...@apache.org>]

tvalentyn commented on code in PR #22191:
URL: https://github.com/apache/beam/pull/22191#discussion_r918163282


##########
sdks/python/apache_beam/runners/worker/sdk_worker_main_test.py:
##########
@@ -100,6 +101,30 @@ def test_runtime_values(self):
     self.assertTrue(test_runtime_provider.is_accessible())
     self.assertEqual(test_runtime_provider.get(), 37)
 
+  def test_crerate_sdk_harness_log_handler_received_log(self):
+    # tests that the log handler created in crerate_sdk_harness() does not miss

Review Comment:
   ```suggestion
       # tests that the log handler created in create_harness() does not miss
   ```



##########
sdks/python/apache_beam/runners/worker/sdk_worker_main_test.py:
##########
@@ -100,6 +101,30 @@ def test_runtime_values(self):
     self.assertTrue(test_runtime_provider.is_accessible())
     self.assertEqual(test_runtime_provider.get(), 37)
 
+  def test_crerate_sdk_harness_log_handler_received_log(self):

Review Comment:
   ```suggestion
     def test_create_sdk_harness_log_handler_received_log(self):
   ```



##########
sdks/python/apache_beam/runners/worker/sdk_worker_main_test.py:
##########
@@ -100,6 +101,30 @@ def test_runtime_values(self):
     self.assertTrue(test_runtime_provider.is_accessible())
     self.assertEqual(test_runtime_provider.get(), 37)
 
+  def test_crerate_sdk_harness_log_handler_received_log(self):
+    # tests that the log handler created in crerate_sdk_harness() does not miss
+    # logs emitted from crerate_sdk_harness() itself.

Review Comment:
   ```suggestion
       # logs emitted from create_harness() itself.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org