You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/01 12:47:04 UTC

[jira] [Commented] (KAFKA-5360) Down-converted uncompressed batches should respect fetch offset

    [ https://issues.apache.org/jira/browse/KAFKA-5360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032922#comment-16032922 ] 

ASF GitHub Bot commented on KAFKA-5360:
---------------------------------------

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/3191

    KAFKA-5360: Down-converted uncompressed batches should respect fetch offset

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka kafka-5360-down-converted-uncompressed-respect-offset

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3191.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3191
    
----
commit d4bba5f53f0ba4a95a4d152087deba9239d81434
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-06-01T12:46:20Z

    KAFKA-5360: Down-converted uncompressed batches should respect fetch offset

----


> Down-converted uncompressed batches should respect fetch offset
> ---------------------------------------------------------------
>
>                 Key: KAFKA-5360
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5360
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Ismael Juma
>            Assignee: Ismael Juma
>            Priority: Blocker
>             Fix For: 0.11.0.0
>
>
> More specifically, V2 messages are always batched (whether compressed or not) while V0/V1 are only batched if they are compressed.
> Clients like librdkafka expect to receive messages from the requested offset when dealing with uncompressed V0/V1 messages. When converting from V2 to V0/1, we seem to be returning all the messages in the V2 batch instead of messages from the requested offset.
> Thanks to [~edenhill] for investigating this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)