You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2010/06/02 20:41:42 UTC
[jira] Created: (HBASE-2658) REST (stargate) TableRegionModel
Regions need to be updated to work w/ new region naming convention from
HBASE-2531
REST (stargate) TableRegionModel Regions need to be updated to work w/ new region naming convention from HBASE-2531
-------------------------------------------------------------------------------------------------------------------
Key: HBASE-2658
URL: https://issues.apache.org/jira/browse/HBASE-2658
Project: HBase
Issue Type: Bug
Reporter: stack
Assignee: Andrew Purtell
Fix For: 0.21.0
One reason TestTableResource was failing was because comparing region names as strings was failing because the two below no longer matched. My guess is that the rest stuff is not using the new means of constructing region names. See HBASE-2531
TestTableResource,,1275503739792.30a45563321be3ec11841b0f1e79d687.
TestTableResource,,1275503739792
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2658) REST (stargate) TableRegionModel
Regions need to be updated to work w/ new region naming convention from
HBASE-2531
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922445#action_12922445 ]
stack commented on HBASE-2658:
------------------------------
Is this needed for 0.90 Andrew? I'd think so.
> REST (stargate) TableRegionModel Regions need to be updated to work w/ new region naming convention from HBASE-2531
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-2658
> URL: https://issues.apache.org/jira/browse/HBASE-2658
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Andrew Purtell
> Fix For: 0.90.0
>
>
> One reason TestTableResource was failing was because comparing region names as strings was failing because the two below no longer matched. My guess is that the rest stuff is not using the new means of constructing region names. See HBASE-2531
> TestTableResource,,1275503739792.30a45563321be3ec11841b0f1e79d687.
> TestTableResource,,1275503739792
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2658) REST (stargate) TableRegionModel
Regions need to be updated to work w/ new region naming convention from
HBASE-2531
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923615#action_12923615 ]
HBase Review Board commented on HBASE-2658:
-------------------------------------------
Message from: "Andrew Purtell" <ap...@apache.org>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1063/#review1602
-----------------------------------------------------------
Ship it!
Looks good.
- Andrew
> REST (stargate) TableRegionModel Regions need to be updated to work w/ new region naming convention from HBASE-2531
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-2658
> URL: https://issues.apache.org/jira/browse/HBASE-2658
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Andrew Purtell
> Fix For: 0.90.0
>
>
> One reason TestTableResource was failing was because comparing region names as strings was failing because the two below no longer matched. My guess is that the rest stuff is not using the new means of constructing region names. See HBASE-2531
> TestTableResource,,1275503739792.30a45563321be3ec11841b0f1e79d687.
> TestTableResource,,1275503739792
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2658) REST (stargate) TableRegionModel
Regions need to be updated to work w/ new region naming convention from
HBASE-2531
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923563#action_12923563 ]
HBase Review Board commented on HBASE-2658:
-------------------------------------------
Message from: stack@duboce.net
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1063/
-----------------------------------------------------------
Review request for hbase and Andrew Purtell.
Summary
-------
Andrew, can you look at this? Its making the TableRegionModel do the new HRegionInfo name format. Has a few tests even. I also changed the TestTableResource back to old style compare of region names and now it passes.
This addresses bug hbase-2658.
http://issues.apache.org/jira/browse/hbase-2658
Diffs
-----
trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 1026078
trunk/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java 1026078
trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1026078
trunk/src/main/java/org/apache/hadoop/hbase/rest/model/TableRegionModel.java 1026078
trunk/src/main/java/org/apache/hadoop/hbase/util/MetaUtils.java 1026078
trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java 1026078
trunk/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java 1026078
Diff: http://review.cloudera.org/r/1063/diff
Testing
-------
Thanks,
stack
> REST (stargate) TableRegionModel Regions need to be updated to work w/ new region naming convention from HBASE-2531
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-2658
> URL: https://issues.apache.org/jira/browse/HBASE-2658
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Andrew Purtell
> Fix For: 0.90.0
>
>
> One reason TestTableResource was failing was because comparing region names as strings was failing because the two below no longer matched. My guess is that the rest stuff is not using the new means of constructing region names. See HBASE-2531
> TestTableResource,,1275503739792.30a45563321be3ec11841b0f1e79d687.
> TestTableResource,,1275503739792
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-2658) REST (stargate) TableRegionModel
Regions need to be updated to work w/ new region naming convention from
HBASE-2531
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-2658.
--------------------------
Resolution: Fixed
Assignee: stack (was: Andrew Purtell)
Hadoop Flags: [Reviewed]
Committed. Resolving.
> REST (stargate) TableRegionModel Regions need to be updated to work w/ new region naming convention from HBASE-2531
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-2658
> URL: https://issues.apache.org/jira/browse/HBASE-2658
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.90.0
>
>
> One reason TestTableResource was failing was because comparing region names as strings was failing because the two below no longer matched. My guess is that the rest stuff is not using the new means of constructing region names. See HBASE-2531
> TestTableResource,,1275503739792.30a45563321be3ec11841b0f1e79d687.
> TestTableResource,,1275503739792
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2658) REST (stargate) TableRegionModel
Regions need to be updated to work w/ new region naming convention from
HBASE-2531
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874731#action_12874731 ]
stack commented on HBASE-2658:
------------------------------
Over in hbase-2657 I loosed the below changing it to a startsWith from an equals test:
{code}
HRegionInfo hri = e.getKey();
String hriRegionName = hri.getRegionNameAsString();
String regionName = region.getName();
if (hriRegionName.startsWith(regionName)) {
{code}
Restore when fix for this here.
> REST (stargate) TableRegionModel Regions need to be updated to work w/ new region naming convention from HBASE-2531
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-2658
> URL: https://issues.apache.org/jira/browse/HBASE-2658
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Andrew Purtell
> Fix For: 0.21.0
>
>
> One reason TestTableResource was failing was because comparing region names as strings was failing because the two below no longer matched. My guess is that the rest stuff is not using the new means of constructing region names. See HBASE-2531
> TestTableResource,,1275503739792.30a45563321be3ec11841b0f1e79d687.
> TestTableResource,,1275503739792
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2658) REST (stargate) TableRegionModel
Regions need to be updated to work w/ new region naming convention from
HBASE-2531
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874738#action_12874738 ]
stack commented on HBASE-2658:
------------------------------
Assigned Andrew since it seems like a pretty big, if simple, change needed. The 'id' in TableRegionModel needs to change form long to String?
> REST (stargate) TableRegionModel Regions need to be updated to work w/ new region naming convention from HBASE-2531
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-2658
> URL: https://issues.apache.org/jira/browse/HBASE-2658
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Andrew Purtell
> Fix For: 0.21.0
>
>
> One reason TestTableResource was failing was because comparing region names as strings was failing because the two below no longer matched. My guess is that the rest stuff is not using the new means of constructing region names. See HBASE-2531
> TestTableResource,,1275503739792.30a45563321be3ec11841b0f1e79d687.
> TestTableResource,,1275503739792
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.