You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/28 15:18:37 UTC

[GitHub] [arrow] jorisvandenbossche opened a new pull request #9350: ARROW-11400: [Python] Ensure pickling Dataset with dictionary partitions works

jorisvandenbossche opened a new pull request #9350:
URL: https://github.com/apache/arrow/pull/9350


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jorisvandenbossche commented on pull request #9350: ARROW-11400: [Python] Ensure pickling Dataset with dictionary partitions works

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #9350:
URL: https://github.com/apache/arrow/pull/9350#issuecomment-769175506


   @bkietz only after writing the test and noticing that it didn't fail as test but did fail in the IPython console, I realized this is what we were debugging on your PR ... Now, additional test probably can't harm, and by adding the to_pandas call I succeeded to actually let it fail in my local environment also as test (so no longer only in the console), so that's probably usefule ;)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9350: ARROW-11400: [Python] Ensure pickling Dataset with dictionary partitions works

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9350:
URL: https://github.com/apache/arrow/pull/9350#issuecomment-769191120


   https://issues.apache.org/jira/browse/ARROW-11400


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jorisvandenbossche closed pull request #9350: ARROW-11400: [Python] Ensure pickling Dataset with dictionary partitions works

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche closed pull request #9350:
URL: https://github.com/apache/arrow/pull/9350


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jorisvandenbossche closed pull request #9350: ARROW-11400: [Python] Ensure pickling Dataset with dictionary partitions works

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche closed pull request #9350:
URL: https://github.com/apache/arrow/pull/9350


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jorisvandenbossche edited a comment on pull request #9350: ARROW-11400: [Python] Ensure pickling Dataset with dictionary partitions works

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche edited a comment on pull request #9350:
URL: https://github.com/apache/arrow/pull/9350#issuecomment-769175506


   @bkietz only after writing the test and noticing that it didn't fail as test but did fail in the IPython console, I realized this is what we were debugging on your PR ... Now, an additional test probably can't harm, and by adding the to_pandas call I succeeded to actually let it fail in my local environment also as test (so no longer only in the console), so that's probably useful anyway ;)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jorisvandenbossche edited a comment on pull request #9350: ARROW-11400: [Python] Ensure pickling Dataset with dictionary partitions works

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche edited a comment on pull request #9350:
URL: https://github.com/apache/arrow/pull/9350#issuecomment-769175506


   @bkietz only after writing the test and noticing that it didn't fail as test but did fail in the IPython console, I realized this is what we were debugging on your PR ... Now, an additional test probably can't harm, and by adding the to_pandas call I succeeded to actually let it fail in my local environment also as test (so no longer only in the console), so that's probably useful anyway ;)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org