[GitHub] betodealmeida opened a new pull request #6953: Fix deck.gl form data

[GitBox <gi...@apache.org>]

betodealmeida opened a new pull request #6953: Fix deck.gl form data
URL: https://github.com/apache/incubator-superset/pull/6953
 
 
   Looks like we changed the schema of the form data payload, and this broke deck.gl visualizations. I fixed the visualizations, but it seems like there are other places where we still have the old format:
   
   ```bash
   $ ggrep -ERsi '(formdata|fd|form_data)\.\w+_'
   chart/chartAction.js:    const granularity = fd.time_grain_sqla || fd.granularity;
   chart/chartAction.js:    fd.time_grain_sqla = granularity;
   chart/chartAction.js:          has_extra_filters: formData.extra_filters && formData.extra_filters.length > 0,
   chart/chartAction.js:          viz_type: formData.viz_type,
   chart/chartAction.js:    const annotationLayers = formData.annotation_layers || [];
   explore/store.js:  if (formData.y_axis_zero) {
   explore/store.js:    formData.y_axis_bounds = [0, null];
   explore/store.js:  const vizType = formData.viz_type || 'table';
   explore/store.js:  const vizType = form_data.viz_type || 'table';
   explore/exploreUtils.js:      viz_type: formData.viz_type,
   explore/exploreUtils.js:  if (formData.slice_id) {
   explore/exploreUtils.js:    search.form_data = safeStringify({ slice_id: formData.slice_id });
   explore/components/ControlPanelsContainer.jsx:    return sectionsToRender(this.props.form_data.viz_type, this.props.datasource_type);
   explore/components/ExploreChartHeader.jsx:              limit={formData.row_limit}
   explore/components/ExploreViewContainer.jsx:    table_name: form_data.datasource_name,
   explore/components/ExploreViewContainer.jsx:    vizType: form_data.viz_type,
   explore/components/SaveModal.jsx:      vizType: props.form_data.viz_type,
   dashboard/util/logging/childChartsDidLoad.js:    if (query.formData && query.formData.viz_type !== 'filter_box') {
   dashboard/reducers/getInitialState.js:    if (['separator', 'markup'].indexOf(slice.form_data.viz_type) === -1) {
   dashboard/reducers/getInitialState.js:        viz_type: slice.form_data.viz_type,
   query/FormData.ts:  return 'granularity_sqla' in formData ? formData.granularity_sqla : formData.granularity;
   ```
   
   @kristw should these be fixed as well? I'm not following the changes closely.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org