You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/20 17:41:46 UTC
[GitHub] [camel-k] rinaldodev opened a new issue, #3761: Ready condition message not always taken from Camel Health Check
rinaldodev opened a new issue, #3761:
URL: https://github.com/apache/camel-k/issues/3761
Recently there has been a change to grab the error message for the Ready condition, when False, from camel's health check: https://github.com/apache/camel-k/blob/151def156ef0bcb8f4b05e95a2eb7de75cf111fd/pkg/controller/integration/monitor.go#L437-L445
This does work from time to time, but in some cases it doesn't. By talking to @astefanutti it seems to be related to this check:
https://github.com/apache/camel-k/blob/151def156ef0bcb8f4b05e95a2eb7de75cf111fd/pkg/controller/integration/monitor.go#L269-L271
Since the above check if the deployment progressing condition is false, and returns early, it doesn't get to the point of probing the pod's health check in the next few lines of code.
Here is an example where a pod is not ready, but could still be probed:
```
mctr-cd78npqi585nmcobr0bg-69bc58cbff-6g95b 0/1 Running 0 16m
```
```
{
"status": "DOWN",
"checks": [{
"name": "custom-camel-routecontroller-health-check",
"status": "DOWN",
"data": {
"route.id": "cd78npqi585nmcobr0bg-source",
"error.message": "Not authorized to access group: cd78npqi585nmcobr0bg",
"route.status": "stopped",
"check.kind": "READINESS"
}
}, {
"name": "context",
"status": "UP",
"data": {
"context.name": "camel-1",
"context.version": "3.18.2",
"context.status": "Started",
"check.kind": "READINESS"
}
}]
}
```
Because of this behavior, the Ready condition ends up containing the following message:
```
message: ReplicaSet "mctr-cd78npqi585nmcobr0bg-69bc58cbff" has timed out progressing.
```
while not informing the real root cause that is present in the health check: `Not authorized to access group: cd78npqi585nmcobr0bg`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] rinaldodev commented on issue #3761: Ready condition message not always taken from Camel Health Check
Posted by GitBox <gi...@apache.org>.
rinaldodev commented on issue #3761:
URL: https://github.com/apache/camel-k/issues/3761#issuecomment-1318659978
Thanks @tadayosi! I'll test locally with the test case I had.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on issue #3761: Ready condition message not always taken from Camel Health Check
Posted by GitBox <gi...@apache.org>.
tadayosi commented on issue #3761:
URL: https://github.com/apache/camel-k/issues/3761#issuecomment-1313194308
@rinaldodev Just to make sure we are on the same page, let me ask a couple of questions.
> Recently there has been a change to grab the error message for the Ready condition,
How recently is it? Is it on the `main` branch or the changes already included in the recent release like 1.10.2?
Also, is there a way to replicate the issue? Which version of Camel K have you used? It's important for us to test if a fix really resolves the issue at our end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on issue #3761: Ready condition message not always taken from Camel Health Check
Posted by GitBox <gi...@apache.org>.
astefanutti commented on issue #3761:
URL: https://github.com/apache/camel-k/issues/3761#issuecomment-1286692583
To add some historical background, the first iteration of that mechanism, that probes into the Camel runtime, has been conservative, so the health endpoint is only probed when the underlying Deployment controller, reports a truthy _progressing_ condition.
Now that this mechanism has proved both useful and reliable, the proposition would be to also probe the health endpoint when the Deployment has ended progression (and also generalising for other underlying controllers), so a more detailed error message can be reported, and fallback on the generic message provided by the underlying controller if probing the endpoint fails, e.g. when the pod(s) is/are not running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi closed issue #3761: Ready condition message not always taken from Camel Health Check
Posted by GitBox <gi...@apache.org>.
tadayosi closed issue #3761: Ready condition message not always taken from Camel Health Check
URL: https://github.com/apache/camel-k/issues/3761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on issue #3761: Ready condition message not always taken from Camel Health Check
Posted by GitBox <gi...@apache.org>.
tadayosi commented on issue #3761:
URL: https://github.com/apache/camel-k/issues/3761#issuecomment-1316466996
> How recently is it? Is it on the `main` branch or the changes already included in the recent release like 1.10.2?
OK, it should be this: #2719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on issue #3761: Ready condition message not always taken from Camel Health Check
Posted by GitBox <gi...@apache.org>.
tadayosi commented on issue #3761:
URL: https://github.com/apache/camel-k/issues/3761#issuecomment-1321500188
@rinaldodev Thanks. Yes, please test it at your end and let me know if the fix really solves the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org