[GitHub] [trafficcontrol] rob05c opened a new pull request #6105: Remove t3c dispersion flags

[GitBox <gi...@apache.org>]

rob05c opened a new pull request #6105:
URL: https://github.com/apache/trafficcontrol/pull/6105


   Removes the t3c-apply `--dispersion`, `--login-dispersion`, and `--reval-wait-time` flags, and their corresponding features in `t3c`.
   
   When `ort.pl` was slow, there was advantage to doing random sleeps internally, and revalidating periodically (since multiple scripts can't run at once, since they manipulate the same files). But the `t3c` run is fast enough now, there's no advantage to sleeping internally anymore.
   
   There's still reason to randomly sleep before a run interval, to reduce Traffic Ops load. But that is easier and better to do by composing apps, e.g. `sleep "$((RANDOM % 60))" && t3c ...`.
   
   The move in 6.0 from `t3c ...` to `t3c apply` is already a breaking change, so this in-itself is not a breaking change.
   
   Tests exist to verify existing functionality, and this only removes and doesn't add features.
   Includes docs.
   Includes changelog.
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Control Cache Config (T3C, formerly ORT)
   
   ## What is the best way to verify this PR?
   Run tests. Run `t3c`, verify it works as before sans dispersion feature/flags.
   
   ## If this is a bugfix, which Traffic Control versions contained the bug?
   Not a bug fix.
   
   
   ## PR submission checklist
   - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
   - [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
   - [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] zrhoffman merged pull request #6105: Remove t3c dispersion flags

[GitBox <gi...@apache.org>]

zrhoffman merged pull request #6105:
URL: https://github.com/apache/trafficcontrol/pull/6105


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org