[GitHub] [airflow] FloChehab commented on a change in pull request #13571: Parametrized keda task concurrency in chart

[GitBox <gi...@apache.org>]

FloChehab commented on a change in pull request #13571:
URL: https://github.com/apache/airflow/pull/13571#discussion_r554419164



##########
File path: chart/values.yaml
##########
@@ -706,6 +706,7 @@ config:
     rbac: 'True'
   celery:
     default_queue: celery
+    worker_concurrency: 8

Review comment:
       I know about this as I mentionned in the PR description:
   
   > The only impact is that with this PR the default concurrency of KEDA goes down from 16 to 8 (I thought that would be better than to set the concurrency by default from 8 to 16 for all CeleryExecutor deployments).
   
   I did this because the default value in airflow settings seems to be 8: https://github.com/apache/airflow/blob/master/airflow/config_templates/default_airflow.cfg#L666
   
   I am definitely ok setting back this to 16 if you want too.

##########
File path: chart/values.yaml
##########
@@ -706,6 +706,7 @@ config:
     rbac: 'True'
   celery:
     default_queue: celery
+    worker_concurrency: 8

Review comment:
       I know about this as I mentioned in the PR description:
   
   > The only impact is that with this PR the default concurrency of KEDA goes down from 16 to 8 (I thought that would be better than to set the concurrency by default from 8 to 16 for all CeleryExecutor deployments).
   
   I did this because the default value in airflow settings seems to be 8: https://github.com/apache/airflow/blob/master/airflow/config_templates/default_airflow.cfg#L666
   
   I am definitely ok setting back this to 16 if you want too.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org