You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "claudemamo (via GitHub)" <gi...@apache.org> on 2023/02/14 20:42:08 UTC
[GitHub] [camel] claudemamo opened a new pull request, #9349: CAMEL-19050: add DHIS2 component
claudemamo opened a new pull request, #9349:
URL: https://github.com/apache/camel/pull/9349
# Description
Add DHIS2 Camel Component.
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [x] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
<!--
You can run the aforementioned command in your module so that the build auto-formats your code and the source check verifies that is complies with our coding style. This will also be verified as part of the checks and your PR may be rejected if the checkstyle does not pass.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd closed pull request #9349: CAMEL-19050: add DHIS2 component
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd closed pull request #9349: CAMEL-19050: add DHIS2 component
URL: https://github.com/apache/camel/pull/9349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a diff in pull request #9349: CAMEL-19050: add DHIS2 component
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on code in PR #9349:
URL: https://github.com/apache/camel/pull/9349#discussion_r1108516035
##########
components/camel-dhis2/camel-dhis2-api/pom.xml:
##########
@@ -0,0 +1,50 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-dhis2-parent</artifactId>
+ <version>4.0.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>camel-dhis2-api</artifactId>
+ <name>Camel DHIS2 API</name>
+ <description>Camel DHIS2 API</description>
+ <packaging>jar</packaging>
+
+ <properties>
+ <firstVersion>3.21.0</firstVersion>
Review Comment:
In that case no, it should be 3.21.0, but only after 3.21.0 will be release, so for the moment it should be 4.0.0-SNAPSHOT, until we release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] claudemamo commented on a diff in pull request #9349: CAMEL-19050: add DHIS2 component
Posted by "claudemamo (via GitHub)" <gi...@apache.org>.
claudemamo commented on code in PR #9349:
URL: https://github.com/apache/camel/pull/9349#discussion_r1108513499
##########
components/camel-dhis2/camel-dhis2-api/pom.xml:
##########
@@ -0,0 +1,50 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-dhis2-parent</artifactId>
+ <version>4.0.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>camel-dhis2-api</artifactId>
+ <name>Camel DHIS2 API</name>
+ <description>Camel DHIS2 API</description>
+ <packaging>jar</packaging>
+
+ <properties>
+ <firstVersion>3.21.0</firstVersion>
Review Comment:
We're going to contribute the component to the `camel-3.x` branch as well. Should it be anyway 4.0.0-SNAPSHOT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a diff in pull request #9349: CAMEL-19050: add DHIS2 component
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on code in PR #9349:
URL: https://github.com/apache/camel/pull/9349#discussion_r1106822756
##########
components/camel-dhis2/LICENSE:
##########
@@ -0,0 +1,24 @@
+Copyright (c) 2004-2022, University of Oslo
Review Comment:
The code must be provided with an ASF License compliant license: https://www.apache.org/legal/resolved.html#category-a
As far as I see this project has been licensed as BSD 3-Clause
This copyright of University of Oslo shouldn't be there.
##########
components/camel-dhis2/camel-dhis2-api/pom.xml:
##########
@@ -0,0 +1,50 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-dhis2-parent</artifactId>
+ <version>4.0.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>camel-dhis2-api</artifactId>
+ <name>Camel DHIS2 API</name>
+ <description>Camel DHIS2 API</description>
+ <packaging>jar</packaging>
+
+ <properties>
+ <firstVersion>3.21.0</firstVersion>
Review Comment:
This should be 4.0.0-SNAPSHOT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #9349: CAMEL-19050: add DHIS2 component
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #9349:
URL: https://github.com/apache/camel/pull/9349#issuecomment-1443508695
I removed the javadoc camel-dhis2-api jar, tests were passing. Merged and pushed. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #9349: CAMEL-19050: add DHIS2 component
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #9349:
URL: https://github.com/apache/camel/pull/9349#issuecomment-1443410902
Trying to merge this but it's failing with
[ERROR] Failed to execute goal on project camel-dhis2: Could not resolve dependencies for project org.apache.camel:camel-dhis2:jar:4.0.0-SNAPSHOT: Could not find artifact org.apache.camel:camel-dhis2-api:jar:javadoc:4.0.0-SNAPSHOT in apache-public (https://repository.apache.org/content/groups/public/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9349: CAMEL-19050: add DHIS2 component
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #9349:
URL: https://github.com/apache/camel/pull/9349#issuecomment-1430787243
Thanks for the contribution.
However all the source code must use the ASF license header. So either you need to change this in the PR or we cannot accept the PR to ASF.
Also it would be good to write a bit more in the .doc file what dhis2 is. Just a few lines to explain it to users that do not know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9349: CAMEL-19050: add DHIS2 component
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9349:
URL: https://github.com/apache/camel/pull/9349#issuecomment-1430347948
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org