You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Alexander Rukletsov <al...@mesosphere.io> on 2015/03/05 22:05:52 UTC
Re: Review Request 31262: Moved allocator actions before
TestAllocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/
-----------------------------------------------------------
(Updated March 5, 2015, 9:05 p.m.)
Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
Changes
-------
Rebased.
Bugs: MESOS-2160
https://issues.apache.org/jira/browse/MESOS-2160
Repository: mesos
Description
-------
Once TestAllocator is not a template, the allocator actions should be defined before the are used in TestAllocator.
Diffs (updated)
-----
src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
Diff: https://reviews.apache.org/r/31262/diff/
Testing (updated)
-------
make check (Mac OS 10.9.5, Ubuntu 14.04)
Thanks,
Alexander Rukletsov
Re: Review Request 31262: Moved allocator actions before
TestAllocator.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/#review75412
-----------------------------------------------------------
Ship it!
Ship It!
- Joerg Schad
On March 5, 2015, 9:05 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31262/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 9:05 p.m.)
>
>
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
>
>
> Bugs: MESOS-2160
> https://issues.apache.org/jira/browse/MESOS-2160
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Once TestAllocator is not a template, the allocator actions should be defined before the are used in TestAllocator.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
>
> Diff: https://reviews.apache.org/r/31262/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, Ubuntu 14.04)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 31262: Moved allocator actions before
TestAllocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On March 10, 2015, 9:10 p.m., Niklas Nielsen wrote:
> > Can you leave a comment about why you need it? (In terms of your following refactorings will break if you don't do it)
As I mention in the description, once TestAllocator is not a template (r/31263/), the allocator actions should be defined before the are used in TestAllocator.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/#review75964
-----------------------------------------------------------
On March 5, 2015, 9:05 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31262/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 9:05 p.m.)
>
>
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
>
>
> Bugs: MESOS-2160
> https://issues.apache.org/jira/browse/MESOS-2160
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Once TestAllocator is not a template, the allocator actions should be defined before the are used in TestAllocator.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
>
> Diff: https://reviews.apache.org/r/31262/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, Ubuntu 14.04)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 31262: Moved allocator actions before
TestAllocator.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/#review75964
-----------------------------------------------------------
Can you leave a comment about why you need it? (In terms of your following refactorings will break if you don't do it)
- Niklas Nielsen
On March 5, 2015, 1:05 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31262/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 1:05 p.m.)
>
>
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
>
>
> Bugs: MESOS-2160
> https://issues.apache.org/jira/browse/MESOS-2160
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Once TestAllocator is not a template, the allocator actions should be defined before the are used in TestAllocator.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
>
> Diff: https://reviews.apache.org/r/31262/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, Ubuntu 14.04)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 31262: Moved allocator actions before
TestAllocator.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/#review78696
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 1, 2015, 2:27 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31262/
> -----------------------------------------------------------
>
> (Updated April 1, 2015, 2:27 p.m.)
>
>
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
>
>
> Bugs: MESOS-2160
> https://issues.apache.org/jira/browse/MESOS-2160
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Once TestAllocator is not a template, the allocator actions should be defined before they are used in TestAllocator.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 0e98572a62ae05437bd2bc800c370ad1a0c43751
>
> Diff: https://reviews.apache.org/r/31262/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, CentOS 7.0)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 31262: Moved allocator actions before
TestAllocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/
-----------------------------------------------------------
(Updated April 20, 2015, 1:46 p.m.)
Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
Changes
-------
Rebased & updated the description.
Bugs: MESOS-2160
https://issues.apache.org/jira/browse/MESOS-2160
Repository: mesos
Description (updated)
-------
The allocator actions should be defined before they are used in TestAllocator, despite it compiles now since TestAllocator is a template.
Diffs (updated)
-----
src/tests/mesos.hpp 7744df55a2a31446327da7bd2b16457e90711d22
Diff: https://reviews.apache.org/r/31262/diff/
Testing
-------
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
Re: Review Request 31262: Moved allocator actions before
TestAllocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/
-----------------------------------------------------------
(Updated April 15, 2015, 2:17 p.m.)
Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
Changes
-------
Rebased.
Bugs: MESOS-2160
https://issues.apache.org/jira/browse/MESOS-2160
Repository: mesos
Description
-------
Once TestAllocator is not a template, the allocator actions should be defined before they are used in TestAllocator.
Diffs (updated)
-----
src/tests/mesos.hpp 42e42ac425a448fcc5e93db1cef1112cbf5e67c4
Diff: https://reviews.apache.org/r/31262/diff/
Testing
-------
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
Re: Review Request 31262: Moved allocator actions before
TestAllocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/
-----------------------------------------------------------
(Updated April 7, 2015, 12:48 p.m.)
Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
Changes
-------
Rebased.
Bugs: MESOS-2160
https://issues.apache.org/jira/browse/MESOS-2160
Repository: mesos
Description
-------
Once TestAllocator is not a template, the allocator actions should be defined before they are used in TestAllocator.
Diffs (updated)
-----
src/tests/mesos.hpp 0e98572a62ae05437bd2bc800c370ad1a0c43751
Diff: https://reviews.apache.org/r/31262/diff/
Testing
-------
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
Re: Review Request 31262: Moved allocator actions before
TestAllocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/
-----------------------------------------------------------
(Updated April 1, 2015, 2:27 p.m.)
Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
Changes
-------
Rebased.
Bugs: MESOS-2160
https://issues.apache.org/jira/browse/MESOS-2160
Repository: mesos
Description
-------
Once TestAllocator is not a template, the allocator actions should be defined before they are used in TestAllocator.
Diffs (updated)
-----
src/tests/mesos.hpp 0e98572a62ae05437bd2bc800c370ad1a0c43751
Diff: https://reviews.apache.org/r/31262/diff/
Testing
-------
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
Re: Review Request 31262: Moved allocator actions before
TestAllocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/
-----------------------------------------------------------
(Updated March 27, 2015, 4:26 p.m.)
Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
Changes
-------
Rebased.
Bugs: MESOS-2160
https://issues.apache.org/jira/browse/MESOS-2160
Repository: mesos
Description
-------
Once TestAllocator is not a template, the allocator actions should be defined before they are used in TestAllocator.
Diffs (updated)
-----
src/tests/mesos.hpp 0e98572a62ae05437bd2bc800c370ad1a0c43751
Diff: https://reviews.apache.org/r/31262/diff/
Testing
-------
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
Re: Review Request 31262: Moved allocator actions before
TestAllocator.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/#review77401
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On March 23, 2015, 10:06 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31262/
> -----------------------------------------------------------
>
> (Updated March 23, 2015, 10:06 a.m.)
>
>
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
>
>
> Bugs: MESOS-2160
> https://issues.apache.org/jira/browse/MESOS-2160
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Once TestAllocator is not a template, the allocator actions should be defined before they are used in TestAllocator.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
>
> Diff: https://reviews.apache.org/r/31262/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, CentOS 7.0)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 31262: Moved allocator actions before
TestAllocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/
-----------------------------------------------------------
(Updated March 23, 2015, 2:06 p.m.)
Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
Changes
-------
Rebased.
Bugs: MESOS-2160
https://issues.apache.org/jira/browse/MESOS-2160
Repository: mesos
Description
-------
Once TestAllocator is not a template, the allocator actions should be defined before they are used in TestAllocator.
Diffs (updated)
-----
src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
Diff: https://reviews.apache.org/r/31262/diff/
Testing (updated)
-------
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
Re: Review Request 31262: Moved allocator actions before
TestAllocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/
-----------------------------------------------------------
(Updated March 19, 2015, 12:36 a.m.)
Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
Changes
-------
Fixed typo in description.
Bugs: MESOS-2160
https://issues.apache.org/jira/browse/MESOS-2160
Repository: mesos
Description (updated)
-------
Once TestAllocator is not a template, the allocator actions should be defined before they are used in TestAllocator.
Diffs
-----
src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
Diff: https://reviews.apache.org/r/31262/diff/
Testing
-------
make check (Mac OS 10.9.5, Ubuntu 14.04)
Thanks,
Alexander Rukletsov
Re: Review Request 31262: Moved allocator actions before
TestAllocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On March 17, 2015, 9:06 p.m., Kapil Arya wrote:
> > SGTM minus the following change in the description:
> > s/before the are used/before they are used/
thanks!
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/#review76811
-----------------------------------------------------------
On March 19, 2015, 12:36 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31262/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 12:36 a.m.)
>
>
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
>
>
> Bugs: MESOS-2160
> https://issues.apache.org/jira/browse/MESOS-2160
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Once TestAllocator is not a template, the allocator actions should be defined before they are used in TestAllocator.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
>
> Diff: https://reviews.apache.org/r/31262/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, Ubuntu 14.04)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 31262: Moved allocator actions before
TestAllocator.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/#review76811
-----------------------------------------------------------
SGTM minus the following change in the description:
s/before the are used/before they are used/
- Kapil Arya
On March 13, 2015, 5:49 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31262/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 5:49 p.m.)
>
>
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
>
>
> Bugs: MESOS-2160
> https://issues.apache.org/jira/browse/MESOS-2160
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Once TestAllocator is not a template, the allocator actions should be defined before the are used in TestAllocator.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
>
> Diff: https://reviews.apache.org/r/31262/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, Ubuntu 14.04)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 31262: Moved allocator actions before
TestAllocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/
-----------------------------------------------------------
(Updated March 13, 2015, 9:49 p.m.)
Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
Changes
-------
Rebased.
Bugs: MESOS-2160
https://issues.apache.org/jira/browse/MESOS-2160
Repository: mesos
Description
-------
Once TestAllocator is not a template, the allocator actions should be defined before the are used in TestAllocator.
Diffs (updated)
-----
src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
Diff: https://reviews.apache.org/r/31262/diff/
Testing
-------
make check (Mac OS 10.9.5, Ubuntu 14.04)
Thanks,
Alexander Rukletsov