You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/02 19:22:51 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #9077: ARROW-11107: [Rust] Faster Length kernel (10%)
jorgecarleitao opened a new pull request #9077:
URL: https://github.com/apache/arrow/pull/9077
This is a corollary of the new API PRed in #9076 , and how we can use it to efficiently build `Buffer` without even using the `MutableBuffer`. The main idea here is that we can write
```
let lengths: Buffer = slice
.windows(2)
.map(|offset| offset[1] - offset[0])
.collect();
```
and this (efficiently) builds a `Buffer` from the offset differences.
Bench:
```
length time: [3.2345 us 3.2457 us 3.2602 us]
change: [-12.072% -11.361% -10.654%] (p = 0.00 < 0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
4 (4.00%) high mild
6 (6.00%) high severe
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9077: ARROW-11107: [Rust] Faster Length kernel (10%)
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9077:
URL: https://github.com/apache/arrow/pull/9077#issuecomment-753520403
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9077?src=pr&el=h1) Report
> Merging [#9077](https://codecov.io/gh/apache/arrow/pull/9077?src=pr&el=desc) (c1badea) into [master](https://codecov.io/gh/apache/arrow/commit/4b7cdcb9220b6d94b251aef32c21ef9b4097ecfa?el=desc) (4b7cdcb) will **decrease** coverage by `0.05%`.
> The diff coverage is `93.50%`.
[](https://codecov.io/gh/apache/arrow/pull/9077?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9077 +/- ##
==========================================
- Coverage 82.61% 82.56% -0.06%
==========================================
Files 203 204 +1
Lines 50140 50091 -49
==========================================
- Hits 41422 41356 -66
- Misses 8718 8735 +17
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9077?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/bytes.rs](https://codecov.io/gh/apache/arrow/pull/9077/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYnl0ZXMucnM=) | `53.12% <ø> (-5.21%)` | :arrow_down: |
| [rust/arrow/src/compute/kernels/aggregate.rs](https://codecov.io/gh/apache/arrow/pull/9077/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2FnZ3JlZ2F0ZS5ycw==) | `74.93% <ø> (-0.07%)` | :arrow_down: |
| [rust/arrow/src/datatypes.rs](https://codecov.io/gh/apache/arrow/pull/9077/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZGF0YXR5cGVzLnJz) | `75.02% <ø> (ø)` | |
| [rust/arrow/src/array/transform/list.rs](https://codecov.io/gh/apache/arrow/pull/9077/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2xpc3QucnM=) | `86.20% <66.66%> (+2.33%)` | :arrow_up: |
| [rust/arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow/pull/9077/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL21vZC5ycw==) | `88.29% <83.33%> (ø)` | |
| [rust/arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow/pull/9077/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYnVpbGRlci5ycw==) | `85.23% <86.79%> (-0.67%)` | :arrow_down: |
| [rust/arrow/src/buffer.rs](https://codecov.io/gh/apache/arrow/pull/9077/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYnVmZmVyLnJz) | `95.53% <88.75%> (-2.19%)` | :arrow_down: |
| [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9077/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.54% <100.00%> (ø)` | |
| [rust/arrow/src/array/array\_list.rs](https://codecov.io/gh/apache/arrow/pull/9077/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfbGlzdC5ycw==) | `92.66% <100.00%> (-0.45%)` | :arrow_down: |
| [rust/arrow/src/array/array\_primitive.rs](https://codecov.io/gh/apache/arrow/pull/9077/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfcHJpbWl0aXZlLnJz) | `92.28% <100.00%> (-0.04%)` | :arrow_down: |
| ... and [25 more](https://codecov.io/gh/apache/arrow/pull/9077/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9077?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9077?src=pr&el=footer). Last update [4b7cdcb...c1badea](https://codecov.io/gh/apache/arrow/pull/9077?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao closed pull request #9077: ARROW-11107: [Rust] Faster Length kernel (10%)
Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #9077:
URL: https://github.com/apache/arrow/pull/9077
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9077: ARROW-11107: [Rust] Faster Length kernel (10%)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9077:
URL: https://github.com/apache/arrow/pull/9077#issuecomment-753519077
https://issues.apache.org/jira/browse/ARROW-11107
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org