[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #956: OAK-10199 : Added skelton to perform DetailedGC

["rishabhdaim (via GitHub)" <gi...@apache.org>]

rishabhdaim commented on code in PR #956:
URL: https://github.com/apache/jackrabbit-oak/pull/956#discussion_r1226263478


##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGCRecommendations.java:
##########
@@ -101,6 +108,22 @@ public VersionGCRecommendations(long maxRevisionAgeMs, Checkpoints checkpoints,
         TimeInterval scope = new TimeInterval(oldestPossible, Long.MAX_VALUE);
         scope = scope.notLaterThan(keep.fromMs);
 
+        detailedGCTimestamp = settings.get(SETTINGS_COLLECTION_DETAILED_GC_TIMESTAMP_PROP);
+        if (detailedGCTimestamp == 0) {
+            if (log.isDebugEnabled()) {
+                log.debug("No detailedGCTimestamp found, querying for the oldest deletedOnce candidate");
+            }
+            oldestPossibleFullGC = vgc.getOldestModifiedTimestamp(clock) - 1;
+            if (log.isDebugEnabled()) {
+                log.debug("detailedGCTimestamp found: {}", Utils.timestampToString(oldestPossibleFullGC));
+            }

Review Comment:
   I agree, we can increase the log level to `info`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org