[GitHub] [beam] yixiaoshen commented on a diff in pull request #22966: [#22478]: Add read_time support to Google Firestore connector

[GitBox <gi...@apache.org>]

yixiaoshen commented on code in PR #22966:
URL: https://github.com/apache/beam/pull/22966#discussion_r964300806


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreV1ReadFn.java:
##########
@@ -125,6 +134,13 @@ protected RunQueryRequest setStartFrom(
       return element.toBuilder().setStructuredQuery(builder.build()).build();
     }
 
+    @Override
+    protected RunQueryRequest setReadTime(RunQueryRequest element, @Nullable Instant readTime) {
+      return readTime == null
+          ? element

Review Comment:
   Done, most places use 'element' so I change the rest also to element.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org