You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/25 13:32:37 UTC

[GitHub] [arrow] bkietz commented on a change in pull request #8756: ARROW-10541: [C++] Add re2 library to core arrow / ARROW_WITH_RE2

bkietz commented on a change in pull request #8756:
URL: https://github.com/apache/arrow/pull/8756#discussion_r530376061



##########
File path: cpp/cmake_modules/DefineOptions.cmake
##########
@@ -363,6 +363,8 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")
 
   define_option(ARROW_WITH_UTF8PROC
                 "Build with support for Unicode properties using the utf8proc library" ON)
+  define_option(ARROW_WITH_RE2
+                "Build with support for regular expressions using the re2 library" ON)

Review comment:
       Instead of a comment could that explanation be a parenthesis of the description for this option?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org