You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2016/06/17 20:00:51 UTC

[GitHub] spark pull request #13403: [SPARK-15660][CORE] Update RDD `variance/stdev` d...

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13403#discussion_r67567009
  
    --- Diff: core/src/main/scala/org/apache/spark/util/StatCounter.scala ---
    @@ -104,8 +104,11 @@ class StatCounter(values: TraversableOnce[Double]) extends Serializable {
     
       def min: Double = minValue
     
    -  /** Return the variance of the values. */
    -  def variance: Double = {
    +  /** Return the population variance of the values. */
    +  def variance: Double = popVariance
    --- End diff --
    
    Here is the only changed part of legacy code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org