You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2015/07/22 23:45:49 UTC
Re: Review Request 32415: Patch for SQOOP-1810
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32415/#review92658
-----------------------------------------------------------
Thank you for working on this one Veena. General feedback:
1) Do you think it would make sense to rename the "incremental write mode" to just a "write mode"? I don't see any persisted status here, so it doesn't seem like an incremental import. We're merely choosing a way we'll push data to the database.
2) I quite a few unrelated changes (splitting long lines), could we remove them from the patch?
3) Can we add coverage in integration tests suite?
Jarcec
- Jarek Cecho
On March 25, 2015, 8:18 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32415/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 8:18 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-1810
> https://issues.apache.org/jira/browse/SQOOP-1810
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA for details on tests
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/GenericJdbcConnectorError.java f18acbd
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java a5cd715
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcLoader.java 22b726e
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java c2515a5
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/IncrementalWriteConfig.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/IncrementalWriteMode.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java fd5d54b
> connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-config.properties 52bf631
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestLoader.java 3a73691
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java 17bac77
>
> Diff: https://reviews.apache.org/r/32415/diff/
>
>
> Testing
> -------
>
> see JIRA for details on tests
>
>
> Thanks,
>
> Veena Basavaraj
>
>