You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/26 00:27:46 UTC
[GitHub] [incubator-pinot] harleyjj opened a new pull request #5187: [TE] frontend - harleyjj/validation - surface errors in dom for creat…
harleyjj opened a new pull request #5187: [TE] frontend - harleyjj/validation - surface errors in dom for creat…
URL: https://github.com/apache/incubator-pinot/pull/5187
…e and edit alert
1) Surfaces errors in configuration and preview to the DOM
2) Includes modal for 'more details' if response includes 'more-info' field
3) Styling updates to Create Alert and Edit Alert
4) On successful alert creation, Create Alert transitions to Alert Overview for detection
5) Fixes bug where successful Create Alert shown as error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #5187: [TE] frontend - harleyjj/validation - surface errors in dom for creat…
Posted by GitBox <gi...@apache.org>.
akshayrai commented on a change in pull request #5187: [TE] frontend - harleyjj/validation - surface errors in dom for creat…
URL: https://github.com/apache/incubator-pinot/pull/5187#discussion_r398750291
##########
File path: thirdeye/thirdeye-frontend/app/pods/components/modals/error-modal/component.js
##########
@@ -0,0 +1,17 @@
+/**
Review comment:
Add license header
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] akshayrai merged pull request #5187: [TE] frontend - harleyjj/validation - surface errors in dom for creat…
Posted by GitBox <gi...@apache.org>.
akshayrai merged pull request #5187: [TE] frontend - harleyjj/validation - surface errors in dom for creat…
URL: https://github.com/apache/incubator-pinot/pull/5187
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #5187: [TE] frontend - harleyjj/validation - surface errors in dom for creat…
Posted by GitBox <gi...@apache.org>.
akshayrai commented on a change in pull request #5187: [TE] frontend - harleyjj/validation - surface errors in dom for creat…
URL: https://github.com/apache/incubator-pinot/pull/5187#discussion_r398749979
##########
File path: thirdeye/thirdeye-frontend/app/pods/components/subscription-yaml/template.hbs
##########
@@ -46,3 +68,8 @@
mode="ace/mode/yaml"
}}
</div>
+<div class="col-xs-12">
+ <label for="select-metric" class="control-label te-label te-label--taller required">Can't find your team? Contact
+ <a class="thirdeye-link-secondary-grey" target="_blank" href="mailto:ask_thirdeye@linkedin.com">ask_thirdeye@linkedin.com</a>
Review comment:
Here as well - make email configurable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #5187: [TE] frontend - harleyjj/validation - surface errors in dom for creat…
Posted by GitBox <gi...@apache.org>.
akshayrai commented on a change in pull request #5187: [TE] frontend - harleyjj/validation - surface errors in dom for creat…
URL: https://github.com/apache/incubator-pinot/pull/5187#discussion_r398748198
##########
File path: thirdeye/thirdeye-frontend/app/pods/components/modals/error-modal/template.hbs
##########
@@ -0,0 +1,13 @@
+<div class="row te-modal__settings">
+ <div class="col-md-10 no-padding">
+ <label for="select-metric" class="control-label te-label te-label--taller required">
+ Need support? Share the content below with the Thirdeye team at
+ <a class="thirdeye-link-secondary-grey" target="_blank" href="mailto:ask_thirdeye@linkedin.com">ask_thirdeye@linkedin.com</a>
Review comment:
Can you configure and fetch this email (ask_thirdeye) from the environment.js file? That way, open source users also can customize this as per their help alias.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] harleyjj commented on a change in pull request #5187: [TE] frontend - harleyjj/validation - surface errors in dom for creat…
Posted by GitBox <gi...@apache.org>.
harleyjj commented on a change in pull request #5187: [TE] frontend - harleyjj/validation - surface errors in dom for creat…
URL: https://github.com/apache/incubator-pinot/pull/5187#discussion_r398801638
##########
File path: thirdeye/thirdeye-frontend/app/pods/components/modals/error-modal/component.js
##########
@@ -0,0 +1,17 @@
+/**
Review comment:
I added a ticket to the backlog for adding license headers to the frontend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org