You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by mr...@apache.org on 2016/12/13 10:12:09 UTC
svn commit: r1773939 -
/jackrabbit/oak/trunk/oak-lucene/src/test/java/org/apache/jackrabbit/oak/plugins/index/lucene/directory/CopyOnWriteDirectoryTest.java
Author: mreutegg
Date: Tue Dec 13 10:12:08 2016
New Revision: 1773939
URL: http://svn.apache.org/viewvc?rev=1773939&view=rev
Log:
OAK-5238: IndexCopier causes concurrent update on NodeBuilder
Add ignored test
Added:
jackrabbit/oak/trunk/oak-lucene/src/test/java/org/apache/jackrabbit/oak/plugins/index/lucene/directory/CopyOnWriteDirectoryTest.java (with props)
Added: jackrabbit/oak/trunk/oak-lucene/src/test/java/org/apache/jackrabbit/oak/plugins/index/lucene/directory/CopyOnWriteDirectoryTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-lucene/src/test/java/org/apache/jackrabbit/oak/plugins/index/lucene/directory/CopyOnWriteDirectoryTest.java?rev=1773939&view=auto
==============================================================================
--- jackrabbit/oak/trunk/oak-lucene/src/test/java/org/apache/jackrabbit/oak/plugins/index/lucene/directory/CopyOnWriteDirectoryTest.java (added)
+++ jackrabbit/oak/trunk/oak-lucene/src/test/java/org/apache/jackrabbit/oak/plugins/index/lucene/directory/CopyOnWriteDirectoryTest.java Tue Dec 13 10:12:08 2016
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.jackrabbit.oak.plugins.index.lucene.directory;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.Random;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ThreadFactory;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import org.apache.jackrabbit.oak.plugins.document.DocumentMKBuilderProvider;
+import org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore;
+import org.apache.jackrabbit.oak.plugins.index.lucene.IndexCopier;
+import org.apache.jackrabbit.oak.plugins.index.lucene.IndexDefinition;
+import org.apache.jackrabbit.oak.plugins.index.lucene.writer.IndexWriterUtils;
+import org.apache.jackrabbit.oak.spi.commit.CommitInfo;
+import org.apache.jackrabbit.oak.spi.commit.EmptyHook;
+import org.apache.jackrabbit.oak.spi.state.NodeBuilder;
+import org.apache.lucene.store.Directory;
+import org.apache.lucene.store.IOContext;
+import org.apache.lucene.store.IndexOutput;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Ignore;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+
+import static org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexConstants.INDEX_DATA_CHILD_NAME;
+
+public class CopyOnWriteDirectoryTest {
+
+ @Rule
+ public TemporaryFolder tempFolder = new TemporaryFolder(new File("target"));
+
+ @Rule
+ public DocumentMKBuilderProvider builderProvider = new DocumentMKBuilderProvider();
+
+ private Random rnd = new Random();
+
+ private IndexCopier copier;
+
+ private ExecutorService executor;
+
+ private DocumentNodeStore ns;
+
+ @Before
+ public void before() throws Exception {
+ executor = Executors.newCachedThreadPool(new ThreadFactory() {
+ private final AtomicInteger counter = new AtomicInteger();
+
+ @Override
+ public Thread newThread(Runnable r) {
+ Thread t = new Thread(r);
+ t.setName("IndexCopier-" + counter.incrementAndGet());
+ return t;
+ }
+ });
+ copier = new IndexCopier(executor, tempFolder.newFolder());
+ ns = builderProvider.newBuilder().getNodeStore();
+ }
+
+ @After
+ public void after() throws Exception {
+ ns.dispose();
+ executor.shutdown();
+ executor.awaitTermination(5, TimeUnit.SECONDS);
+ }
+
+ // OAK-5238
+ @Ignore
+ @Test
+ public void copyOnWrite() throws Exception {
+ IndexDefinition def = new IndexDefinition(ns.getRoot(), ns.getRoot(), "/foo");
+ NodeBuilder builder = ns.getRoot().builder();
+ Directory remote = IndexWriterUtils.newIndexDirectory(
+ def, builder.child("foo"), INDEX_DATA_CHILD_NAME, null);
+ Directory dir = copier.wrapForWrite(def, remote, false, INDEX_DATA_CHILD_NAME);
+ addFiles(dir);
+ writeTree(builder);
+ dir.close();
+ ns.merge(builder, EmptyHook.INSTANCE, CommitInfo.EMPTY);
+ }
+
+ private void writeTree(NodeBuilder builder) {
+ NodeBuilder test = builder.child("test");
+ for (int i = 0; i < 100; i++) {
+ NodeBuilder b = test.child("child-" + i);
+ for (int j = 0; j < 10; j++) {
+ NodeBuilder child = b.child("child-" + j);
+ child.setProperty("p", "value");
+ }
+ }
+ }
+
+ private void addFiles(Directory dir) throws IOException {
+ for (int i = 0; i < 100; i++) {
+ byte[] data = randomBytes();
+ IndexOutput out = dir.createOutput("file-" + i, IOContext.DEFAULT);
+ out.writeBytes(data, data.length);
+ out.close();
+ }
+ }
+
+ private byte[] randomBytes() {
+ byte[] data = new byte[1024];
+ rnd.nextBytes(data);
+ return data;
+ }
+}
Propchange: jackrabbit/oak/trunk/oak-lucene/src/test/java/org/apache/jackrabbit/oak/plugins/index/lucene/directory/CopyOnWriteDirectoryTest.java
------------------------------------------------------------------------------
svn:eol-style = native