You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2017/02/28 11:24:14 UTC
Re: Review Request 57137: Table statistics is not getting computed
when 'include columns' is checked
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57137/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 11:24 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
Bugs: AMBARI-20091
https://issues.apache.org/jira/browse/AMBARI-20091
Repository: ambari
Description
-------
1) analyze table compute stats for columns
2) analyze table compute stats
First one is to collect column statistics and second one is to collect basic stats. numRows, dataSize etc. is computed via 2)
To get all stats one has to run both statements.
Hence implemented in that way.
Diffs
-----
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java 902d959
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy PRE-CREATION
Diff: https://reviews.apache.org/r/57137/diff/
Testing
-------
added spock test AnalyzeTableQueryGeneratorSpecTest.groovy
Thanks,
Nitiraj Rathore
Re: Review Request 57137: Table statistics is not getting computed
when 'include columns' is checked
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57137/
-----------------------------------------------------------
(Updated March 2, 2017, 4:31 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
Changes
-------
updated patch after resolving conflicts.
Bugs: AMBARI-20091
https://issues.apache.org/jira/browse/AMBARI-20091
Repository: ambari
Description
-------
1) analyze table compute stats for columns
2) analyze table compute stats
First one is to collect column statistics and second one is to collect basic stats. numRows, dataSize etc. is computed via 2)
To get all stats one has to run both statements.
Hence implemented in that way.
Diffs (updated)
-----
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java dbe9d43
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy 7bc5850
Diff: https://reviews.apache.org/r/57137/diff/2/
Changes: https://reviews.apache.org/r/57137/diff/1-2/
Testing
-------
added spock test AnalyzeTableQueryGeneratorSpecTest.groovy
Thanks,
Nitiraj Rathore
Re: Review Request 57137: Table statistics is not getting computed
when 'include columns' is checked
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57137/#review167269
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On Feb. 28, 2017, 11:24 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57137/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 11:24 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-20091
> https://issues.apache.org/jira/browse/AMBARI-20091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1) analyze table compute stats for columns
> 2) analyze table compute stats
>
> First one is to collect column statistics and second one is to collect basic stats. numRows, dataSize etc. is computed via 2)
> To get all stats one has to run both statements.
>
> Hence implemented in that way.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java 902d959
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57137/diff/1/
>
>
> Testing
> -------
>
> added spock test AnalyzeTableQueryGeneratorSpecTest.groovy
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 57137: Table statistics is not getting computed
when 'include columns' is checked
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57137/#review167260
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 28, 2017, 11:24 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57137/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 11:24 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-20091
> https://issues.apache.org/jira/browse/AMBARI-20091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1) analyze table compute stats for columns
> 2) analyze table compute stats
>
> First one is to collect column statistics and second one is to collect basic stats. numRows, dataSize etc. is computed via 2)
> To get all stats one has to run both statements.
>
> Hence implemented in that way.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java 902d959
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57137/diff/1/
>
>
> Testing
> -------
>
> added spock test AnalyzeTableQueryGeneratorSpecTest.groovy
>
>
> Thanks,
>
> Nitiraj Rathore
>
>